From 1e6fbcafb6aa93b3bbecc32c427c95dcff8ecb80 Mon Sep 17 00:00:00 2001 From: Anmol Singh Bhatia Date: Tue, 8 Apr 2025 17:02:22 +0530 Subject: [PATCH 1/2] chore: cmd-k work item action improvements --- .../actions/issue-actions/actions-list.tsx | 12 ++++++++---- .../actions/issue-actions/change-assignee.tsx | 3 ++- .../actions/issue-actions/change-priority.tsx | 4 ++-- .../actions/issue-actions/change-state.tsx | 3 ++- 4 files changed, 14 insertions(+), 8 deletions(-) diff --git a/web/core/components/command-palette/actions/issue-actions/actions-list.tsx b/web/core/components/command-palette/actions/issue-actions/actions-list.tsx index 6fa28cdceba..93813879349 100644 --- a/web/core/components/command-palette/actions/issue-actions/actions-list.tsx +++ b/web/core/components/command-palette/actions/issue-actions/actions-list.tsx @@ -4,6 +4,7 @@ import { Command } from "cmdk"; import { observer } from "mobx-react"; import { useParams } from "next/navigation"; import { LinkIcon, Signal, Trash2, UserMinus2, UserPlus2, Users } from "lucide-react"; +import { EIssueServiceType } from "@plane/constants"; import { TIssue } from "@plane/types"; // hooks import { DoubleCircleIcon, TOAST_TYPE, setToast } from "@plane/ui"; @@ -26,7 +27,7 @@ export const CommandPaletteIssueActions: React.FC = observer((props) => { // router const { workspaceSlug } = useParams(); // hooks - const { updateIssue } = useIssueDetail(); + const { updateIssue } = useIssueDetail(issueDetails?.is_epic ? EIssueServiceType.EPICS : EIssueServiceType.ISSUES); const { toggleCommandPaletteModal, toggleDeleteIssueModal } = useCommandPalette(); const { data: currentUser } = useUser(); // derived values @@ -72,8 +73,11 @@ export const CommandPaletteIssueActions: React.FC = observer((props) => { }); }; + const actionHeading = issueDetails?.is_epic ? "Epic actions" : "Work item actions"; + const entityType = issueDetails?.is_epic ? "epic" : "work item"; + return ( - + { setPlaceholder("Change state..."); @@ -137,7 +141,7 @@ export const CommandPaletteIssueActions: React.FC = observer((props) => {
- Delete work item + {`Delete ${entityType}`}
= observer((props) => { >
- Copy work item URL + {`Copy ${entityType} URL`}
diff --git a/web/core/components/command-palette/actions/issue-actions/change-assignee.tsx b/web/core/components/command-palette/actions/issue-actions/change-assignee.tsx index ca953adcd30..66b71794d32 100644 --- a/web/core/components/command-palette/actions/issue-actions/change-assignee.tsx +++ b/web/core/components/command-palette/actions/issue-actions/change-assignee.tsx @@ -4,6 +4,7 @@ import { Command } from "cmdk"; import { observer } from "mobx-react"; import { useParams } from "next/navigation"; import { Check } from "lucide-react"; +import { EIssueServiceType } from "@plane/constants"; // plane types import { TIssue } from "@plane/types"; // plane ui @@ -20,7 +21,7 @@ export const ChangeIssueAssignee: React.FC = observer((props) => { // router params const { workspaceSlug } = useParams(); // store - const { updateIssue } = useIssueDetail(); + const { updateIssue } = useIssueDetail(issue?.is_epic ? EIssueServiceType.EPICS : EIssueServiceType.ISSUES); const { project: { getProjectMemberIds, getProjectMemberDetails }, } = useMember(); diff --git a/web/core/components/command-palette/actions/issue-actions/change-priority.tsx b/web/core/components/command-palette/actions/issue-actions/change-priority.tsx index 9e2a874a205..53bada187bd 100644 --- a/web/core/components/command-palette/actions/issue-actions/change-priority.tsx +++ b/web/core/components/command-palette/actions/issue-actions/change-priority.tsx @@ -5,7 +5,7 @@ import { observer } from "mobx-react"; import { useParams } from "next/navigation"; import { Check } from "lucide-react"; // plane constants -import { ISSUE_PRIORITIES } from "@plane/constants"; +import { EIssueServiceType, ISSUE_PRIORITIES } from "@plane/constants"; // plane types import { TIssue, TIssuePriorities } from "@plane/types"; // mobx store @@ -22,7 +22,7 @@ export const ChangeIssuePriority: React.FC = observer((props) => { // router params const { workspaceSlug } = useParams(); // store hooks - const { updateIssue } = useIssueDetail(); + const { updateIssue } = useIssueDetail(issue?.is_epic ? EIssueServiceType.EPICS : EIssueServiceType.ISSUES); // derived values const projectId = issue?.project_id; diff --git a/web/core/components/command-palette/actions/issue-actions/change-state.tsx b/web/core/components/command-palette/actions/issue-actions/change-state.tsx index 154b578b9b6..b89264ec14d 100644 --- a/web/core/components/command-palette/actions/issue-actions/change-state.tsx +++ b/web/core/components/command-palette/actions/issue-actions/change-state.tsx @@ -3,6 +3,7 @@ import { observer } from "mobx-react"; import { useParams } from "next/navigation"; // plane imports +import { EIssueServiceType } from "@plane/constants"; import { TIssue } from "@plane/types"; // store hooks import { useIssueDetail } from "@/hooks/store"; @@ -16,7 +17,7 @@ export const ChangeIssueState: React.FC = observer((props) => { // router params const { workspaceSlug } = useParams(); // store hooks - const { updateIssue } = useIssueDetail(); + const { updateIssue } = useIssueDetail(issue?.is_epic ? EIssueServiceType.EPICS : EIssueServiceType.ISSUES); // derived values const projectId = issue?.project_id; const currentStateId = issue?.state_id; From 9a918c362b848e85ea8b6a167fa1698dfa99a342 Mon Sep 17 00:00:00 2001 From: Anmol Singh Bhatia Date: Tue, 8 Apr 2025 17:10:43 +0530 Subject: [PATCH 2/2] chore: code refactor --- web/core/components/issues/peek-overview/header.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/web/core/components/issues/peek-overview/header.tsx b/web/core/components/issues/peek-overview/header.tsx index a489ad17468..c5d66e87def 100644 --- a/web/core/components/issues/peek-overview/header.tsx +++ b/web/core/components/issues/peek-overview/header.tsx @@ -111,7 +111,7 @@ export const IssuePeekOverviewHeader: FC = observer((pr setToast({ type: TOAST_TYPE.SUCCESS, title: t("common.link_copied"), - message: t("common.copied_to_clipboard"), + message: t("common.link_copied_to_clipboard"), }); }); };