From 83128c24a9b894779c70b099349297dfbe4276b3 Mon Sep 17 00:00:00 2001 From: JayashTripathy Date: Mon, 26 May 2025 20:31:35 +0530 Subject: [PATCH 1/2] chore: added favicon and title of links --- .../issues/issue-detail/links/link-item.tsx | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/web/core/components/issues/issue-detail/links/link-item.tsx b/web/core/components/issues/issue-detail/links/link-item.tsx index edb45bb3b8c..ebdba202d9c 100644 --- a/web/core/components/issues/issue-detail/links/link-item.tsx +++ b/web/core/components/issues/issue-detail/links/link-item.tsx @@ -38,6 +38,8 @@ export const IssueLinkItem: FC = observer((props) => { if (!linkDetail) return <>; const Icon = getIconForLink(linkDetail.url); + const faviconUrl: string | undefined = linkDetail.metadata?.favicon; + const linkTitle: string | undefined = linkDetail.metadata?.title; const toggleIssueLinkModal = (modalToggle: boolean) => { toggleIssueLinkModalStore(modalToggle); @@ -50,15 +52,21 @@ export const IssueLinkItem: FC = observer((props) => { className="group col-span-12 lg:col-span-6 xl:col-span-4 2xl:col-span-3 3xl:col-span-2 flex items-center justify-between gap-3 h-10 flex-shrink-0 px-3 bg-custom-background-90 hover:bg-custom-background-80 border-[0.5px] border-custom-border-200 rounded" >
- + {faviconUrl ? ( + favicon + ) : ( + + )} {linkDetail.title && linkDetail.title !== "" ? linkDetail.title : linkDetail.url} + + {linkTitle && linkTitle !== "" && {linkTitle}}
From e3d8f32513f6119cafc633ec0c4742d952b33e2e Mon Sep 17 00:00:00 2001 From: JayashTripathy Date: Wed, 28 May 2025 20:03:00 +0530 Subject: [PATCH 2/2] feat: add Link icon to issue detail links and update rendering logic --- web/core/components/issues/issue-detail/links/link-item.tsx | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/web/core/components/issues/issue-detail/links/link-item.tsx b/web/core/components/issues/issue-detail/links/link-item.tsx index ebdba202d9c..83ddc4a7df9 100644 --- a/web/core/components/issues/issue-detail/links/link-item.tsx +++ b/web/core/components/issues/issue-detail/links/link-item.tsx @@ -2,7 +2,7 @@ import { FC } from "react"; import { observer } from "mobx-react"; -import { Pencil, Trash2, Copy } from "lucide-react"; +import { Pencil, Trash2, Copy, Link } from "lucide-react"; import { EIssueServiceType } from "@plane/constants"; import { useTranslation } from "@plane/i18n"; import { TIssueServiceType } from "@plane/types"; @@ -37,7 +37,7 @@ export const IssueLinkItem: FC = observer((props) => { const linkDetail = getLinkById(linkId); if (!linkDetail) return <>; - const Icon = getIconForLink(linkDetail.url); + // const Icon = getIconForLink(linkDetail.url); const faviconUrl: string | undefined = linkDetail.metadata?.favicon; const linkTitle: string | undefined = linkDetail.metadata?.title; @@ -55,7 +55,7 @@ export const IssueLinkItem: FC = observer((props) => { {faviconUrl ? ( favicon ) : ( - + )}