From 81dc328159434179dbd7a0268846fa905216f2f5 Mon Sep 17 00:00:00 2001 From: sriram veeraghanta Date: Thu, 3 Jul 2025 03:28:13 +0530 Subject: [PATCH 1/4] feat: adding standard scripts for lint and format check --- apps/admin/package.json | 9 ++++++--- apps/live/package.json | 2 +- apps/space/package.json | 9 ++++++--- apps/web/package.json | 12 ++++++------ package.json | 5 ++--- turbo.json | 27 ++++++++++++++++++++++++--- 6 files changed, 45 insertions(+), 19 deletions(-) diff --git a/apps/admin/package.json b/apps/admin/package.json index 83c01a57e7c..52722466e8b 100644 --- a/apps/admin/package.json +++ b/apps/admin/package.json @@ -10,9 +10,12 @@ "build": "next build", "preview": "next build && next start", "start": "next start", - "format": "prettier --write .", - "lint": "eslint . --ext .ts,.tsx", - "lint:errors": "eslint . --ext .ts,.tsx --quiet" + "clean": "rm -rf .turbo && rm -rf .next && rm -rf node_modules && rm -rf dist", + "check:lint": "eslint . --max-warnings 0", + "check:types": "tsc --noEmit", + "check:format": "prettier --check \"**/*.{ts,tsx,md,json,css,scss}\"", + "fix:lint": "eslint . --fix", + "fix:format": "prettier --write \"**/*.{ts,tsx,md,json,css,scss}\"" }, "dependencies": { "@headlessui/react": "^1.7.19", diff --git a/apps/live/package.json b/apps/live/package.json index 54899d6914a..4bfc3c090ef 100644 --- a/apps/live/package.json +++ b/apps/live/package.json @@ -15,7 +15,7 @@ "check:format": "prettier --check \"**/*.{ts,tsx,md,json,css,scss}\"", "fix:lint": "eslint . --fix", "fix:format": "prettier --write \"**/*.{ts,tsx,md,json,css,scss}\"", - "clean": "rm -rf .turbo && rm -rf node_modules && rm -rf dist" + "clean": "rm -rf .turbo && rm -rf .next && rm -rf node_modules && rm -rf dist" }, "keywords": [], "author": "", diff --git a/apps/space/package.json b/apps/space/package.json index 2159adf56db..97c737e66ea 100644 --- a/apps/space/package.json +++ b/apps/space/package.json @@ -8,9 +8,12 @@ "develop": "next dev -p 3002", "build": "next build", "start": "next start", - "lint": "eslint . --ext .ts,.tsx", - "lint:errors": "eslint . --ext .ts,.tsx --quiet", - "export": "next export" + "clean": "rm -rf .turbo && rm -rf .next && rm -rf node_modules && rm -rf dist", + "check:lint": "eslint . --max-warnings 0", + "check:types": "tsc --noEmit", + "check:format": "prettier --check \"**/*.{ts,tsx,md,json,css,scss}\"", + "fix:lint": "eslint . --fix", + "fix:format": "prettier --write \"**/*.{ts,tsx,md,json,css,scss}\"" }, "dependencies": { "@blueprintjs/core": "^4.16.3", diff --git a/apps/web/package.json b/apps/web/package.json index c1f4d1d2c1a..4f7a8de5414 100644 --- a/apps/web/package.json +++ b/apps/web/package.json @@ -8,12 +8,12 @@ "develop": "next dev --port 3000", "build": "next build", "start": "next start", - "lint": "eslint . --ext .ts,.tsx", - "lint:errors": "eslint . --ext .ts,.tsx --quiet", - "export": "next export", - "clean": "rm -rf .turbo && rm -rf node_modules && rm -rf dist", - "dev:trace": "NEXT_TURBOPACK_TRACING=1 NEXT_CPU_PROF=1 next dev", - "view-trace": "next internal turbo-trace-server ./.next/trace" + "clean": "rm -rf .turbo && rm -rf .next && rm -rf node_modules && rm -rf dist", + "check:lint": "eslint . --max-warnings 0", + "check:types": "tsc --noEmit", + "check:format": "prettier --check \"**/*.{ts,tsx,md,json,css,scss}\"", + "fix:lint": "eslint . --fix", + "fix:format": "prettier --write \"**/*.{ts,tsx,md,json,css,scss}\"" }, "dependencies": { "@atlaskit/pragmatic-drag-and-drop": "^1.1.3", diff --git a/package.json b/package.json index 6faf02651da..0e3d8ab2651 100644 --- a/package.json +++ b/package.json @@ -13,10 +13,9 @@ "build": "turbo run build", "dev": "turbo run dev --concurrency=13", "start": "turbo run start", - "lint": "turbo run lint", - "lint:errors": "turbo run lint:errors", "clean": "turbo run clean", - "format": "prettier --write \"**/*.{ts,tsx,md}\"" + "fix": "turbo run fix", + "check": "turbo run check" }, "devDependencies": { "prettier": "latest", diff --git a/turbo.json b/turbo.json index 36e95edbd4c..00b2e0e7f74 100644 --- a/turbo.json +++ b/turbo.json @@ -34,11 +34,32 @@ "persistent": true, "dependsOn": ["^build"] }, - "test": { + "check:types": { "dependsOn": ["^build"], - "outputs": [] + "cache": false + }, + "check:lint": { + "cache": false + }, + "check:format": { + "cache": false + }, + "check": { + "dependsOn": ["check:format", "check:lint", "check:types"], + "cache": false }, - "lint": { + "fix:lint": { + "cache": false + }, + "fix:format": { + "cache": false + }, + "fix": { + "dependsOn": ["fix:format", "fix:lint"], + "cache": false + }, + "test": { + "dependsOn": ["^build"], "outputs": [] }, "start": { From 8a78e09a7052de40c348df176869e991ba844896 Mon Sep 17 00:00:00 2001 From: sriramveeraghanta Date: Thu, 3 Jul 2025 18:50:38 +0530 Subject: [PATCH 2/4] fix: update packages scripts --- packages/constants/package.json | 2 +- packages/decorators/package.json | 8 ++++++-- packages/editor/package.json | 10 ++++++---- packages/hooks/.eslintrc.js | 3 --- packages/hooks/package.json | 11 ++++++++--- packages/hooks/tsup.config.ts | 9 +++++++++ packages/i18n/package.json | 8 ++++++-- packages/logger/package.json | 9 ++++++--- packages/propel/package.json | 8 ++++++-- packages/services/package.json | 8 ++++++-- packages/shared-state/package.json | 8 ++++++-- packages/types/package.json | 9 +++++---- packages/ui/package.json | 9 ++++++--- 13 files changed, 71 insertions(+), 31 deletions(-) create mode 100644 packages/hooks/tsup.config.ts diff --git a/packages/constants/package.json b/packages/constants/package.json index f0de91401ca..0a80044dfca 100644 --- a/packages/constants/package.json +++ b/packages/constants/package.json @@ -25,7 +25,7 @@ "check:format": "prettier --check \"**/*.{ts,tsx,md,json,css,scss}\"", "fix:lint": "eslint . --fix", "fix:format": "prettier --write \"**/*.{ts,tsx,md,json,css,scss}\"", - "clean": "rm -rf .turbo && rm -rf node_modules && rm -rf dist" + "clean": "rm -rf .turbo && rm -rf .next && rm -rf node_modules && rm -rf dist" }, "dependencies": { "@plane/types": "*" diff --git a/packages/decorators/package.json b/packages/decorators/package.json index 566e3482789..eee96784706 100644 --- a/packages/decorators/package.json +++ b/packages/decorators/package.json @@ -13,8 +13,12 @@ "scripts": { "build": "tsup src/index.ts --format esm,cjs --dts --external express,ws", "dev": "tsup src/index.ts --format esm,cjs --watch --dts --external express,ws", - "lint": "eslint src --ext .ts,.tsx", - "lint:errors": "eslint src --ext .ts,.tsx --quiet" + "check:lint": "eslint . --max-warnings 0", + "check:types": "tsc --noEmit", + "check:format": "prettier --check \"**/*.{ts,tsx,md,json,css,scss}\"", + "fix:lint": "eslint . --fix", + "fix:format": "prettier --write \"**/*.{ts,tsx,md,json,css,scss}\"", + "clean": "rm -rf .turbo && rm -rf .next && rm -rf node_modules && rm -rf dist" }, "dependencies": { "express": "^4.21.2", diff --git a/packages/editor/package.json b/packages/editor/package.json index d1d85433676..34406ca4838 100644 --- a/packages/editor/package.json +++ b/packages/editor/package.json @@ -24,10 +24,12 @@ "scripts": { "build": "tsup --minify", "dev": "tsup --watch", - "check-types": "tsc --noEmit", - "lint": "eslint src --ext .ts,.tsx", - "lint:errors": "eslint src --ext .ts,.tsx --quiet", - "format": "prettier --write \"**/*.{ts,tsx,md}\"" + "check:lint": "eslint . --max-warnings 0", + "check:types": "tsc --noEmit", + "check:format": "prettier --check \"**/*.{ts,tsx,md,json,css,scss}\"", + "fix:lint": "eslint . --fix", + "fix:format": "prettier --write \"**/*.{ts,tsx,md,json,css,scss}\"", + "clean": "rm -rf .turbo && rm -rf .next && rm -rf node_modules && rm -rf dist" }, "peerDependencies": { "react": "^18.3.1", diff --git a/packages/hooks/.eslintrc.js b/packages/hooks/.eslintrc.js index 558b8f76ed4..b11b7bb6d65 100644 --- a/packages/hooks/.eslintrc.js +++ b/packages/hooks/.eslintrc.js @@ -3,7 +3,4 @@ module.exports = { root: true, extends: ["@plane/eslint-config/library.js"], parser: "@typescript-eslint/parser", - parserOptions: { - project: true, - }, }; diff --git a/packages/hooks/package.json b/packages/hooks/package.json index 81484513deb..633372d896b 100644 --- a/packages/hooks/package.json +++ b/packages/hooks/package.json @@ -11,9 +11,14 @@ "dist/**" ], "scripts": { - "build": "tsup ./src/index.ts --format esm,cjs --dts --external react --minify", - "lint": "eslint src --ext .ts,.tsx", - "lint:errors": "eslint src --ext .ts,.tsx --quiet" + "build": "tsup --minify", + "dev": "tsup --watch", + "check:lint": "eslint . --max-warnings 0", + "check:types": "tsc --noEmit", + "check:format": "prettier --check \"**/*.{ts,tsx,md,json,css,scss}\"", + "fix:lint": "eslint . --fix", + "fix:format": "prettier --write \"**/*.{ts,tsx,md,json,css,scss}\"", + "clean": "rm -rf .turbo && rm -rf .next && rm -rf node_modules && rm -rf dist" }, "dependencies": { "react": "^18.3.1" diff --git a/packages/hooks/tsup.config.ts b/packages/hooks/tsup.config.ts new file mode 100644 index 00000000000..c69daf15886 --- /dev/null +++ b/packages/hooks/tsup.config.ts @@ -0,0 +1,9 @@ +import { defineConfig } from "tsup"; + +export default defineConfig({ + entry: ["src/index.ts"], + format: ["esm", "cjs"], + dts: true, + clean: true, + external: ["react"], +}); diff --git a/packages/i18n/package.json b/packages/i18n/package.json index d4faaf0172b..7ab242a0e1b 100644 --- a/packages/i18n/package.json +++ b/packages/i18n/package.json @@ -7,8 +7,12 @@ "main": "./src/index.ts", "types": "./src/index.ts", "scripts": { - "lint": "eslint src --ext .ts,.tsx", - "lint:errors": "eslint src --ext .ts,.tsx --quiet" + "check:lint": "eslint . --max-warnings 0", + "check:types": "tsc --noEmit", + "check:format": "prettier --check \"**/*.{ts,tsx,md,json,css,scss}\"", + "fix:lint": "eslint . --fix", + "fix:format": "prettier --write \"**/*.{ts,tsx,md,json,css,scss}\"", + "clean": "rm -rf .turbo && rm -rf .next && rm -rf node_modules && rm -rf dist" }, "dependencies": { "@plane/utils": "*", diff --git a/packages/logger/package.json b/packages/logger/package.json index ca2a0dbe29f..fb6b8960b19 100644 --- a/packages/logger/package.json +++ b/packages/logger/package.json @@ -13,9 +13,12 @@ "scripts": { "build": "tsc", "dev": "tsc --watch", - "lint": "eslint src --ext .ts,.tsx", - "lint:errors": "eslint src --ext .ts,.tsx --quiet", - "clean": "rm -rf .turbo && rm -rf node_modules && rm -rf dist" + "check:lint": "eslint . --max-warnings 0", + "check:types": "tsc --noEmit", + "check:format": "prettier --check \"**/*.{ts,tsx,md,json,css,scss}\"", + "fix:lint": "eslint . --fix", + "fix:format": "prettier --write \"**/*.{ts,tsx,md,json,css,scss}\"", + "clean": "rm -rf .turbo && rm -rf .next && rm -rf node_modules && rm -rf dist" }, "dependencies": { "@types/express": "^4.17.21", diff --git a/packages/propel/package.json b/packages/propel/package.json index e6922c718f5..b753432cc62 100644 --- a/packages/propel/package.json +++ b/packages/propel/package.json @@ -4,8 +4,12 @@ "private": true, "license": "AGPL-3.0", "scripts": { - "lint": "eslint src --ext .ts,.tsx", - "lint:errors": "eslint src --ext .ts,.tsx --quiet" + "check:lint": "eslint . --max-warnings 0", + "check:types": "tsc --noEmit", + "check:format": "prettier --check \"**/*.{ts,tsx,md,json,css,scss}\"", + "fix:lint": "eslint . --fix", + "fix:format": "prettier --write \"**/*.{ts,tsx,md,json,css,scss}\"", + "clean": "rm -rf .turbo && rm -rf .next && rm -rf node_modules && rm -rf dist" }, "exports": { "./ui/*": "./src/ui/*.tsx", diff --git a/packages/services/package.json b/packages/services/package.json index 449e9efedbf..e9caced1d89 100644 --- a/packages/services/package.json +++ b/packages/services/package.json @@ -5,8 +5,12 @@ "private": true, "main": "./src/index.ts", "scripts": { - "lint": "eslint src --ext .ts,.tsx", - "lint:errors": "eslint src --ext .ts,.tsx --quiet" + "check:lint": "eslint . --max-warnings 0", + "check:types": "tsc --noEmit", + "check:format": "prettier --check \"**/*.{ts,tsx,md,json,css,scss}\"", + "fix:lint": "eslint . --fix", + "fix:format": "prettier --write \"**/*.{ts,tsx,md,json,css,scss}\"", + "clean": "rm -rf .turbo && rm -rf .next && rm -rf node_modules && rm -rf dist" }, "dependencies": { "@plane/constants": "*", diff --git a/packages/shared-state/package.json b/packages/shared-state/package.json index 167c1794a44..666e1481b36 100644 --- a/packages/shared-state/package.json +++ b/packages/shared-state/package.json @@ -7,8 +7,12 @@ "main": "./src/index.ts", "types": "./src/index.ts", "scripts": { - "lint": "eslint src --ext .ts,.tsx", - "lint:errors": "eslint src --ext .ts,.tsx --quiet" + "check:lint": "eslint . --max-warnings 0", + "check:types": "tsc --noEmit", + "check:format": "prettier --check \"**/*.{ts,tsx,md,json,css,scss}\"", + "fix:lint": "eslint . --fix", + "fix:format": "prettier --write \"**/*.{ts,tsx,md,json,css,scss}\"", + "clean": "rm -rf .turbo && rm -rf .next && rm -rf node_modules && rm -rf dist" }, "dependencies": { "zod": "^3.22.2" diff --git a/packages/types/package.json b/packages/types/package.json index f4ae5083186..5e8c6d07db2 100644 --- a/packages/types/package.json +++ b/packages/types/package.json @@ -20,11 +20,12 @@ "scripts": { "dev": "tsup --watch", "build": "tsc --noEmit && tsup", + "check:lint": "eslint . --max-warnings 0", "check:types": "tsc --noEmit", - "check:lint": "eslint src --ext .ts,.tsx", - "check:format": "prettier --check \"**/*.{ts,tsx,md}\"", - "fix:lint": "eslint src --ext .ts,.tsx --fix", - "fix:format": "prettier --write \"**/*.{ts,tsx,md}\"" + "check:format": "prettier --check \"**/*.{ts,tsx,md,json,css,scss}\"", + "fix:lint": "eslint . --fix", + "fix:format": "prettier --write \"**/*.{ts,tsx,md,json,css,scss}\"", + "clean": "rm -rf .turbo && rm -rf .next && rm -rf node_modules && rm -rf dist" }, "devDependencies": { "@plane/eslint-config": "*", diff --git a/packages/ui/package.json b/packages/ui/package.json index bf388c8fb1a..b0af5c5c2ab 100644 --- a/packages/ui/package.json +++ b/packages/ui/package.json @@ -14,12 +14,15 @@ "scripts": { "build": "tsup src/index.ts --format esm,cjs --dts --external react --minify", "dev": "tsup src/index.ts --format esm,cjs --watch --dts --external react", - "clean": "rm -rf .turbo && rm -rf node_modules && rm -rf dist", "storybook": "storybook dev -p 6006", "build-storybook": "storybook build", "postcss": "postcss styles/globals.css -o styles/output.css --watch", - "lint": "eslint src --ext .ts,.tsx", - "lint:errors": "eslint src --ext .ts,.tsx --quiet" + "check:lint": "eslint . --max-warnings 0", + "check:types": "tsc --noEmit", + "check:format": "prettier --check \"**/*.{ts,tsx,md,json,css,scss}\"", + "fix:lint": "eslint . --fix", + "fix:format": "prettier --write \"**/*.{ts,tsx,md,json,css,scss}\"", + "clean": "rm -rf .turbo && rm -rf .next && rm -rf node_modules && rm -rf dist" }, "peerDependencies": { "react": "^18.3.1", From 6b4ec1f0d3a450b7bd7c162268bf39533cdf8a8e Mon Sep 17 00:00:00 2001 From: sriramveeraghanta Date: Fri, 4 Jul 2025 13:46:02 +0530 Subject: [PATCH 3/4] fix: adding tsup config to utils package --- packages/utils/.eslintrc.js | 3 --- packages/utils/package.json | 11 ++++++++--- packages/utils/tsup.config.ts | 8 ++++++++ turbo.json | 8 +------- 4 files changed, 17 insertions(+), 13 deletions(-) create mode 100644 packages/utils/tsup.config.ts diff --git a/packages/utils/.eslintrc.js b/packages/utils/.eslintrc.js index 558b8f76ed4..b11b7bb6d65 100644 --- a/packages/utils/.eslintrc.js +++ b/packages/utils/.eslintrc.js @@ -3,7 +3,4 @@ module.exports = { root: true, extends: ["@plane/eslint-config/library.js"], parser: "@typescript-eslint/parser", - parserOptions: { - project: true, - }, }; diff --git a/packages/utils/package.json b/packages/utils/package.json index ca53a18a066..a753c60c356 100644 --- a/packages/utils/package.json +++ b/packages/utils/package.json @@ -11,9 +11,14 @@ "dist/**" ], "scripts": { - "build": "tsup ./src/index.ts --format esm,cjs --dts --external react --minify", - "lint": "eslint src --ext .ts,.tsx", - "lint:errors": "eslint src --ext .ts,.tsx --quiet" + "build": "tsc --noEmit && tsup --minify", + "dev": "tsup --watch", + "check:lint": "eslint . --max-warnings 0", + "check:types": "tsc --noEmit", + "check:format": "prettier --check \"**/*.{ts,tsx,md,json,css,scss}\"", + "fix:lint": "eslint . --fix", + "fix:format": "prettier --write \"**/*.{ts,tsx,md,json,css,scss}\"", + "clean": "rm -rf .turbo && rm -rf node_modules && rm -rf dist" }, "dependencies": { "@plane/constants": "*", diff --git a/packages/utils/tsup.config.ts b/packages/utils/tsup.config.ts new file mode 100644 index 00000000000..b8d2a4b6e67 --- /dev/null +++ b/packages/utils/tsup.config.ts @@ -0,0 +1,8 @@ +import { defineConfig } from "tsup"; + +export default defineConfig({ + entry: ["src/index.ts"], + format: ["esm", "cjs"], + dts: true, + external: ["react"], +}); diff --git a/turbo.json b/turbo.json index 00b2e0e7f74..308d3d5b321 100644 --- a/turbo.json +++ b/turbo.json @@ -24,15 +24,9 @@ "dependsOn": ["^build"], "outputs": [".next/**", "dist/**"] }, - "develop": { - "cache": false, - "persistent": true, - "dependsOn": ["^build"] - }, "dev": { "cache": false, - "persistent": true, - "dependsOn": ["^build"] + "persistent": true }, "check:types": { "dependsOn": ["^build"], From d959e07a29ac635104c8bc8ac11de541e7d08310 Mon Sep 17 00:00:00 2001 From: sriramveeraghanta Date: Fri, 4 Jul 2025 14:22:42 +0530 Subject: [PATCH 4/4] chore: updated build scripts in logger pacakge --- packages/logger/package.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/logger/package.json b/packages/logger/package.json index cd1969ee82d..05715d2deac 100644 --- a/packages/logger/package.json +++ b/packages/logger/package.json @@ -11,8 +11,8 @@ "dist/**" ], "scripts": { - "build": "tsc", - "dev": "tsc --watch", + "build": "tsup --minify", + "dev": "tsup --watch", "check:lint": "eslint . --max-warnings 0", "check:types": "tsc --noEmit", "check:format": "prettier --check \"**/*.{ts,tsx,md,json,css,scss}\"",