From e788221438f122cb056cfa944c74d33104194d12 Mon Sep 17 00:00:00 2001 From: vamsikrishnamathala Date: Fri, 18 Jul 2025 11:45:05 +0530 Subject: [PATCH 1/2] fix: removed redundant state indicator --- .../sub-issues/issues-list/list-item.tsx | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/apps/web/core/components/issues/issue-detail-widgets/sub-issues/issues-list/list-item.tsx b/apps/web/core/components/issues/issue-detail-widgets/sub-issues/issues-list/list-item.tsx index cb0a9c75f8f..62e59eb2603 100644 --- a/apps/web/core/components/issues/issue-detail-widgets/sub-issues/issues-list/list-item.tsx +++ b/apps/web/core/components/issues/issue-detail-widgets/sub-issues/issues-list/list-item.tsx @@ -11,7 +11,7 @@ import { cn, generateWorkItemLink } from "@plane/utils"; import { useSubIssueOperations } from "@/components/issues/issue-detail-widgets/sub-issues/helper"; import { WithDisplayPropertiesHOC } from "@/components/issues/issue-layouts/properties/with-display-properties-HOC"; // hooks -import { useIssueDetail, useProject, useProjectState } from "@/hooks/store"; +import { useIssueDetail, useProject } from "@/hooks/store"; import useIssuePeekOverviewRedirection from "@/hooks/use-issue-peek-overview-redirection"; import { usePlatformOS } from "@/hooks/use-platform-os"; // plane web components @@ -65,16 +65,12 @@ export const SubIssuesListItem: React.FC = observer((props) => { const { fetchSubIssues } = useSubIssueOperations(EIssueServiceType.ISSUES); const { toggleCreateIssueModal, toggleDeleteIssueModal } = useIssueDetail(issueServiceType); const project = useProject(); - const { getProjectStates } = useProjectState(); const { handleRedirection } = useIssuePeekOverviewRedirection(); const { isMobile } = usePlatformOS(); const issue = getIssueById(issueId); // derived values const projectDetail = (issue && issue.project_id && project.getProjectById(issue.project_id)) || undefined; - const currentIssueStateDetail = - (issue?.project_id && getProjectStates(issue?.project_id)?.find((state) => issue?.state_id == state.id)) || - undefined; const subIssueHelpers = subIssueHelpersByIssueId(parentIssueId); const subIssueCount = issue?.sub_issues_count ?? 0; @@ -147,12 +143,6 @@ export const SubIssuesListItem: React.FC = observer((props) => {
-
{projectDetail && ( From 7cceaf9779cde3ac1d0e58b75b4832a60d620be0 Mon Sep 17 00:00:00 2001 From: vamsikrishnamathala Date: Fri, 18 Jul 2025 12:03:20 +0530 Subject: [PATCH 2/2] fix: removed redundant state indicator for relation list item --- .../components/issues/relations/issue-list-item.tsx | 13 ++----------- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git a/apps/web/core/components/issues/relations/issue-list-item.tsx b/apps/web/core/components/issues/relations/issue-list-item.tsx index c09560b467b..a344969e2d0 100644 --- a/apps/web/core/components/issues/relations/issue-list-item.tsx +++ b/apps/web/core/components/issues/relations/issue-list-item.tsx @@ -12,7 +12,7 @@ import { generateWorkItemLink } from "@plane/utils"; import { RelationIssueProperty } from "@/components/issues/relations"; // helpers // hooks -import { useIssueDetail, useProject, useProjectState } from "@/hooks/store"; +import { useIssueDetail, useProject } from "@/hooks/store"; import useIssuePeekOverviewRedirection from "@/hooks/use-issue-peek-overview-redirection"; import { usePlatformOS } from "@/hooks/use-platform-os"; // plane web components @@ -58,7 +58,6 @@ export const RelationIssueListItem: FC = observer((props) => { toggleDeleteIssueModal, } = useIssueDetail(issueServiceType); const project = useProject(); - const { getProjectStates } = useProjectState(); const { isMobile } = usePlatformOS(); // derived values const issue = getIssueById(relationIssueId); @@ -66,9 +65,7 @@ export const RelationIssueListItem: FC = observer((props) => { const issueOperations = useRelationOperations(!!issue?.is_epic ? EIssueServiceType.EPICS : EIssueServiceType.ISSUES); const projectDetail = (issue && issue.project_id && project.getProjectById(issue.project_id)) || undefined; const projectId = issue?.project_id; - const currentIssueStateDetail = - (issue?.project_id && getProjectStates(issue?.project_id)?.find((state) => issue?.state_id == state.id)) || - undefined; + if (!issue || !projectId) return <>; const workItemLink = generateWorkItemLink({ @@ -129,12 +126,6 @@ export const RelationIssueListItem: FC = observer((props) => {
-
{projectDetail && (