From b7784acb02d4d1587fcd6eaf55659acbea382dde Mon Sep 17 00:00:00 2001 From: merrime-n <100111649+merrime-n@users.noreply.github.com> Date: Tue, 22 Jul 2025 14:31:41 +0330 Subject: [PATCH 1/2] improve the comprehensiblity of translation contribution docs --- CONTRIBUTING.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 1ff77f449fe..02dc17fa6e0 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -187,7 +187,7 @@ Adding a new language involves several steps to ensure it integrates seamlessly Add the new language to the TLanguage type in the language definitions file: ```typescript - // types/language.ts + // packages/i18n/src/types/language.ts export type TLanguage = "en" | "fr" | "your-lang"; ``` @@ -195,7 +195,7 @@ Adding a new language involves several steps to ensure it integrates seamlessly Include the new language in the list of supported languages: ```typescript - // constants/language.ts + // packages/i18n/src/constants/language.ts export const SUPPORTED_LANGUAGES: ILanguageOption[] = [ { label: "English", value: "en" }, { label: "Your Language", value: "your-lang" } From df021e974faea8b97d9cd8514ad2f6c86482f852 Mon Sep 17 00:00:00 2001 From: merrime-n <100111649+merrime-n@users.noreply.github.com> Date: Tue, 22 Jul 2025 14:45:04 +0330 Subject: [PATCH 2/2] Update CONTRIBUTING.md to fix the code blocks appeareance --- CONTRIBUTING.md | 48 +++++++++++++++++++++++------------------------- 1 file changed, 23 insertions(+), 25 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 02dc17fa6e0..c401c3c2cf5 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -186,41 +186,39 @@ Adding a new language involves several steps to ensure it integrates seamlessly 1. **Update type definitions** Add the new language to the TLanguage type in the language definitions file: - ```typescript - // packages/i18n/src/types/language.ts - export type TLanguage = "en" | "fr" | "your-lang"; - ``` +```ts + // packages/i18n/src/types/language.ts + export type TLanguage = "en" | "fr" | "your-lang"; +``` -2. **Add language configuration** +1. **Add language configuration** Include the new language in the list of supported languages: +```ts + // packages/i18n/src/constants/language.ts + export const SUPPORTED_LANGUAGES: ILanguageOption[] = [ + { label: "English", value: "en" }, + { label: "Your Language", value: "your-lang" } + ]; +``` - ```typescript - // packages/i18n/src/constants/language.ts - export const SUPPORTED_LANGUAGES: ILanguageOption[] = [ - { label: "English", value: "en" }, - { label: "Your Language", value: "your-lang" } - ]; - ``` - -3. **Create translation files** +2. **Create translation files** 1. Create a new folder for your language under locales (e.g., `locales/your-lang/`). 2. Add a `translations.json` file inside the folder. 3. Copy the structure from an existing translation file and translate all keys. -4. **Update import logic** +3. **Update import logic** Modify the language import logic to include your new language: - - ```typescript - private importLanguageFile(language: TLanguage): Promise { - switch (language) { - case "your-lang": - return import("../locales/your-lang/translations.json"); - // ... - } - } - ``` +```ts + private importLanguageFile(language: TLanguage): Promise { + switch (language) { + case "your-lang": + return import("../locales/your-lang/translations.json"); + // ... + } + } +``` ### Quality checklist