diff --git a/packages/editor/package.json b/packages/editor/package.json index 406f7224b94..0c367628b3c 100644 --- a/packages/editor/package.json +++ b/packages/editor/package.json @@ -25,7 +25,7 @@ "build": "tsc && tsdown", "dev": "tsdown --watch", "check:lint": "eslint . --max-warnings 30", - "check:types": "tsc --noEmit", + "check:types": "tsc", "check:format": "prettier --check \"**/*.{ts,tsx,md,json,css,scss}\"", "fix:lint": "eslint . --fix", "fix:format": "prettier --write \"**/*.{ts,tsx,md,json,css,scss}\"", diff --git a/packages/editor/src/core/components/menus/bubble-menu/root.tsx b/packages/editor/src/core/components/menus/bubble-menu/root.tsx index 002cf0ab66d..cf0b6171c76 100644 --- a/packages/editor/src/core/components/menus/bubble-menu/root.tsx +++ b/packages/editor/src/core/components/menus/bubble-menu/root.tsx @@ -152,7 +152,7 @@ export const EditorBubbleMenu: FC = (props) => { if (menuRef.current?.contains(e.target as Node)) return; function handleMouseMove() { - if (!editor.state.selection.empty) { + if (!editor?.state.selection.empty) { setIsSelecting(true); document.removeEventListener("mousemove", handleMouseMove); } @@ -175,6 +175,8 @@ export const EditorBubbleMenu: FC = (props) => { }; }, [editor]); + if (!editor) return null; + return ( {!isSelecting && ( diff --git a/packages/editor/src/core/extensions/mentions/utils.ts b/packages/editor/src/core/extensions/mentions/utils.ts index 202999a09a8..47da2bf1eee 100644 --- a/packages/editor/src/core/extensions/mentions/utils.ts +++ b/packages/editor/src/core/extensions/mentions/utils.ts @@ -6,7 +6,7 @@ import { CORE_EXTENSIONS } from "@/constants/extension"; import { updateFloatingUIFloaterPosition } from "@/helpers/floating-ui"; import { CommandListInstance, DROPDOWN_NAVIGATION_KEYS } from "@/helpers/tippy"; // types -import { TMentionHandler } from "@/types"; +import type { TMentionHandler } from "@/types"; // local components import { MentionsListDropdown, MentionsListDropdownProps } from "./mentions-list-dropdown"; diff --git a/packages/editor/src/core/plugins/file/restore.ts b/packages/editor/src/core/plugins/file/restore.ts index cf25a818bb1..9d35d7d8624 100644 --- a/packages/editor/src/core/plugins/file/restore.ts +++ b/packages/editor/src/core/plugins/file/restore.ts @@ -42,7 +42,7 @@ export const TrackFileRestorationPlugin = (editor: Editor, restoreHandler: TFile const nodeType = node.type.name as keyof NodeFileMapType; const isAValidNode = NODE_FILE_MAP[nodeType]; // if the node doesn't match, then return as no point in checking - if (!isAValidNode) return; + if (!isAValidNode || !nodeType) return; if (pos < 0 || pos > newState.doc.content.size) return; if (oldFileSources[nodeType]?.has(node.attrs.src)) return; // update assets list storage value diff --git a/packages/editor/tsconfig.json b/packages/editor/tsconfig.json index b5634236f9e..5e82e506867 100644 --- a/packages/editor/tsconfig.json +++ b/packages/editor/tsconfig.json @@ -6,7 +6,6 @@ "module": "ES2022", "moduleResolution": "Bundler", "noEmit": true, - "strict": true, "skipLibCheck": true, "sourceMap": true, "baseUrl": ".", @@ -14,10 +13,7 @@ "@/*": ["./src/core/*"], "@/styles/*": ["./src/styles/*"], "@/plane-editor/*": ["./src/ce/*"] - }, - "strictNullChecks": true, - "allowSyntheticDefaultImports": true + } }, - "include": ["src/**/*", "index.d.ts"], - "exclude": ["dist", "build", "node_modules"] + "include": ["src/**/*", "index.d.ts"] } diff --git a/packages/hooks/package.json b/packages/hooks/package.json index b4db5bcbf83..46fd97b9961 100644 --- a/packages/hooks/package.json +++ b/packages/hooks/package.json @@ -16,7 +16,7 @@ "build": "tsdown", "dev": "tsdown --watch", "check:lint": "eslint . --max-warnings 6", - "check:types": "tsc --noEmit", + "check:types": "tsc", "check:format": "prettier --check \"**/*.{ts,tsx,md,json,css,scss}\"", "fix:lint": "eslint . --fix", "fix:format": "prettier --write \"**/*.{ts,tsx,md,json,css,scss}\"", diff --git a/packages/hooks/tsconfig.json b/packages/hooks/tsconfig.json index e8af9092ad7..92fe351e44a 100644 --- a/packages/hooks/tsconfig.json +++ b/packages/hooks/tsconfig.json @@ -1,9 +1,7 @@ { "extends": "@plane/typescript-config/react-library.json", "compilerOptions": { - "jsx": "react", - "lib": ["esnext", "dom"] + "noEmit": true }, - "include": ["./src"], - "exclude": ["dist", "build", "node_modules"] + "include": ["./src"] } diff --git a/packages/i18n/package.json b/packages/i18n/package.json index b2698a507b4..2efc51a2a6f 100644 --- a/packages/i18n/package.json +++ b/packages/i18n/package.json @@ -4,6 +4,9 @@ "license": "AGPL-3.0", "description": "I18n shared across multiple apps internally", "private": true, + "main": "./dist/index.js", + "module": "./dist/index.mjs", + "types": "./dist/index.d.ts", "exports": { ".": { "import": "./dist/index.mjs", @@ -13,7 +16,7 @@ }, "scripts": { "dev": "tsdown --watch", - "build": "tsdown", + "build": "tsc && tsdown", "check:lint": "eslint . --max-warnings 2", "check:types": "tsc --noEmit", "check:format": "prettier --check \"**/*.{ts,tsx,md,json,css,scss}\"", @@ -37,8 +40,5 @@ "@types/react": "catalog:", "tsdown": "catalog:", "typescript": "catalog:" - }, - "main": "./dist/index.js", - "module": "./dist/index.mjs", - "types": "./dist/index.d.ts" + } } diff --git a/packages/i18n/tsconfig.json b/packages/i18n/tsconfig.json index 6599e6e82aa..cf2d392f7a2 100644 --- a/packages/i18n/tsconfig.json +++ b/packages/i18n/tsconfig.json @@ -1,10 +1,8 @@ { "extends": "@plane/typescript-config/react-library.json", "compilerOptions": { - "jsx": "react", - "lib": ["esnext", "dom"], - "resolveJsonModule": true + "resolveJsonModule": true, + "noEmit": true }, - "include": ["./src"], - "exclude": ["dist", "build", "node_modules"] + "include": ["./src"] } diff --git a/packages/propel/package.json b/packages/propel/package.json index 304c4483d97..2bb31a50dab 100644 --- a/packages/propel/package.json +++ b/packages/propel/package.json @@ -7,7 +7,7 @@ "dev": "tsdown --watch", "build": "tsdown", "check:lint": "eslint . --max-warnings 7", - "check:types": "tsc --noEmit", + "check:types": "tsc", "check:format": "prettier --check \"**/*.{ts,tsx,md,json,css,scss}\"", "fix:lint": "eslint . --fix", "fix:format": "prettier --write \"**/*.{ts,tsx,md,json,css,scss}\"", diff --git a/packages/propel/tsconfig.json b/packages/propel/tsconfig.json index 873c92af078..4498ea2b8fc 100644 --- a/packages/propel/tsconfig.json +++ b/packages/propel/tsconfig.json @@ -1,9 +1,7 @@ { "extends": "@plane/typescript-config/react-library.json", "compilerOptions": { - "jsx": "react-jsx", - "lib": ["esnext", "dom"] + "noEmit": true }, - "include": ["src"], - "exclude": ["node_modules", "dist"] + "include": ["src"] } diff --git a/packages/services/package.json b/packages/services/package.json index 469485338a0..83baf576456 100644 --- a/packages/services/package.json +++ b/packages/services/package.json @@ -3,7 +3,6 @@ "version": "1.1.0", "license": "AGPL-3.0", "private": true, - "type": "module", "exports": { ".": { "import": "./dist/index.js", @@ -12,10 +11,10 @@ "./package.json": "./package.json" }, "scripts": { - "build": "tsdown", + "build": "tsc && tsdown", "dev": "tsdown --watch", "check:lint": "eslint . --max-warnings 62", - "check:types": "tsc --noEmit", + "check:types": "tsc", "check:format": "prettier --check \"**/*.{ts,tsx,md,json,css,scss}\"", "fix:lint": "eslint . --fix", "fix:format": "prettier --write \"**/*.{ts,tsx,md,json,css,scss}\"", diff --git a/packages/services/tsconfig.json b/packages/services/tsconfig.json index e8af9092ad7..92fe351e44a 100644 --- a/packages/services/tsconfig.json +++ b/packages/services/tsconfig.json @@ -1,9 +1,7 @@ { "extends": "@plane/typescript-config/react-library.json", "compilerOptions": { - "jsx": "react", - "lib": ["esnext", "dom"] + "noEmit": true }, - "include": ["./src"], - "exclude": ["dist", "build", "node_modules"] + "include": ["./src"] } diff --git a/packages/shared-state/package.json b/packages/shared-state/package.json index 7dd11e4df9c..acdcfd6e916 100644 --- a/packages/shared-state/package.json +++ b/packages/shared-state/package.json @@ -8,7 +8,7 @@ "types": "./src/index.ts", "scripts": { "check:lint": "eslint . --max-warnings 4", - "check:types": "tsc --noEmit", + "check:types": "tsc", "check:format": "prettier --check \"**/*.{ts,tsx,md,json,css,scss}\"", "fix:lint": "eslint . --fix", "fix:format": "prettier --write \"**/*.{ts,tsx,md,json,css,scss}\"", diff --git a/packages/shared-state/tsconfig.json b/packages/shared-state/tsconfig.json index 0c2f64d1a8c..8549c6a84fd 100644 --- a/packages/shared-state/tsconfig.json +++ b/packages/shared-state/tsconfig.json @@ -1,12 +1,10 @@ { "extends": "@plane/typescript-config/react-library.json", "compilerOptions": { - "jsx": "react", - "lib": ["esnext", "dom"], + "noEmit": true, "paths": { "@/*": ["./src/*"] } }, - "include": ["./src"], - "exclude": ["dist", "build", "node_modules"] + "include": ["./src"] } diff --git a/packages/typescript-config/base.json b/packages/typescript-config/base.json index 8844bd66bec..64977d8612d 100644 --- a/packages/typescript-config/base.json +++ b/packages/typescript-config/base.json @@ -6,13 +6,14 @@ "esModuleInterop": true, "incremental": false, "isolatedModules": true, - "lib": ["es2022", "DOM", "DOM.Iterable"], + "lib": ["ESNext", "DOM", "DOM.Iterable"], "module": "NodeNext", "moduleDetection": "force", "moduleResolution": "NodeNext", "resolveJsonModule": true, "skipLibCheck": true, "strict": true, + "strictNullChecks": true, "target": "ES2022" } } diff --git a/packages/typescript-config/react-library.json b/packages/typescript-config/react-library.json index 6065fccff50..0f0f35317e0 100644 --- a/packages/typescript-config/react-library.json +++ b/packages/typescript-config/react-library.json @@ -2,8 +2,11 @@ "$schema": "https://json.schemastore.org/tsconfig", "extends": "./base.json", "compilerOptions": { + "allowSyntheticDefaultImports": true, + "sourceMap": true, "module": "Preserve", "moduleResolution": "bundler", "jsx": "react-jsx" - } + }, + "exclude": ["dist", "build", "node_modules"] } diff --git a/packages/ui/package.json b/packages/ui/package.json index a82ba06467f..9391f14b6f5 100644 --- a/packages/ui/package.json +++ b/packages/ui/package.json @@ -17,13 +17,13 @@ "./package.json": "./package.json" }, "scripts": { - "build": "tsdown", + "build": "tsc && tsdown", "dev": "tsdown --watch", "storybook": "storybook dev -p 6006", "build-storybook": "storybook build", "postcss": "postcss styles/globals.css -o styles/output.css --watch", "check:lint": "eslint . --max-warnings 94", - "check:types": "tsc --noEmit", + "check:types": "tsc", "check:format": "prettier --check \"**/*.{ts,tsx,md,json,css,scss}\"", "fix:lint": "eslint . --fix", "fix:format": "prettier --write \"**/*.{ts,tsx,md,json,css,scss}\"", diff --git a/packages/ui/src/sortable/draggable.tsx b/packages/ui/src/sortable/draggable.tsx index 98db1b6bd67..efc2f185fca 100644 --- a/packages/ui/src/sortable/draggable.tsx +++ b/packages/ui/src/sortable/draggable.tsx @@ -1,12 +1,6 @@ -import { combine } from "@atlaskit/pragmatic-drag-and-drop/dist/cjs/entry-point/combine.js"; -import { - draggable, - dropTargetForElements, -} from "@atlaskit/pragmatic-drag-and-drop/dist/cjs/entry-point/element/adapter.js"; -import { - attachClosestEdge, - extractClosestEdge, -} from "@atlaskit/pragmatic-drag-and-drop-hitbox/dist/cjs/closest-edge.js"; +import { combine } from "@atlaskit/pragmatic-drag-and-drop/combine"; +import { draggable, dropTargetForElements } from "@atlaskit/pragmatic-drag-and-drop/element/adapter"; +import { attachClosestEdge, extractClosestEdge } from "@atlaskit/pragmatic-drag-and-drop-hitbox/closest-edge"; import { isEqual } from "lodash-es"; import React, { useEffect, useRef, useState } from "react"; import { DropIndicator } from "../drop-indicator"; diff --git a/packages/ui/src/sortable/sortable.tsx b/packages/ui/src/sortable/sortable.tsx index 36391a18b39..29198ed8b5d 100644 --- a/packages/ui/src/sortable/sortable.tsx +++ b/packages/ui/src/sortable/sortable.tsx @@ -1,4 +1,4 @@ -import { monitorForElements } from "@atlaskit/pragmatic-drag-and-drop/dist/cjs/entry-point/element/adapter.js"; +import { monitorForElements } from "@atlaskit/pragmatic-drag-and-drop/element/adapter"; import React, { Fragment, useEffect, useMemo } from "react"; import { Draggable } from "./draggable"; diff --git a/packages/ui/tsconfig.json b/packages/ui/tsconfig.json index 2466c25e0d7..7cdf2f71861 100644 --- a/packages/ui/tsconfig.json +++ b/packages/ui/tsconfig.json @@ -3,6 +3,6 @@ "include": ["src"], "exclude": ["dist", "build", "node_modules"], "compilerOptions": { - "esModuleInterop": true + "noEmit": true } } diff --git a/packages/utils/package.json b/packages/utils/package.json index 65e3165b8dc..4ee77203a1a 100644 --- a/packages/utils/package.json +++ b/packages/utils/package.json @@ -13,10 +13,10 @@ "./package.json": "./package.json" }, "scripts": { - "build": "tsdown", + "build": "tsc && tsdown", "dev": "tsdown --watch", "check:lint": "eslint . --max-warnings 20", - "check:types": "tsc --noEmit", + "check:types": "tsc", "check:format": "prettier --check \"**/*.{ts,tsx,md,json,css,scss}\"", "fix:lint": "eslint . --fix", "fix:format": "prettier --write \"**/*.{ts,tsx,md,json,css,scss}\"", diff --git a/packages/utils/tsconfig.json b/packages/utils/tsconfig.json index 2256a0d8ff0..d807a19a2ac 100644 --- a/packages/utils/tsconfig.json +++ b/packages/utils/tsconfig.json @@ -1,5 +1,8 @@ { "extends": "@plane/typescript-config/react-library.json", + "compilerOptions": { + "noEmit": true + }, "include": ["./src"], "exclude": ["dist", "build", "node_modules"] } diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml index 2d2a9154399..71d34afb688 100644 --- a/pnpm-lock.yaml +++ b/pnpm-lock.yaml @@ -9448,7 +9448,7 @@ snapshots: '@tybys/wasm-util': 0.10.1 optional: true - '@napi-rs/wasm-runtime@1.0.3': + '@napi-rs/wasm-runtime@1.0.5': dependencies: '@emnapi/core': 1.5.0 '@emnapi/runtime': 1.5.0 @@ -9796,9 +9796,7 @@ snapshots: '@opentelemetry/api': 1.9.0 '@opentelemetry/core': 2.1.0(@opentelemetry/api@1.9.0) - '@oxc-project/runtime@0.82.3': {} - - '@oxc-project/types@0.82.3': {} + '@oxc-project/types@0.89.0': {} '@pkgjs/parseargs@0.11.0': optional: true @@ -10272,48 +10270,48 @@ snapshots: '@rolldown/binding-android-arm64@1.0.0-beta.34': optional: true - '@rolldown/binding-darwin-arm64@1.0.0-beta.34': + '@rolldown/binding-darwin-arm64@1.0.0-beta.38': optional: true - '@rolldown/binding-darwin-x64@1.0.0-beta.34': + '@rolldown/binding-darwin-x64@1.0.0-beta.38': optional: true - '@rolldown/binding-freebsd-x64@1.0.0-beta.34': + '@rolldown/binding-freebsd-x64@1.0.0-beta.38': optional: true - '@rolldown/binding-linux-arm-gnueabihf@1.0.0-beta.34': + '@rolldown/binding-linux-arm-gnueabihf@1.0.0-beta.38': optional: true - '@rolldown/binding-linux-arm64-gnu@1.0.0-beta.34': + '@rolldown/binding-linux-arm64-gnu@1.0.0-beta.38': optional: true - '@rolldown/binding-linux-arm64-musl@1.0.0-beta.34': + '@rolldown/binding-linux-arm64-musl@1.0.0-beta.38': optional: true - '@rolldown/binding-linux-x64-gnu@1.0.0-beta.34': + '@rolldown/binding-linux-x64-gnu@1.0.0-beta.38': optional: true - '@rolldown/binding-linux-x64-musl@1.0.0-beta.34': + '@rolldown/binding-linux-x64-musl@1.0.0-beta.38': optional: true - '@rolldown/binding-openharmony-arm64@1.0.0-beta.34': + '@rolldown/binding-openharmony-arm64@1.0.0-beta.38': optional: true - '@rolldown/binding-wasm32-wasi@1.0.0-beta.34': + '@rolldown/binding-wasm32-wasi@1.0.0-beta.38': dependencies: - '@napi-rs/wasm-runtime': 1.0.3 + '@napi-rs/wasm-runtime': 1.0.5 optional: true - '@rolldown/binding-win32-arm64-msvc@1.0.0-beta.34': + '@rolldown/binding-win32-arm64-msvc@1.0.0-beta.38': optional: true - '@rolldown/binding-win32-ia32-msvc@1.0.0-beta.34': + '@rolldown/binding-win32-ia32-msvc@1.0.0-beta.38': optional: true - '@rolldown/binding-win32-x64-msvc@1.0.0-beta.34': + '@rolldown/binding-win32-x64-msvc@1.0.0-beta.38': optional: true - '@rolldown/pluginutils@1.0.0-beta.34': {} + '@rolldown/pluginutils@1.0.0-beta.38': {} '@rollup/pluginutils@5.2.0(rollup@4.52.4)': dependencies: @@ -15551,7 +15549,7 @@ snapshots: dependencies: glob: 7.2.3 - rolldown-plugin-dts@0.16.11(rolldown@1.0.0-beta.34)(typescript@5.8.3): + rolldown-plugin-dts@0.16.11(rolldown@1.0.0-beta.38)(typescript@5.8.3): dependencies: '@babel/generator': 7.28.3 '@babel/parser': 7.28.4 @@ -15562,34 +15560,34 @@ snapshots: dts-resolver: 2.1.2 get-tsconfig: 4.10.1 magic-string: 0.30.19 - rolldown: 1.0.0-beta.34 + rolldown: 1.0.0-beta.38 optionalDependencies: typescript: 5.8.3 transitivePeerDependencies: - oxc-resolver - supports-color - rolldown@1.0.0-beta.34: + rolldown@1.0.0-beta.38: dependencies: '@oxc-project/runtime': 0.82.3 '@oxc-project/types': 0.82.3 '@rolldown/pluginutils': 1.0.0-beta.34 ansis: 4.2.0 optionalDependencies: - '@rolldown/binding-android-arm64': 1.0.0-beta.34 - '@rolldown/binding-darwin-arm64': 1.0.0-beta.34 - '@rolldown/binding-darwin-x64': 1.0.0-beta.34 - '@rolldown/binding-freebsd-x64': 1.0.0-beta.34 - '@rolldown/binding-linux-arm-gnueabihf': 1.0.0-beta.34 - '@rolldown/binding-linux-arm64-gnu': 1.0.0-beta.34 - '@rolldown/binding-linux-arm64-musl': 1.0.0-beta.34 - '@rolldown/binding-linux-x64-gnu': 1.0.0-beta.34 - '@rolldown/binding-linux-x64-musl': 1.0.0-beta.34 - '@rolldown/binding-openharmony-arm64': 1.0.0-beta.34 - '@rolldown/binding-wasm32-wasi': 1.0.0-beta.34 - '@rolldown/binding-win32-arm64-msvc': 1.0.0-beta.34 - '@rolldown/binding-win32-ia32-msvc': 1.0.0-beta.34 - '@rolldown/binding-win32-x64-msvc': 1.0.0-beta.34 + '@rolldown/binding-android-arm64': 1.0.0-beta.38 + '@rolldown/binding-darwin-arm64': 1.0.0-beta.38 + '@rolldown/binding-darwin-x64': 1.0.0-beta.38 + '@rolldown/binding-freebsd-x64': 1.0.0-beta.38 + '@rolldown/binding-linux-arm-gnueabihf': 1.0.0-beta.38 + '@rolldown/binding-linux-arm64-gnu': 1.0.0-beta.38 + '@rolldown/binding-linux-arm64-musl': 1.0.0-beta.38 + '@rolldown/binding-linux-x64-gnu': 1.0.0-beta.38 + '@rolldown/binding-linux-x64-musl': 1.0.0-beta.38 + '@rolldown/binding-openharmony-arm64': 1.0.0-beta.38 + '@rolldown/binding-wasm32-wasi': 1.0.0-beta.38 + '@rolldown/binding-win32-arm64-msvc': 1.0.0-beta.38 + '@rolldown/binding-win32-ia32-msvc': 1.0.0-beta.38 + '@rolldown/binding-win32-x64-msvc': 1.0.0-beta.38 rollup@4.52.4: dependencies: @@ -16250,8 +16248,8 @@ snapshots: diff: 8.0.2 empathic: 2.0.0 hookable: 5.5.3 - rolldown: 1.0.0-beta.34 - rolldown-plugin-dts: 0.16.11(rolldown@1.0.0-beta.34)(typescript@5.8.3) + rolldown: 1.0.0-beta.38 + rolldown-plugin-dts: 0.16.11(rolldown@1.0.0-beta.38)(typescript@5.8.3) semver: 7.7.2 tinyexec: 1.0.1 tinyglobby: 0.2.15