From 7a57f908a4d9cb2cdd5901d424a2ef3191d4a1a3 Mon Sep 17 00:00:00 2001 From: Palanikannan M Date: Tue, 7 Oct 2025 12:04:28 +0530 Subject: [PATCH] fix: extra line created on enter key --- .../core/extensions/mentions/mentions-list-dropdown.tsx | 6 ++++-- .../src/core/extensions/slash-commands/command-menu.tsx | 7 +++++-- 2 files changed, 9 insertions(+), 4 deletions(-) diff --git a/packages/editor/src/core/extensions/mentions/mentions-list-dropdown.tsx b/packages/editor/src/core/extensions/mentions/mentions-list-dropdown.tsx index 212d849f63a..04257b15d52 100644 --- a/packages/editor/src/core/extensions/mentions/mentions-list-dropdown.tsx +++ b/packages/editor/src/core/extensions/mentions/mentions-list-dropdown.tsx @@ -48,12 +48,12 @@ export const MentionsListDropdown = forwardRef((props: MentionsListDropdownProps useImperativeHandle(ref, () => ({ onKeyDown: ({ event }: { event: KeyboardEvent }) => { - if (!DROPDOWN_NAVIGATION_KEYS.includes(event.key)) return; + if (!DROPDOWN_NAVIGATION_KEYS.includes(event.key)) return false; event.preventDefault(); if (event.key === "Enter") { selectItem(selectedIndex.section, selectedIndex.item); - return; + return true; } const newIndex = getNextValidIndex({ @@ -64,6 +64,8 @@ export const MentionsListDropdown = forwardRef((props: MentionsListDropdownProps if (newIndex) { setSelectedIndex(newIndex); } + + return true; }, })); diff --git a/packages/editor/src/core/extensions/slash-commands/command-menu.tsx b/packages/editor/src/core/extensions/slash-commands/command-menu.tsx index 56ad688bc10..640fb807818 100644 --- a/packages/editor/src/core/extensions/slash-commands/command-menu.tsx +++ b/packages/editor/src/core/extensions/slash-commands/command-menu.tsx @@ -90,12 +90,12 @@ export const SlashCommandsMenu = forwardRef((props: SlashCommandsMenuProps, ref) useImperativeHandle(ref, () => ({ onKeyDown: ({ event }: { event: KeyboardEvent }) => { - if (!DROPDOWN_NAVIGATION_KEYS.includes(event.key)) return; + if (!DROPDOWN_NAVIGATION_KEYS.includes(event.key)) return false; event.preventDefault(); if (event.key === "Enter") { selectItem(selectedIndex.section, selectedIndex.item); - return; + return true; } const newIndex = getNextValidIndex({ @@ -103,9 +103,12 @@ export const SlashCommandsMenu = forwardRef((props: SlashCommandsMenuProps, ref) sections, selectedIndex, }); + if (newIndex) { setSelectedIndex(newIndex); } + + return true; }, }));