From d9dee8038bd9ab8105f2974869a322d2a567384f Mon Sep 17 00:00:00 2001 From: Jayash Tripathy <76092296+JayashTripathy@users.noreply.github.com> Date: Fri, 19 Dec 2025 17:04:38 +0530 Subject: [PATCH 1/2] refactor: update button components and improve styling consistency across various dropdowns and lists --- .../layout/sidebar/property-list-item.tsx | 6 ++--- .../web/core/components/dropdowns/buttons.tsx | 25 ++++++++++------- apps/web/core/components/dropdowns/date.tsx | 4 ++- .../core/components/dropdowns/member/base.tsx | 2 +- .../core/components/dropdowns/priority.tsx | 25 ++++++++++++++--- .../issues/issue-detail/cycle-select.tsx | 4 +-- .../issue-detail/label/label-list-item.tsx | 19 +++---------- .../issues/issue-detail/label/root.tsx | 2 +- .../label/select/label-select.tsx | 17 ++++++------ .../issues/issue-detail/module-select.tsx | 4 +-- .../issues/issue-detail/parent-select.tsx | 6 ++--- .../issues/peek-overview/properties.tsx | 24 ++++++++++------- .../rich-filters/filters-toggle.tsx | 27 ++++++++++++++++--- packages/tailwind-config/variables.css | 24 ++++++++++++++--- 14 files changed, 122 insertions(+), 67 deletions(-) diff --git a/apps/web/core/components/common/layout/sidebar/property-list-item.tsx b/apps/web/core/components/common/layout/sidebar/property-list-item.tsx index 491c74e6c35..5668c7180b0 100644 --- a/apps/web/core/components/common/layout/sidebar/property-list-item.tsx +++ b/apps/web/core/components/common/layout/sidebar/property-list-item.tsx @@ -13,13 +13,13 @@ export function SidebarPropertyListItem(props: TSidebarPropertyListItemProps) { const { icon: Icon, label, children, appendElement, childrenClassName } = props; return ( -
-
+
+
{label} {appendElement}
-
{children}
+
{children}
); } diff --git a/apps/web/core/components/dropdowns/buttons.tsx b/apps/web/core/components/dropdowns/buttons.tsx index 376cab85fd5..217ea52458d 100644 --- a/apps/web/core/components/dropdowns/buttons.tsx +++ b/apps/web/core/components/dropdowns/buttons.tsx @@ -1,5 +1,6 @@ import React from "react"; // helpers +import { Button } from "@plane/propel/button"; import { Tooltip } from "@plane/propel/tooltip"; import { cn } from "@plane/utils"; // types @@ -71,9 +72,11 @@ function BorderButton(props: ButtonProps) { isMobile={isMobile} renderByDefault={renderToolTipByDefault} > -
{children} -
+ ); } @@ -97,14 +100,16 @@ function BackgroundButton(props: ButtonProps) { isMobile={isMobile} renderByDefault={renderToolTipByDefault} > -
{children} -
+ ); } @@ -120,9 +125,11 @@ function TransparentButton(props: ButtonProps) { isMobile={isMobile} renderByDefault={renderToolTipByDefault} > -
{children} -
+ ); } diff --git a/apps/web/core/components/dropdowns/date.tsx b/apps/web/core/components/dropdowns/date.tsx index cb5986d8ecd..8ffdd5cfb71 100644 --- a/apps/web/core/components/dropdowns/date.tsx +++ b/apps/web/core/components/dropdowns/date.tsx @@ -138,7 +138,9 @@ export const DateDropdown = observer(function DateDropdown(props: Props) { > {!hideIcon && icon} {BUTTON_VARIANTS_WITH_TEXT.includes(buttonVariant) && ( - {value ? renderFormattedDate(value, formatToken) : placeholder} + + {value ? renderFormattedDate(value, formatToken) : placeholder} + )} {isClearable && !disabled && isDateSelected && ( {!hideIcon && } {BUTTON_VARIANTS_WITH_TEXT.includes(buttonVariant) && ( - + {getDisplayName(value, showUserDetails, placeholder)} )} diff --git a/apps/web/core/components/dropdowns/priority.tsx b/apps/web/core/components/dropdowns/priority.tsx index 1edc2baad13..0932320c1c1 100644 --- a/apps/web/core/components/dropdowns/priority.tsx +++ b/apps/web/core/components/dropdowns/priority.tsx @@ -120,7 +120,14 @@ function BorderButton(props: ButtonProps) { ))} {!hideText && ( - {priorityDetails?.title ?? placeholder} + + {priorityDetails?.title ?? placeholder} + )} {dropdownArrow && (