From 4d935b9d319782ef0d40c5445c7f692ee43ed783 Mon Sep 17 00:00:00 2001 From: Jason Wray Date: Mon, 13 May 2019 12:54:31 -0700 Subject: [PATCH 1/2] [build, darwin] Update CircleCI to Xcode 10.2.1 --- circle.yml | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/circle.yml b/circle.yml index 3e708292072..c99d5c3e801 100644 --- a/circle.yml +++ b/circle.yml @@ -912,7 +912,7 @@ jobs: # ------------------------------------------------------------------------------ ios-debug: macos: - xcode: "10.2.0" + xcode: "10.2.1" environment: BUILDTYPE: Debug HOMEBREW_NO_AUTO_UPDATE: 1 @@ -952,7 +952,7 @@ jobs: # ------------------------------------------------------------------------------ ios-sanitize-nightly: macos: - xcode: "10.2.0" + xcode: "10.2.1" environment: BUILDTYPE: Debug HOMEBREW_NO_AUTO_UPDATE: 1 @@ -975,7 +975,7 @@ jobs: # ------------------------------------------------------------------------------ ios-sanitize-address-nightly: macos: - xcode: "10.2.0" + xcode: "10.2.1" environment: BUILDTYPE: Debug HOMEBREW_NO_AUTO_UPDATE: 1 @@ -994,7 +994,7 @@ jobs: # ------------------------------------------------------------------------------ ios-static-analyzer-nightly: macos: - xcode: "10.2.0" + xcode: "10.2.1" environment: BUILDTYPE: Debug HOMEBREW_NO_AUTO_UPDATE: 1 @@ -1013,7 +1013,7 @@ jobs: # ------------------------------------------------------------------------------ ios-release-template: macos: - xcode: "10.2.0" + xcode: "10.2.1" environment: BUILDTYPE: Release HOMEBREW_NO_AUTO_UPDATE: 1 @@ -1053,7 +1053,7 @@ jobs: # ------------------------------------------------------------------------------ ios-release-tag: macos: - xcode: "10.2.0" + xcode: "10.2.1" environment: BUILDTYPE: Release HOMEBREW_NO_AUTO_UPDATE: 1 From cd24f4c45f6b38e7f3dc73cf0afda9b86b3d85d4 Mon Sep 17 00:00:00 2001 From: Jason Wray Date: Mon, 13 May 2019 14:40:49 -0700 Subject: [PATCH 2/2] [build, darwin] Fix ENOBUFS in build scripts on NodeJS 12.x --- platform/darwin/scripts/check-public-symbols.js | 2 +- platform/darwin/scripts/update-examples.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/platform/darwin/scripts/check-public-symbols.js b/platform/darwin/scripts/check-public-symbols.js index 4dde5d677b1..a2045f81ec8 100755 --- a/platform/darwin/scripts/check-public-symbols.js +++ b/platform/darwin/scripts/check-public-symbols.js @@ -18,7 +18,7 @@ function hasMissingSymbols(os) { let umbrellaPath = `platform/${os.toLowerCase()}/src/Mapbox.h`; let docArgs = ['doc', '--objc', umbrellaPath, '--', '-x', 'objective-c', '-I', 'platform/darwin/src/', '-isysroot', sysroot]; - let docStr = execFileSync('sourcekitten', docArgs).toString().trim(); + let docStr = execFileSync('sourcekitten', docArgs, { maxBuffer: Infinity }).toString().trim(); let docJson = JSON.parse(docStr); _.forEach(docJson, function (result) { _.forEach(result, function (structure, path) { diff --git a/platform/darwin/scripts/update-examples.js b/platform/darwin/scripts/update-examples.js index f87ed072886..885b26248c1 100755 --- a/platform/darwin/scripts/update-examples.js +++ b/platform/darwin/scripts/update-examples.js @@ -75,7 +75,7 @@ function completeExamples(os) { let umbrellaPath = `platform/${os.toLowerCase()}/src/Mapbox.h`; let docArgs = ['doc', '--objc', umbrellaPath, '--', '-x', 'objective-c', '-I', 'platform/darwin/src/', '-isysroot', sysroot]; - let docStr = execFileSync('sourcekitten', docArgs).toString().trim(); + let docStr = execFileSync('sourcekitten', docArgs, { maxBuffer: Infinity }).toString().trim(); let docJson = JSON.parse(docStr); _.forEach(docJson, function (result) { _.forEach(result, function (structure, path) {