From 61d020093e3f8b7afd21332a9a48e8703f6437bc Mon Sep 17 00:00:00 2001 From: langsmith Date: Tue, 17 Jul 2018 17:13:46 -0700 Subject: [PATCH 1/2] marker doesn't disappear --- .../plugins/places/picker/ui/PlacePickerActivity.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/plugin-places/src/main/java/com/mapbox/mapboxsdk/plugins/places/picker/ui/PlacePickerActivity.java b/plugin-places/src/main/java/com/mapbox/mapboxsdk/plugins/places/picker/ui/PlacePickerActivity.java index 41f6dcb97..a924bf41a 100644 --- a/plugin-places/src/main/java/com/mapbox/mapboxsdk/plugins/places/picker/ui/PlacePickerActivity.java +++ b/plugin-places/src/main/java/com/mapbox/mapboxsdk/plugins/places/picker/ui/PlacePickerActivity.java @@ -132,7 +132,7 @@ public void onMapReady(MapboxMap mapboxMap) { public void onCameraMoveStarted(int reason) { Timber.v("Map camera has begun moving."); if (markerImage.getTranslationY() == 0) { - markerImage.animate().yBy(-75) + markerImage.animate().translationY(-75) .setInterpolator(new OvershootInterpolator()).setDuration(250).start(); if (bottomSheet.isShowing()) { bottomSheet.dismissPlaceDetails(); @@ -143,7 +143,7 @@ public void onCameraMoveStarted(int reason) { @Override public void onCameraIdle() { Timber.v("Map camera is now idling."); - markerImage.animate().yBy(Math.abs(markerImage.getTranslationY())) + markerImage.animate().translationY(Math.abs(mapView.getY() / 2)) .setInterpolator(new OvershootInterpolator()).setDuration(250).start(); bottomSheet.setPlaceDetails(null); makeReverseGeocodingSearch(); From 10f6c2cbc474d7cb011d8395fc448fb3b826344c Mon Sep 17 00:00:00 2001 From: Langston Smith Date: Wed, 18 Jul 2018 07:56:42 -0700 Subject: [PATCH 2/2] switch to 0 --- .../mapboxsdk/plugins/places/picker/ui/PlacePickerActivity.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plugin-places/src/main/java/com/mapbox/mapboxsdk/plugins/places/picker/ui/PlacePickerActivity.java b/plugin-places/src/main/java/com/mapbox/mapboxsdk/plugins/places/picker/ui/PlacePickerActivity.java index a924bf41a..1882fdd9a 100644 --- a/plugin-places/src/main/java/com/mapbox/mapboxsdk/plugins/places/picker/ui/PlacePickerActivity.java +++ b/plugin-places/src/main/java/com/mapbox/mapboxsdk/plugins/places/picker/ui/PlacePickerActivity.java @@ -143,7 +143,7 @@ public void onCameraMoveStarted(int reason) { @Override public void onCameraIdle() { Timber.v("Map camera is now idling."); - markerImage.animate().translationY(Math.abs(mapView.getY() / 2)) + markerImage.animate().translationY(0) .setInterpolator(new OvershootInterpolator()).setDuration(250).start(); bottomSheet.setPlaceDetails(null); makeReverseGeocodingSearch();