diff --git a/README.md b/README.md index a3c6955b..b0c65d24 100644 --- a/README.md +++ b/README.md @@ -7,7 +7,7 @@ Complement is a black box integration testing framework for Matrix homeservers. ## Running -You need to have Go and Docker installed, as well as `libolm3` and `libolm-dev`. Then: +You need to have Go and Docker >= 20.10 installed, as well as `libolm3` and `libolm-dev`. Then: ``` $ COMPLEMENT_BASE_IMAGE=some-matrix/homeserver-impl go test -v ./tests/... diff --git a/internal/docker/deployer.go b/internal/docker/deployer.go index 8582954f..5dc9c9cd 100644 --- a/internal/docker/deployer.go +++ b/internal/docker/deployer.go @@ -177,10 +177,11 @@ func deployImage( var err error if runtime.GOOS == "linux" { - // By default docker for linux does not expose this, so do it now. - // When https://github.com/moby/moby/pull/40007 lands in Docker 20, we should - // change this to be `host.docker.internal:host-gateway` - extraHosts = []string{HostnameRunningComplement + ":172.17.0.1"} + // Ensure that the homeservers under test can contact the host, so they can + // interact with a complement-controlled test server. + // Note: this feature of docker landed in Docker 20.10, + // see https://github.com/moby/moby/pull/40007 + extraHosts = []string{"host.docker.internal:host-gateway"} } for _, m := range cfg.HostMounts {