From a054c469f84a59583116e23d75526d1befcf7f83 Mon Sep 17 00:00:00 2001 From: Kerry Archibald Date: Wed, 10 May 2023 14:50:48 +1200 Subject: [PATCH 1/5] hide timestamp --- cypress/e2e/permalinks/permalinks.spec.ts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/cypress/e2e/permalinks/permalinks.spec.ts b/cypress/e2e/permalinks/permalinks.spec.ts index 29795631740..73428873b63 100644 --- a/cypress/e2e/permalinks/permalinks.spec.ts +++ b/cypress/e2e/permalinks/permalinks.spec.ts @@ -131,6 +131,7 @@ describe("permalinks", () => { cy.get(".mx_NewRoomIntro").invoke("remove"); cy.get(".mx_GenericEventListSummary").invoke("remove"); - cy.get(".mx_RoomView_timeline").percySnapshotElement("Permalink rendering"); + const percyCSS = ".mx_MessageTimestamp, .mx_RoomView_myReadMarker { visibility: hidden !important; }"; + cy.get(".mx_RoomView_timeline").percySnapshotElement("Permalink rendering", { percyCSS }); }); }); From 58b8dbcf6edda14bd042c58d4f83e696913a68c3 Mon Sep 17 00:00:00 2001 From: Kerry Archibald Date: Thu, 11 May 2023 12:40:16 +1200 Subject: [PATCH 2/5] retrigger sonar From e91327aa8c9569dbe1f42e9dc374982c8c07a386 Mon Sep 17 00:00:00 2001 From: Kerry Archibald Date: Fri, 12 May 2023 10:52:18 +1200 Subject: [PATCH 3/5] trigger build From 3bfc61907a4fcf16d73332aa60a9a4d874310078 Mon Sep 17 00:00:00 2001 From: Kerry Archibald Date: Fri, 12 May 2023 13:34:41 +1200 Subject: [PATCH 4/5] hide elements instead of removing them which might effect scroll --- cypress/e2e/permalinks/permalinks.spec.ts | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/cypress/e2e/permalinks/permalinks.spec.ts b/cypress/e2e/permalinks/permalinks.spec.ts index 29795631740..af5e39687c9 100644 --- a/cypress/e2e/permalinks/permalinks.spec.ts +++ b/cypress/e2e/permalinks/permalinks.spec.ts @@ -126,11 +126,12 @@ describe("permalinks", () => { getPill(danielle.getSafeUserId()); }); - // clean up before taking the snapshot - cy.get(".mx_cryptoEvent").invoke("remove"); - cy.get(".mx_NewRoomIntro").invoke("remove"); - cy.get(".mx_GenericEventListSummary").invoke("remove"); + // Exclude various components from the snapshot, for consistency + const percyCSS = + ".mx_cryptoEvent, " + + ".mx_NewRoomIntro, " + + ".mx_GenericEventListSummary { visibility: hidden !important; }"; - cy.get(".mx_RoomView_timeline").percySnapshotElement("Permalink rendering"); + cy.get(".mx_RoomView_timeline").percySnapshotElement("Permalink rendering", { percyCSS }); }); }); From 6df4d0f8da96f8ddd8f1159d982b4fca0366bc06 Mon Sep 17 00:00:00 2001 From: Kerry Archibald Date: Fri, 12 May 2023 14:53:02 +1200 Subject: [PATCH 5/5] lint --- cypress/e2e/permalinks/permalinks.spec.ts | 1 - 1 file changed, 1 deletion(-) diff --git a/cypress/e2e/permalinks/permalinks.spec.ts b/cypress/e2e/permalinks/permalinks.spec.ts index 7b871cf5dba..2a61df26a09 100644 --- a/cypress/e2e/permalinks/permalinks.spec.ts +++ b/cypress/e2e/permalinks/permalinks.spec.ts @@ -126,7 +126,6 @@ describe("permalinks", () => { getPill(danielle.getSafeUserId()); }); - // Exclude various components from the snapshot, for consistency const percyCSS = ".mx_cryptoEvent, " +