From d81469717512f55a04e6f76ea9e9b5683b7c43ff Mon Sep 17 00:00:00 2001 From: David Baker Date: Tue, 15 Mar 2022 11:19:36 +0000 Subject: [PATCH 1/2] Fix freeze/crash when 1:1 calling Don't log call feed objects because they reference the client and it causes the client to get logged too. --- src/components/views/voip/AudioFeed.tsx | 2 +- src/components/views/voip/VideoFeed.tsx | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/components/views/voip/AudioFeed.tsx b/src/components/views/voip/AudioFeed.tsx index 944ea3ad000..29371aafe98 100644 --- a/src/components/views/voip/AudioFeed.tsx +++ b/src/components/views/voip/AudioFeed.tsx @@ -93,7 +93,7 @@ export default class AudioFeed extends React.Component { // load() explicitly, it shouldn't be a problem. - Dave await element.load(); } catch (e) { - logger.info("Failed to play media element with feed", this.props.feed, e); + logger.info("Failed to play media element with feed for userId", this.props.feed.userId, e); } } diff --git a/src/components/views/voip/VideoFeed.tsx b/src/components/views/voip/VideoFeed.tsx index 532a8632722..604394d19cb 100644 --- a/src/components/views/voip/VideoFeed.tsx +++ b/src/components/views/voip/VideoFeed.tsx @@ -138,7 +138,7 @@ export default class VideoFeed extends React.PureComponent { // load() explicitly, it shouldn't be a problem. - Dave await element.play(); } catch (e) { - logger.info("Failed to play media element with feed", this.props.feed, e); + logger.info("Failed to play media element with feed for userID", this.props.feed.userId, e); } } From e4a6b3d270c2bd23c7a2b07cea4276063fdffe19 Mon Sep 17 00:00:00 2001 From: David Baker Date: Tue, 15 Mar 2022 11:31:25 +0000 Subject: [PATCH 2/2] Log purpose too --- src/components/views/voip/AudioFeed.tsx | 5 ++++- src/components/views/voip/VideoFeed.tsx | 5 ++++- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/src/components/views/voip/AudioFeed.tsx b/src/components/views/voip/AudioFeed.tsx index 29371aafe98..64a33a69268 100644 --- a/src/components/views/voip/AudioFeed.tsx +++ b/src/components/views/voip/AudioFeed.tsx @@ -93,7 +93,10 @@ export default class AudioFeed extends React.Component { // load() explicitly, it shouldn't be a problem. - Dave await element.load(); } catch (e) { - logger.info("Failed to play media element with feed for userId", this.props.feed.userId, e); + logger.info( + `Failed to play media element with feed for userId ` + + `${this.props.feed.userId} with purpose ${this.props.feed.purpose}`, e, + ); } } diff --git a/src/components/views/voip/VideoFeed.tsx b/src/components/views/voip/VideoFeed.tsx index 604394d19cb..72eb9184656 100644 --- a/src/components/views/voip/VideoFeed.tsx +++ b/src/components/views/voip/VideoFeed.tsx @@ -138,7 +138,10 @@ export default class VideoFeed extends React.PureComponent { // load() explicitly, it shouldn't be a problem. - Dave await element.play(); } catch (e) { - logger.info("Failed to play media element with feed for userID", this.props.feed.userId, e); + logger.info( + `Failed to play media element with feed for userId ` + + `${this.props.feed.userId} with purpose ${this.props.feed.purpose}`, e, + ); } }