From 02d60ab4f4eab9f032f60f32ce80f1b67f0c9190 Mon Sep 17 00:00:00 2001 From: ESHA GOEL Date: Thu, 31 Mar 2022 18:20:24 +0530 Subject: [PATCH 1/4] added min-height for event line --- res/css/views/rooms/_EventTile.scss | 1 + 1 file changed, 1 insertion(+) diff --git a/res/css/views/rooms/_EventTile.scss b/res/css/views/rooms/_EventTile.scss index 310465837bd..11b1a68393b 100644 --- a/res/css/views/rooms/_EventTile.scss +++ b/res/css/views/rooms/_EventTile.scss @@ -311,6 +311,7 @@ $left-gutter: 64px; .mx_EventTile_line { /* ideally should be 100px, but 95px gives us a max thumbnail size of 800x600, which is nice */ margin-right: 110px; + min-height: 2.2rem; } } // on ELS we need the margin to allow interaction with the expand/collapse button which is normally in the RR gutter From 4b74e00cb261c10dbb8ba6b9605a7250958f29a0 Mon Sep 17 00:00:00 2001 From: ESHA GOEL Date: Mon, 4 Apr 2022 13:06:45 +0530 Subject: [PATCH 2/4] Requested changes done --- res/css/views/rooms/_EventTile.scss | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/res/css/views/rooms/_EventTile.scss b/res/css/views/rooms/_EventTile.scss index 11b1a68393b..a25351e2bac 100644 --- a/res/css/views/rooms/_EventTile.scss +++ b/res/css/views/rooms/_EventTile.scss @@ -311,7 +311,7 @@ $left-gutter: 64px; .mx_EventTile_line { /* ideally should be 100px, but 95px gives us a max thumbnail size of 800x600, which is nice */ margin-right: 110px; - min-height: 2.2rem; + min-height: $font-14px; } } // on ELS we need the margin to allow interaction with the expand/collapse button which is normally in the RR gutter @@ -626,10 +626,11 @@ $left-gutter: 64px; } .mx_EventTile_keyRequestInfo_text .mx_AccessibleButton { - @mixin ButtonResetDefault; + @mixin ButtonResetDefault{ color: $primary-content; text-decoration: underline; cursor: pointer; + } } .mx_EventTile_keyRequestInfo_tooltip_contents p { From 039fd32b21c9bcc2dc9dcb774ecf798cd3c4538c Mon Sep 17 00:00:00 2001 From: ESHA GOEL Date: Mon, 4 Apr 2022 13:12:05 +0530 Subject: [PATCH 3/4] Changes done --- res/css/views/rooms/_EventTile.scss | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/res/css/views/rooms/_EventTile.scss b/res/css/views/rooms/_EventTile.scss index a25351e2bac..0f87dd69495 100644 --- a/res/css/views/rooms/_EventTile.scss +++ b/res/css/views/rooms/_EventTile.scss @@ -626,11 +626,10 @@ $left-gutter: 64px; } .mx_EventTile_keyRequestInfo_text .mx_AccessibleButton { - @mixin ButtonResetDefault{ + @mixin ButtonResetDefault; color: $primary-content; text-decoration: underline; cursor: pointer; - } } .mx_EventTile_keyRequestInfo_tooltip_contents p { From a1715ba292a1c8bd530ede3c8625bce1303d373c Mon Sep 17 00:00:00 2001 From: ESHA GOEL Date: Mon, 11 Apr 2022 16:47:38 +0530 Subject: [PATCH 4/4] fixing failing tests