From 7286c017ed51f841e75236e51290cfa62dc6f65d Mon Sep 17 00:00:00 2001 From: Eric Eastwood Date: Fri, 16 Jul 2021 17:47:25 -0500 Subject: [PATCH 1/3] Remove unused events_by_room It looks like it was first used and introduced in https://github.com/matrix-org/synapse/commit/5130d80d79fe1f95ce03b8f1cfd4fbf0a32f5ac8#diff-8a4a36a7728107b2ccaff2cb405dbab229a1100fe50653a63d1aa9ac10ae45e8R305 but the But the usage was removed in https://github.com/matrix-org/synapse/commit/4c6a31cd6efa25be4c9f1b357e8f92065fac63eb#diff-8a4a36a7728107b2ccaff2cb405dbab229a1100fe50653a63d1aa9ac10ae45e8 --- synapse/storage/databases/main/events.py | 4 ---- 1 file changed, 4 deletions(-) diff --git a/synapse/storage/databases/main/events.py b/synapse/storage/databases/main/events.py index ec8579b9ad98..a396a201d4fc 100644 --- a/synapse/storage/databases/main/events.py +++ b/synapse/storage/databases/main/events.py @@ -2010,10 +2010,6 @@ def _update_backward_extremeties(self, txn, events): Forward extremities are handled when we first start persisting the events. """ - events_by_room: Dict[str, List[EventBase]] = {} - for ev in events: - events_by_room.setdefault(ev.room_id, []).append(ev) - query = ( "INSERT INTO event_backward_extremities (event_id, room_id)" " SELECT ?, ? WHERE NOT EXISTS (" From 398664d7af99ba0b3cc83dcfa363188630a499e8 Mon Sep 17 00:00:00 2001 From: Eric Eastwood Date: Fri, 16 Jul 2021 17:49:47 -0500 Subject: [PATCH 2/3] Create 10421.misc --- 10421.misc | 1 + 1 file changed, 1 insertion(+) create mode 100644 10421.misc diff --git a/10421.misc b/10421.misc new file mode 100644 index 000000000000..385cbe07af83 --- /dev/null +++ b/10421.misc @@ -0,0 +1 @@ +Remove unused `events_by_room` code (tech debt). From 01e14ccd66103b3675c3fc95fd9076d00f1ac313 Mon Sep 17 00:00:00 2001 From: Eric Eastwood Date: Fri, 16 Jul 2021 17:51:37 -0500 Subject: [PATCH 3/3] Rename 10421.misc to changelog.d/10421.misc --- 10421.misc => changelog.d/10421.misc | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename 10421.misc => changelog.d/10421.misc (100%) diff --git a/10421.misc b/changelog.d/10421.misc similarity index 100% rename from 10421.misc rename to changelog.d/10421.misc