fix(cdk): self-guard resource names to prevent multi-stack collisions#2
Open
mayakost wants to merge 1 commit into
Open
Conversation
- Runtime: `jean_cloude_${stackName}` sanitized + `.slice(0, 48)`
- Guardrail: `task-input-guardrail-${stackName}` + `.slice(0, 50)`
- Memory: `bgagent_memory_${stackName}` sanitized + `.slice(0, 48)`
- Model Invocation Logging: remove onDelete (account-level singleton)
- Gitleaks: add allowlist for test fixture Slack signing secrets
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Task-Id: 01KREP0XGEN0BN1QPA82JD1P5Q
Prompt-Version: 1c9c10e027a2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Port of aws-samples#70.
Fixes multi-stack name collisions by making each resource self-guard its own name length, rather than imposing a central `stackName` length limit.
Closes #1.
Build and test results
`mise //cdk:compile` ✅ — TypeScript compilation passes
`mise //cdk:test` (agent stack + agent-memory suites directly) ✅ — 45/45 tests pass
Full `mise //cdk:test` — 1169/1170 tests pass; 1 pre-existing failure:
Initial `mise run build` was already failing before this PR (Python `botocore` type-check errors in `agent/`)
Decisions made
Agent notes
What went well
What was difficult
Patterns discovered
Suggestions for future tasks
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the project license.