From c080375618eab75d7996f795c3699c881c3b3471 Mon Sep 17 00:00:00 2001 From: Joyce Quach Date: Thu, 14 Dec 2023 14:04:05 -0500 Subject: [PATCH 1/8] Prettier and fix typo in README --- README.md | 92 ++++++++++++++++++++++++++++++------------------------- 1 file changed, 51 insertions(+), 41 deletions(-) diff --git a/README.md b/README.md index 830d0c66..f4a077d8 100644 --- a/README.md +++ b/README.md @@ -1,57 +1,67 @@ # Request Generator -This subproject provides a small web application that is capable of generating requests and displaying the CDS Hooks cards that are provided as a response. This project is written in JavaScript and runs in [node.js](https://nodejs.org/en/). + +This subproject provides a small web application that is capable of generating requests and displaying the CDS Hooks cards that are provided as a response. This project is written in JavaScript and runs in [node.js](https://nodejs.org/en/). ## Running the request generator standalone + 1. Install node.js 2. Clone the repository - * `git clone https://github.com/mcode/request-generator.git` + +- `git clone https://github.com/mcode/request-generator.git` + 3. Install the dependencies - * `cd request-generator` - * `npm install` + +- `cd request-generator` +- `npm install` + 4. Run the application - * `npm start` + +- `npm start` This should open a browser window directed to the value set in `REACT_APP_URL`. The request-generator assumes the CRD server is running on the default value set for `REACT_APP_SERVER`. This can be changed in the properties file [.env](./.env). [The following section](./README.md#how-to-override-defaults) lists the default values for these environment variables. ## Versions + This application requires node v14. -## Keys -Embedded in the application are the public and provate keys used to generate and verify JSON Web Tokens (JWT) that are used to authenticate/authorize calls to a CDS-Hooks service. The public key is contained in the public/.well-known/jwks.json document. The private key is contained in src/keys/crdPrivateKey.js file. The keys were generated from https://mkjwk.org/. To update these keys you can generate a new key pair from this site, ensure that you request the Show X.509 option is set to yes. Once generated you can replace the public and private keys. You will also need to update the src/utils/auth.js file with the corrisponding key information. +## Keys + +Embedded in the application are the public and private keys used to generate and verify JSON Web Tokens (JWT) that are used to authenticate/authorize calls to a CDS-Hooks service. The public key is contained in the public/.well-known/jwks.json document. The private key is contained in src/keys/crdPrivateKey.js file. The keys were generated from https://mkjwk.org/. To update these keys you can generate a new key pair from this site, ensure that you request the Show X.509 option is set to yes. Once generated you can replace the public and private keys. You will also need to update the src/utils/auth.js file with the corresponding key information. ### How To Override Defaults + The .env file contains the default URI paths, these can be overwritten from the start command as follows: - `REACT_APP_LAUNCH_URL=http://example.com PORT=6000 npm start` - -Following are a list of modifiable paths: - -| URI Name | Default | -| -----------------------|---------------------------------------------------------------------------| -| REACT_APP_AUTH | `http://localhost:8180` | -| REACT_APP_EHR_SERVER | `http://localhost:8080/test-ehr/r4` | -| REACT_APP_CDS_SERVICE | `http://localhost:8090/cds-services` | -| REACT_APP_PUBLIC_KEYS | `http://localhost:3001/public_keys` | -| REACT_APP_LAUNCH_URL | `http://localhost:4040/launch` | -| REACT_APP_PIMS_SERVER | `http://localhost:5051/doctorOrders/api/addRx` | -| REACT_APP_REALM | `ClientFhirServer` | -| REACT_APP_CLIENT | `app-login` | -| REACT_APP_SERVER | `http://localhost:8090` | -| REACT_APP_EHR_BASE | `http://localhost:8080/test-ehr/r4` | -| REACT_APP_EHR_SERVER_TO_BE_SENT_TO_REMS_ADMIN_FOR_PREFETCH | `http://localhost:8080/test-ehr/r4` | -| REACT_APP_ORDER_SIGN | `rems-order-sign` | -| REACT_APP_ORDER_SELECT | `rems-order-select` | -| REACT_APP_PATIENT_VIEW | `rems-patient-view` | -| REACT_APP_USER | `alice` | -| REACT_APP_PASSWORD | `alice` | -| REACT_APP_ALT_DRUG | `true` | -| REACT_APP_SMART_LAUNCH_URL | `http://localhost:4040/` | -| REACT_APP_DEFAULT_USER | `pra1234` | -| REACT_APP_RESPONSE_EXPIRATION_DAYS | `30` | -| REACT_APP_HOMEPAGE | `http://localhost:8080` | -| REACT_APP_URL | `http://localhost:3000` | -| REACT_APP_URL_FILTER | `http://localhost:3000/*` | -| REACT_APP_EHR_LINK | `http://localhost:8080/ehr-server/` | -| HTTPS | `false` | -| HTTPS_KEY_PATH | `server.key` | -| HTTPS_CERT_PATH | `server.cert` | -| REACT_APP_PATIENT_FHIR_QUERY | `Patient?_sort=identifier&_count=12` | +`REACT_APP_LAUNCH_URL=http://example.com PORT=6000 npm start` + +Following are a list of modifiable paths: + +| URI Name | Default | +| ---------------------------------------------------------- | --------------------------------------------------------------- | +| REACT_APP_AUTH | `http://localhost:8180` | +| REACT_APP_EHR_SERVER | `http://localhost:8080/test-ehr/r4` | +| REACT_APP_CDS_SERVICE | `http://localhost:8090/cds-services` | +| REACT_APP_PUBLIC_KEYS | `http://localhost:3000/request-generator/.well-known/jwks.json` | +| REACT_APP_LAUNCH_URL | `http://localhost:4040/launch` | +| REACT_APP_PIMS_SERVER | `http://localhost:5051/doctorOrders/api/addRx` | +| REACT_APP_REALM | `ClientFhirServer` | +| REACT_APP_CLIENT | `app-login` | +| REACT_APP_SERVER | `http://localhost:8090` | +| REACT_APP_EHR_BASE | `http://localhost:8080/test-ehr/r4` | +| REACT_APP_EHR_SERVER_TO_BE_SENT_TO_REMS_ADMIN_FOR_PREFETCH | `http://localhost:8080/test-ehr/r4` | +| REACT_APP_ORDER_SIGN | `rems-order-sign` | +| REACT_APP_ORDER_SELECT | `rems-order-select` | +| REACT_APP_PATIENT_VIEW | `rems-patient-view` | +| REACT_APP_USER | `alice` | +| REACT_APP_PASSWORD | `alice` | +| REACT_APP_ALT_DRUG | `true` | +| REACT_APP_SMART_LAUNCH_URL | `http://localhost:4040/` | +| REACT_APP_DEFAULT_USER | `pra1234` | +| REACT_APP_RESPONSE_EXPIRATION_DAYS | `30` | +| REACT_APP_HOMEPAGE | `http://localhost:8080` | +| REACT_APP_URL | `http://localhost:3000` | +| REACT_APP_URL_FILTER | `http://localhost:3000/*` | +| REACT_APP_EHR_LINK | `http://localhost:8080/ehr-server/` | +| HTTPS | `false` | +| HTTPS_KEY_PATH | `server.key` | +| HTTPS_CERT_PATH | `server.cert` | +| REACT_APP_PATIENT_FHIR_QUERY | `Patient?_sort=identifier&_count=12` | From a980cd9684aa46864e44f813d29e1cfe4c440356 Mon Sep 17 00:00:00 2001 From: Joyce Quach Date: Tue, 2 Jan 2024 17:13:50 -0500 Subject: [PATCH 2/8] Alphabetize environment variables --- .env | 45 ++++++++++++++++++++------------------------- README.md | 38 +++++++++++++++++++------------------- 2 files changed, 39 insertions(+), 44 deletions(-) diff --git a/.env b/.env index 661d24f2..380805a7 100644 --- a/.env +++ b/.env @@ -1,36 +1,31 @@ -# Development URLS - -REACT_APP_REALM = ClientFhirServer +HTTPS = false +HTTPS_CERT_PATH = server.cert +HTTPS_KEY_PATH = server.key +REACT_APP_ALT_DRUG = true +REACT_APP_AUTH = http://localhost:8180 +REACT_APP_CDS_SERVICE = http://localhost:8090/cds-services REACT_APP_CLIENT = app-login REACT_APP_CLIENT_SCOPES = launch offline_access openid profile user/Patient.read patient/Patient.read user/Practitioner.read -REACT_APP_AUTH = http://localhost:8180 -REACT_APP_SERVER = http://localhost:8090 +REACT_APP_DEFAULT_USER = pra1234 +REACT_APP_EHR_BASE = http://localhost:8080/test-ehr/r4 +REACT_APP_EHR_LINK = http://localhost:8080/ehr-server/ REACT_APP_EHR_SERVER = http://localhost:8080/test-ehr/r4 REACT_APP_EHR_SERVER_TO_BE_SENT_TO_REMS_ADMIN_FOR_PREFETCH = http://localhost:8080/test-ehr/r4 -REACT_APP_EHR_BASE = http://localhost:8080/test-ehr/r4 -REACT_APP_CDS_SERVICE = http://localhost:8090/cds-services REACT_APP_GENERATE_JWT = true -REACT_APP_ORDER_SIGN = rems-order-sign +REACT_APP_GH_PAGES=false +REACT_APP_HOMEPAGE = http://localhost:8080 +REACT_APP_LAUNCH_URL = http://localhost:4040/launch REACT_APP_ORDER_SELECT = rems-order-select -REACT_APP_PATIENT_VIEW = rems-patient-view -REACT_APP_PATIENT_FHIR_QUERY = Patient?_sort=identifier&_count=12 -REACT_APP_USER = alice +REACT_APP_ORDER_SIGN = rems-order-sign REACT_APP_PASSWORD = alice +REACT_APP_PATIENT_FHIR_QUERY = Patient?_sort=identifier&_count=12 +REACT_APP_PATIENT_VIEW = rems-patient-view +REACT_APP_PIMS_SERVER = http://localhost:5051/doctorOrders/api/addRx REACT_APP_PUBLIC_KEYS = http://localhost:3000/request-generator/.well-known/jwks.json -REACT_APP_ALT_DRUG = true -REACT_APP_LAUNCH_URL = http://localhost:4040/launch -REACT_APP_SMART_LAUNCH_URL = http://localhost:4040/ -REACT_APP_DEFAULT_USER = pra1234 +REACT_APP_REALM = ClientFhirServer REACT_APP_RESPONSE_EXPIRATION_DAYS = 30 -REACT_APP_PIMS_SERVER = http://localhost:5051/doctorOrders/api/addRx -REACT_APP_HOMEPAGE = http://localhost:8080 +REACT_APP_SERVER = http://localhost:8090 +REACT_APP_SMART_LAUNCH_URL = http://localhost:4040/ REACT_APP_URL = http://localhost:3000 REACT_APP_URL_FILTER = http://localhost:3000/* -REACT_APP_EHR_LINK = http://localhost:8080/ehr-server/ -HTTPS = false -HTTPS_KEY_PATH = server.key -HTTPS_CERT_PATH = server.cert -REACT_APP_GH_PAGES=false -# To Override start command: -# REACT_APP_AUTH=http://example.com PORT=6000 npm start -# Note that .env values can only be accessed by react app starting with 'REACT_APP_' +REACT_APP_USER = alice \ No newline at end of file diff --git a/README.md b/README.md index f4a077d8..dd3dc70a 100644 --- a/README.md +++ b/README.md @@ -31,37 +31,37 @@ Embedded in the application are the public and private keys used to generate and ### How To Override Defaults The .env file contains the default URI paths, these can be overwritten from the start command as follows: -`REACT_APP_LAUNCH_URL=http://example.com PORT=6000 npm start` +`REACT_APP_LAUNCH_URL=http://example.com PORT=6000 npm start` or by specifying the environment variables and desired values in a `.env.local`. Following are a list of modifiable paths: | URI Name | Default | | ---------------------------------------------------------- | --------------------------------------------------------------- | +| HTTPS | `false` | +| HTTPS_CERT_PATH | `server.cert` | +| HTTPS_KEY_PATH | `server.key` | +| REACT_APP_ALT_DRUG | `true` | | REACT_APP_AUTH | `http://localhost:8180` | -| REACT_APP_EHR_SERVER | `http://localhost:8080/test-ehr/r4` | | REACT_APP_CDS_SERVICE | `http://localhost:8090/cds-services` | -| REACT_APP_PUBLIC_KEYS | `http://localhost:3000/request-generator/.well-known/jwks.json` | -| REACT_APP_LAUNCH_URL | `http://localhost:4040/launch` | -| REACT_APP_PIMS_SERVER | `http://localhost:5051/doctorOrders/api/addRx` | -| REACT_APP_REALM | `ClientFhirServer` | | REACT_APP_CLIENT | `app-login` | -| REACT_APP_SERVER | `http://localhost:8090` | +| REACT_APP_DEFAULT_USER | `pra1234` | | REACT_APP_EHR_BASE | `http://localhost:8080/test-ehr/r4` | +| REACT_APP_EHR_LINK | `http://localhost:8080/ehr-server/` | +| REACT_APP_EHR_SERVER | `http://localhost:8080/test-ehr/r4` | | REACT_APP_EHR_SERVER_TO_BE_SENT_TO_REMS_ADMIN_FOR_PREFETCH | `http://localhost:8080/test-ehr/r4` | -| REACT_APP_ORDER_SIGN | `rems-order-sign` | +| REACT_APP_HOMEPAGE | `http://localhost:8080` | +| REACT_APP_LAUNCH_URL | `http://localhost:4040/launch` | | REACT_APP_ORDER_SELECT | `rems-order-select` | -| REACT_APP_PATIENT_VIEW | `rems-patient-view` | -| REACT_APP_USER | `alice` | +| REACT_APP_ORDER_SIGN | `rems-order-sign` | | REACT_APP_PASSWORD | `alice` | -| REACT_APP_ALT_DRUG | `true` | -| REACT_APP_SMART_LAUNCH_URL | `http://localhost:4040/` | -| REACT_APP_DEFAULT_USER | `pra1234` | +| REACT_APP_PATIENT_FHIR_QUERY | `Patient?_sort=identifier&_count=12` | +| REACT_APP_PATIENT_VIEW | `rems-patient-view` | +| REACT_APP_PIMS_SERVER | `http://localhost:5051/doctorOrders/api/addRx` | +| REACT_APP_PUBLIC_KEYS | `http://localhost:3000/request-generator/.well-known/jwks.json` | +| REACT_APP_REALM | `ClientFhirServer` | | REACT_APP_RESPONSE_EXPIRATION_DAYS | `30` | -| REACT_APP_HOMEPAGE | `http://localhost:8080` | +| REACT_APP_SERVER | `http://localhost:8090` | +| REACT_APP_SMART_LAUNCH_URL | `http://localhost:4040/` | | REACT_APP_URL | `http://localhost:3000` | | REACT_APP_URL_FILTER | `http://localhost:3000/*` | -| REACT_APP_EHR_LINK | `http://localhost:8080/ehr-server/` | -| HTTPS | `false` | -| HTTPS_KEY_PATH | `server.key` | -| HTTPS_CERT_PATH | `server.cert` | -| REACT_APP_PATIENT_FHIR_QUERY | `Patient?_sort=identifier&_count=12` | +| REACT_APP_USER | `alice` | From f9137901c8c16946021005bbba18e17c1a111fce Mon Sep 17 00:00:00 2001 From: Joyce Quach Date: Thu, 14 Dec 2023 14:25:57 -0500 Subject: [PATCH 3/8] Document new environment variables --- README.md | 63 +++++++++++++++++++++++++++++-------------------------- 1 file changed, 33 insertions(+), 30 deletions(-) diff --git a/README.md b/README.md index dd3dc70a..3ba75f6f 100644 --- a/README.md +++ b/README.md @@ -35,33 +35,36 @@ The .env file contains the default URI paths, these can be overwritten from the Following are a list of modifiable paths: -| URI Name | Default | -| ---------------------------------------------------------- | --------------------------------------------------------------- | -| HTTPS | `false` | -| HTTPS_CERT_PATH | `server.cert` | -| HTTPS_KEY_PATH | `server.key` | -| REACT_APP_ALT_DRUG | `true` | -| REACT_APP_AUTH | `http://localhost:8180` | -| REACT_APP_CDS_SERVICE | `http://localhost:8090/cds-services` | -| REACT_APP_CLIENT | `app-login` | -| REACT_APP_DEFAULT_USER | `pra1234` | -| REACT_APP_EHR_BASE | `http://localhost:8080/test-ehr/r4` | -| REACT_APP_EHR_LINK | `http://localhost:8080/ehr-server/` | -| REACT_APP_EHR_SERVER | `http://localhost:8080/test-ehr/r4` | -| REACT_APP_EHR_SERVER_TO_BE_SENT_TO_REMS_ADMIN_FOR_PREFETCH | `http://localhost:8080/test-ehr/r4` | -| REACT_APP_HOMEPAGE | `http://localhost:8080` | -| REACT_APP_LAUNCH_URL | `http://localhost:4040/launch` | -| REACT_APP_ORDER_SELECT | `rems-order-select` | -| REACT_APP_ORDER_SIGN | `rems-order-sign` | -| REACT_APP_PASSWORD | `alice` | -| REACT_APP_PATIENT_FHIR_QUERY | `Patient?_sort=identifier&_count=12` | -| REACT_APP_PATIENT_VIEW | `rems-patient-view` | -| REACT_APP_PIMS_SERVER | `http://localhost:5051/doctorOrders/api/addRx` | -| REACT_APP_PUBLIC_KEYS | `http://localhost:3000/request-generator/.well-known/jwks.json` | -| REACT_APP_REALM | `ClientFhirServer` | -| REACT_APP_RESPONSE_EXPIRATION_DAYS | `30` | -| REACT_APP_SERVER | `http://localhost:8090` | -| REACT_APP_SMART_LAUNCH_URL | `http://localhost:4040/` | -| REACT_APP_URL | `http://localhost:3000` | -| REACT_APP_URL_FILTER | `http://localhost:3000/*` | -| REACT_APP_USER | `alice` | +| URI Name | Default | +| ---------------------------------------------------------- | ---------------------------------------------------------------------------------------------------- | +| HTTPS | `false` | +| HTTPS_CERT_PATH | `server.cert` | +| HTTPS_KEY_PATH | `server.key` | +| REACT_APP_ALT_DRUG | `true` | +| REACT_APP_AUTH | `http://localhost:8180` | +| REACT_APP_CDS_SERVICE | `http://localhost:8090/cds-services` | +| REACT_APP_CLIENT | `app-login` | +| REACT_APP_CLIENT_SCOPES | `launch offline_access openid profile user/Patient.read patient/Patient.read user/Practitioner.read` | +| REACT_APP_DEFAULT_USER | `pra1234` | +| REACT_APP_EHR_BASE | `http://localhost:8080/test-ehr/r4` | +| REACT_APP_EHR_LINK | `http://localhost:8080/ehr-server/` | +| REACT_APP_EHR_SERVER | `http://localhost:8080/test-ehr/r4` | +| REACT_APP_EHR_SERVER_TO_BE_SENT_TO_REMS_ADMIN_FOR_PREFETCH | `http://localhost:8080/test-ehr/r4` | +| REACT_APP_GENERATE_JWT | `true` | +| REACT_APP_GH_PAGES | `false` | +| REACT_APP_HOMEPAGE | `http://localhost:8080` | +| REACT_APP_LAUNCH_URL | `http://localhost:4040/launch` | +| REACT_APP_ORDER_SELECT | `rems-order-select` | +| REACT_APP_ORDER_SIGN | `rems-order-sign` | +| REACT_APP_PASSWORD | `alice` | +| REACT_APP_PATIENT_FHIR_QUERY | `Patient?_sort=identifier&_count=12` | +| REACT_APP_PATIENT_VIEW | `rems-patient-view` | +| REACT_APP_PIMS_SERVER | `http://localhost:5051/doctorOrders/api/addRx` | +| REACT_APP_PUBLIC_KEYS | `http://localhost:3000/request-generator/.well-known/jwks.json` | +| REACT_APP_REALM | `ClientFhirServer` | +| REACT_APP_RESPONSE_EXPIRATION_DAYS | `30` | +| REACT_APP_SERVER | `http://localhost:8090` | +| REACT_APP_SMART_LAUNCH_URL | `http://localhost:4040/` | +| REACT_APP_URL | `http://localhost:3000` | +| REACT_APP_URL_FILTER | `http://localhost:3000/*` | +| REACT_APP_USER | `alice` | From b5fae55479e8cd8e3fb2fc970ba7e82e07761af8 Mon Sep 17 00:00:00 2001 From: Joyce Quach Date: Wed, 20 Dec 2023 16:07:55 -0500 Subject: [PATCH 4/8] Add new section to README.md --- README.md | 49 ++++++++++++++++++++++++++++++++++++++++++------- 1 file changed, 42 insertions(+), 7 deletions(-) diff --git a/README.md b/README.md index 3ba75f6f..c7d8004c 100644 --- a/README.md +++ b/README.md @@ -1,10 +1,14 @@ # Request Generator -This subproject provides a small web application that is capable of generating requests and displaying the CDS Hooks cards that are provided as a response. This project is written in JavaScript and runs in [node.js](https://nodejs.org/en/). +This project provides a small web application that is capable of generating requests and displaying the CDS Hooks cards that are provided as a response. This project is written in JavaScript and runs in [node.js](https://nodejs.org/en/). ## Running the request generator standalone -1. Install node.js +1. Install node.js v14 (using [`nvm`](https://github.com/nvm-sh/nvm) is optional, but easier) + +- `nvm install 14` +- `nvm use 14` + 2. Clone the repository - `git clone https://github.com/mcode/request-generator.git` @@ -18,11 +22,7 @@ This subproject provides a small web application that is capable of generating r - `npm start` -This should open a browser window directed to the value set in `REACT_APP_URL`. The request-generator assumes the CRD server is running on the default value set for `REACT_APP_SERVER`. This can be changed in the properties file [.env](./.env). [The following section](./README.md#how-to-override-defaults) lists the default values for these environment variables. - -## Versions - -This application requires node v14. +This should open a browser window directed to the value set in `REACT_APP_URL` followed by the string `/request-generator`. The request-generator assumes the REMS Admin is running on the default value set for `REACT_APP_SERVER`. This can be changed in the properties file [.env](./.env). [The following section](./README.md#how-to-override-defaults) lists the default values for these environment variables. ## Keys @@ -68,3 +68,38 @@ Following are a list of modifiable paths: | REACT_APP_URL | `http://localhost:3000` | | REACT_APP_URL_FILTER | `http://localhost:3000/*` | | REACT_APP_USER | `alice` | + +## How to launch as a SMART on FHIR app + +### Using a SMART App Launcher + +1. Go to a SMART app launcher, such as `http://moonshot-dev.mitre.org:4001/index.html` (MITRE) or `https://launch.smarthealthit.org/` (open to public). +2. For the App Launch URL, provide `http://localhost:3000/launch`. + +### Using Meld or a real EHR + +1. If you'd like to launch from Meld, [log in to Meld](https://meld.interop.community/) and follow steps 2-3. +2. The log in page will bring you to the My Sandboxes page. Go to your sandbox. +3. You will land on the Registered Apps page. Click on the circular plus button in the top-right corner and register the request-generator app manually with these settings: + + - Client Type: `Public Client` + - App Launch URI: `http://localhost:3000/launch` + - App Redirect URIs: `http://localhost:3000/#/index, http://localhost:4040/register,http://localhost:3000/index, http://localhost:4040/index` + - Scopes: `launch openid user/*.* offline_access profile` + +4. After registering request-generator, hover over it and click Launch. + + + +## How to launch a SMART on FHIR app from request-generator + +See the [following guide](./How-To-Launch-SMART-on-FHIR-Apps.md) for more information. From a155cc5b7743474f446adb310bbbeda985ddab27 Mon Sep 17 00:00:00 2001 From: Joyce Quach Date: Wed, 27 Dec 2023 13:39:43 -0500 Subject: [PATCH 5/8] Remove auto assign since we don't use it anymore --- .github/auto_assign.yml | 16 ---------------- 1 file changed, 16 deletions(-) delete mode 100644 .github/auto_assign.yml diff --git a/.github/auto_assign.yml b/.github/auto_assign.yml deleted file mode 100644 index b63c47d6..00000000 --- a/.github/auto_assign.yml +++ /dev/null @@ -1,16 +0,0 @@ -# Set to true to add reviewers to pull requests -addReviewers: true - -# Set to true to add assignees to pull requests -addAssignees: false - -# A list of reviewers to be added to pull requests (GitHub user name) -reviewers: - - zacharyrobin - - KeeyanGhoreshi - - smalho01 - - plarocque4 - - kennyEung - -# A number of reviewers added to the pull request, Set to 0 to add all reviewers -numberOfReviewers: 0 From e1a72160f4276939c28923da6c9767887d0a439a Mon Sep 17 00:00:00 2001 From: Joyce Quach Date: Wed, 27 Dec 2023 13:43:38 -0500 Subject: [PATCH 6/8] Remove comment since its text is duplicated in the README --- .env | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.env b/.env index 380805a7..76f60c85 100644 --- a/.env +++ b/.env @@ -28,4 +28,4 @@ REACT_APP_SERVER = http://localhost:8090 REACT_APP_SMART_LAUNCH_URL = http://localhost:4040/ REACT_APP_URL = http://localhost:3000 REACT_APP_URL_FILTER = http://localhost:3000/* -REACT_APP_USER = alice \ No newline at end of file +REACT_APP_USER = alice From 8529289337cb0658aba48d2dcfd1ba4817248127 Mon Sep 17 00:00:00 2001 From: Joyce Quach Date: Wed, 27 Dec 2023 14:48:26 -0500 Subject: [PATCH 7/8] Fix 'Each child in a list should have a unique key prop' warning --- src/components/Dashboard/Dashboard.jsx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/components/Dashboard/Dashboard.jsx b/src/components/Dashboard/Dashboard.jsx index 6c6acbef..c5304a3a 100644 --- a/src/components/Dashboard/Dashboard.jsx +++ b/src/components/Dashboard/Dashboard.jsx @@ -100,8 +100,8 @@ const Dashboard = props => { - {createIcons().map(option => ( -
+ {createIcons().map((option, index) => ( +
{option[1]} From 94d48fa21afef03e8c3910d7df90223a58fe443b Mon Sep 17 00:00:00 2001 From: Joyce Quach Date: Fri, 29 Dec 2023 17:24:58 -0500 Subject: [PATCH 8/8] Fix grammar --- README.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index c7d8004c..b7dd2b33 100644 --- a/README.md +++ b/README.md @@ -30,8 +30,8 @@ Embedded in the application are the public and private keys used to generate and ### How To Override Defaults -The .env file contains the default URI paths, these can be overwritten from the start command as follows: -`REACT_APP_LAUNCH_URL=http://example.com PORT=6000 npm start` or by specifying the environment variables and desired values in a `.env.local`. +The .env file contains the default URI paths, which can be overwritten from the start command as follows: +a) `REACT_APP_LAUNCH_URL=http://example.com PORT=6000 npm start` or b) by specifying the environment variables and desired values in a `.env.local`. Following are a list of modifiable paths: