-
Notifications
You must be signed in to change notification settings - Fork 145
docs: add details on locating proxies.xml examples and clarify conf…
#2389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…iguration transition from XML to YAML
|
Warning Rate limit exceeded@predic8 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 23 minutes and 1 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (1)
WalkthroughA new markdown file is added to the distribution/examples directory providing guidance on proxies.xml configuration samples, clarifying that XML configuration remains supported alongside the newer YAML format, with references to external documentation. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
🧹 Nitpick comments (2)
distribution/examples/proxies.xml.REAME.md (2)
3-5: Use hyphens in compound adjectives:XML-basedandYAML-basedApply this diff to correct hyphenation:
-Membrane is moving from XML based configuration to YAML based configuration. However, Membrane still -supports the XML based configuration with 'proxies.xml' files. Some examples in the subfolders are +Membrane is moving from XML-based configuration to YAML-based configuration. However, Membrane still +supports the XML-based configuration with 'proxies.xml' files. Some examples in the subfolders are
9-9: Format bare URL as a markdown linkApply this diff to follow markdown best practices:
-https://github.com/membrane/api-gateway/tree/master/distribution/examples +[GitHub examples](https://github.com/membrane/api-gateway/tree/master/distribution/examples)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
distribution/examples/proxies.xml.REAME.md(1 hunks)
🧰 Additional context used
🪛 LanguageTool
distribution/examples/proxies.xml.REAME.md
[grammar] ~3-~3: Use a hyphen to join words.
Context: ...ml samples? Membrane is moving from XML based configuration to YAML based config...
(QB_NEW_EN_HYPHEN)
[grammar] ~3-~3: Use a hyphen to join words.
Context: ...ing from XML based configuration to YAML based configuration. However, Membrane s...
(QB_NEW_EN_HYPHEN)
[grammar] ~4-~4: Use a hyphen to join words.
Context: ...owever, Membrane still supports the XML based configuration with 'proxies.xml' f...
(QB_NEW_EN_HYPHEN)
🪛 markdownlint-cli2 (0.18.1)
distribution/examples/proxies.xml.REAME.md
9-9: Bare URL used
(MD034, no-bare-urls)
…iguration transition from XML to YAML
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.