From ee123b69cccfda5d9ec9507b694b477736ab3631 Mon Sep 17 00:00:00 2001 From: Andries Smit Date: Fri, 1 Jul 2016 09:31:24 +0200 Subject: [PATCH] Need of _unsubscribe in uninitialize Do we need to unsubscribe to the handlers in unintialise? As we don't use; this.connect / this.subscribe / this.own --- src/WidgetName/widget/WidgetName.js | 1 + 1 file changed, 1 insertion(+) diff --git a/src/WidgetName/widget/WidgetName.js b/src/WidgetName/widget/WidgetName.js index f2a8957..0781e89 100644 --- a/src/WidgetName/widget/WidgetName.js +++ b/src/WidgetName/widget/WidgetName.js @@ -109,6 +109,7 @@ define([ uninitialize: function () { logger.debug(this.id + ".uninitialize"); // Clean up listeners, helper objects, etc. There is no need to remove listeners added with this.connect / this.subscribe / this.own. + this._unsubscribe(); }, // We want to stop events on a mobile device