From 7e49ea8bc709f387b95b02da349f0d62051b4529 Mon Sep 17 00:00:00 2001 From: Forgind Date: Thu, 4 Nov 2021 08:41:11 -0700 Subject: [PATCH 1/2] prolong version check --- src/MSBuildLocator/MSBuildLocator.cs | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/MSBuildLocator/MSBuildLocator.cs b/src/MSBuildLocator/MSBuildLocator.cs index c0651cbe..c5b60907 100644 --- a/src/MSBuildLocator/MSBuildLocator.cs +++ b/src/MSBuildLocator/MSBuildLocator.cs @@ -217,7 +217,8 @@ public static void RegisterMSBuildPath(string[] msbuildSearchPaths) string msbuildExe = Path.Combine(path, "MSBuild.exe"); if (File.Exists(msbuildExe)) { - if (FileVersionInfo.GetVersionInfo(msbuildExe).FileMajorPart < 17) + FileVersionInfo ver = FileVersionInfo.GetVersionInfo(msbuildExe); + if (ver.FileMajorPart < 17 || ver.FileMinorPart < 1) { if (Path.GetDirectoryName(msbuildExe).EndsWith(@"\amd64", StringComparison.OrdinalIgnoreCase)) { From 14a2cf249d04c8d174fc39e32e674b0a3e3ec2ed Mon Sep 17 00:00:00 2001 From: Forgind Date: Tue, 16 Nov 2021 09:21:27 -0800 Subject: [PATCH 2/2] Update src/MSBuildLocator/MSBuildLocator.cs Co-authored-by: xen2 --- src/MSBuildLocator/MSBuildLocator.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/MSBuildLocator/MSBuildLocator.cs b/src/MSBuildLocator/MSBuildLocator.cs index c5b60907..87be1e8c 100644 --- a/src/MSBuildLocator/MSBuildLocator.cs +++ b/src/MSBuildLocator/MSBuildLocator.cs @@ -218,7 +218,7 @@ public static void RegisterMSBuildPath(string[] msbuildSearchPaths) if (File.Exists(msbuildExe)) { FileVersionInfo ver = FileVersionInfo.GetVersionInfo(msbuildExe); - if (ver.FileMajorPart < 17 || ver.FileMinorPart < 1) + if (ver.FileMajorPart < 17 || (ver.FileMajorPart == 17 && ver.FileMinorPart < 1)) { if (Path.GetDirectoryName(msbuildExe).EndsWith(@"\amd64", StringComparison.OrdinalIgnoreCase)) {