From bd76fc675cc8b72f21e1b41681785a7b673320fc Mon Sep 17 00:00:00 2001
From: Andrew Arnott <Andrew.arnott@Microsoft.com>
Date: Fri, 8 Oct 2021 18:06:17 -0600
Subject: [PATCH 1/3] Clean up logging from NoTargets projects

A NoTargets project will still log (with high importance) something like:

> MyProject ->

Leaving a blank where the primary output would typically go. This looks weird. So this change removes that from being logged. It also disables (because it's the same property that controls it) copying of the primary output that we didn't build.
---
 src/NoTargets/Sdk/Sdk.props | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/src/NoTargets/Sdk/Sdk.props b/src/NoTargets/Sdk/Sdk.props
index a6cecde4..e5dc70d2 100644
--- a/src/NoTargets/Sdk/Sdk.props
+++ b/src/NoTargets/Sdk/Sdk.props
@@ -45,6 +45,9 @@
 
     <!-- Don't generate editor config file -->
     <GenerateMSBuildEditorConfigFile Condition="'$(GenerateMSBuildEditorConfigFile)' == ''">false</GenerateMSBuildEditorConfigFile>
+    
+    <!-- Don't log the high priority message mentioning this project's name (or copy the product we didn't build). -->
+    <SkipCopyBuildProduct>true</SkipCopyBuildProduct>
   </PropertyGroup>
 
   <ItemDefinitionGroup Condition=" '$(NoTargetsDoNotReferenceOutputAssemblies)' != 'false' ">

From 0ee138057dc261f6eab008a9b21f150e635072f0 Mon Sep 17 00:00:00 2001
From: Andrew Arnott <andrewarnott@gmail.com>
Date: Mon, 25 Oct 2021 11:04:31 -0500
Subject: [PATCH 2/3] Add unit test for change

---
 src/NoTargets.UnitTests/NoTargetsTests.cs | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/NoTargets.UnitTests/NoTargetsTests.cs b/src/NoTargets.UnitTests/NoTargetsTests.cs
index 2fb3a002..aafd5860 100644
--- a/src/NoTargets.UnitTests/NoTargetsTests.cs
+++ b/src/NoTargets.UnitTests/NoTargetsTests.cs
@@ -166,6 +166,7 @@ public void ProjectsCanDependOnNoTargetsProjects()
         [InlineData("GenerateMSBuildEditorConfigFile", "false")]
         [InlineData("IncludeBuildOutput", "false")]
         [InlineData("ProduceReferenceAssembly", "false")]
+        [InlineData("SkipCopyBuildProduct", "true")]
         public void PropertiesHaveExpectedValues(string propertyName, string expectedValue)
         {
             ProjectCreator.Templates.NoTargetsProject(

From fe266ee84cc27c7055776d8437c5ace642d08839 Mon Sep 17 00:00:00 2001
From: Andrew Arnott <andrewarnott@gmail.com>
Date: Mon, 25 Oct 2021 16:36:49 -0500
Subject: [PATCH 3/3] Add condition

---
 src/NoTargets/Sdk/Sdk.props | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/NoTargets/Sdk/Sdk.props b/src/NoTargets/Sdk/Sdk.props
index e5dc70d2..317ffadd 100644
--- a/src/NoTargets/Sdk/Sdk.props
+++ b/src/NoTargets/Sdk/Sdk.props
@@ -47,7 +47,7 @@
     <GenerateMSBuildEditorConfigFile Condition="'$(GenerateMSBuildEditorConfigFile)' == ''">false</GenerateMSBuildEditorConfigFile>
     
     <!-- Don't log the high priority message mentioning this project's name (or copy the product we didn't build). -->
-    <SkipCopyBuildProduct>true</SkipCopyBuildProduct>
+    <SkipCopyBuildProduct Condition="'$(SkipCopyBuildProduct)' == ''">true</SkipCopyBuildProduct>
   </PropertyGroup>
 
   <ItemDefinitionGroup Condition=" '$(NoTargetsDoNotReferenceOutputAssemblies)' != 'false' ">