diff --git a/src/CentralPackageVersions.UnitTests/CentralPackageVersionsTests.cs b/src/CentralPackageVersions.UnitTests/CentralPackageVersionsTests.cs index c0d2ffb1..e18798b7 100644 --- a/src/CentralPackageVersions.UnitTests/CentralPackageVersionsTests.cs +++ b/src/CentralPackageVersions.UnitTests/CentralPackageVersionsTests.cs @@ -236,37 +236,6 @@ public void IsDisabledForProjectsWithPackagesConfigOrDoNotSupportPackageReferenc enableCentralPackageVersions.ShouldBe("false"); } - [Fact] - public void LogErrorIfImportedInDirectoryBuildProps() - { - ProjectCreator.Create() - .Import(Path.Combine(ThisAssemblyDirectory, @"Sdk\Sdk.props")) - .Import(Path.Combine(ThisAssemblyDirectory, @"Sdk\Sdk.targets")) - .Save(GetTempFile("Directory.Build.props")); - - ProjectCreator.Create() - .Save(GetTempFile("Directory.Build.targets")); - - ProjectCreator.Templates - .PackagesProps( - path: GetTempFile("Packages.props"), - packageReferences: new Dictionary - { - ["Foo"] = "1.2.3", - }) - .Save(); - - ProjectCreator.Templates - .SdkCsproj(projectCreator: creator => creator - .ItemPackageReference("Foo")) - .Save(GetTempFile("Test.csproj")) - .TryBuild("CheckPackageReferences", out bool result, out BuildOutput buildOutput); - - result.ShouldBeFalse(buildOutput.GetConsoleLog()); - - buildOutput.Errors.ShouldBe(new[] { "Microsoft.Build.CentralPackageVersions was not imported in Directory.Build.targets. See https://github.com/microsoft/MSBuildSdks/tree/main/src/CentralPackageVersions for more information on how to include this SDK." }, buildOutput.GetConsoleLog()); - } - [Theory] [InlineData(".csproj")] [InlineData(".fsproj")] @@ -496,44 +465,15 @@ public void VersionOverridesWithoutCentralVersionsCanBeDisabled(string projectFi buildOutput.Errors.ShouldBe(new[] { $"The package reference \'Orphan\' must have a version defined in \'{packagesProps.FullPath}\'." }); } - [Fact] - public void WorksWithCustomImportPattern() + private ProjectCreator WritePackagesProps() { - WritePackagesProps(writeDirectoryBuildPropsTargets: false); - - ProjectCreator customProps = ProjectCreator.Create() - .ImportSdk("Sdk.props", "Microsoft.NET.Sdk") - .Save(Path.Combine(TestRootPath, "Custom.props")); + ProjectCreator.Create() + .Save(Path.Combine(TestRootPath, "Directory.Build.props")); - ProjectCreator customTargets = ProjectCreator.Create() - .ImportSdk("Sdk.targets", "Microsoft.NET.Sdk") + ProjectCreator.Create() .Import(Path.Combine(ThisAssemblyDirectory, @"Sdk\Sdk.props")) .Import(Path.Combine(ThisAssemblyDirectory, @"Sdk\Sdk.targets")) - .Save(Path.Combine(TestRootPath, "Custom.targets")); - - ProjectCreator.Create() - .Import(customProps) - .Property("TargetFramework", "net45") - .ItemPackageReference("Foo") - .Import(customTargets) - .Save(GetTempFileWithExtension(".csproj")) - .TryBuild("CheckPackageReferences", out bool result, out BuildOutput buildOutput); - - result.ShouldBeTrue(buildOutput.GetConsoleLog()); - } - - private ProjectCreator WritePackagesProps(bool writeDirectoryBuildPropsTargets = true) - { - if (writeDirectoryBuildPropsTargets) - { - ProjectCreator.Create() - .Save(Path.Combine(TestRootPath, "Directory.Build.props")); - - ProjectCreator.Create() - .Import(Path.Combine(ThisAssemblyDirectory, @"Sdk\Sdk.props")) - .Import(Path.Combine(ThisAssemblyDirectory, @"Sdk\Sdk.targets")) - .Save(Path.Combine(TestRootPath, "Directory.Build.targets")); - } + .Save(Path.Combine(TestRootPath, "Directory.Build.targets")); return ProjectCreator.Templates .PackagesProps( diff --git a/src/CentralPackageVersions/Sdk/Sdk.props b/src/CentralPackageVersions/Sdk/Sdk.props index 33c584a1..d3e4c500 100644 --- a/src/CentralPackageVersions/Sdk/Sdk.props +++ b/src/CentralPackageVersions/Sdk/Sdk.props @@ -12,5 +12,7 @@ true + + \ No newline at end of file diff --git a/src/CentralPackageVersions/Sdk/Sdk.targets b/src/CentralPackageVersions/Sdk/Sdk.targets index 8616c72d..c493a74e 100644 --- a/src/CentralPackageVersions/Sdk/Sdk.targets +++ b/src/CentralPackageVersions/Sdk/Sdk.targets @@ -13,10 +13,6 @@ Condition=" '$(EnableCentralPackageVersions)' != 'false' And '$(CustomBeforeCentralPackageVersionsTargets)' != '' And Exists('$(CustomBeforeCentralPackageVersionsTargets)') " /> - - <_WasMicrosoftCentralPackageVersionsSdkImportedInDirectoryBuildTargets Condition="'$(_WasMicrosoftCentralPackageVersionsSdkImportedInDirectoryBuildTargets)' == '' And '$(CommonTargetsPath)' == ''">false @@ -155,13 +151,7 @@ <_DuplicateGlobalPackageReference Include="@(_OriginalPackageReference)" Condition=" '@(GlobalPackageReference)' == '@(_OriginalPackageReference)' and '%(Identity)' != '' " /> - - - +