From ab8bc176862c17c40b2d6202dc72614dc94218e9 Mon Sep 17 00:00:00 2001 From: Viktor Hofer Date: Thu, 3 Mar 2022 16:59:54 +0100 Subject: [PATCH] Pass in properties for inner build targets As the `Clean`, `Test` and `VSTest` targets exist in inner builds, we should pass in properties that `ResolveProjectReferences` in Common.targets passes in as well. The Build and GetTargetPath targets already do so but the above listed targets don't which causes unnecessary clean and test invocations when a specific target framework is set. --- src/Traversal/Sdk/Sdk.targets | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/Traversal/Sdk/Sdk.targets b/src/Traversal/Sdk/Sdk.targets index 3ad75345..d866690f 100644 --- a/src/Traversal/Sdk/Sdk.targets +++ b/src/Traversal/Sdk/Sdk.targets @@ -158,6 +158,7 @@ $([MSBuild]::ValueOrDefault('$(CleanInParallel)', '$(BuildInParallel)')) )) ))" + Properties="%(ProjectReference.SetConfiguration); %(ProjectReference.SetPlatform); %(ProjectReference.SetTargetFramework)" SkipNonexistentProjects="$(SkipNonexistentProjects)" SkipNonexistentTargets="$(SkipNonexistentTargets)" StopOnFirstFailure="$(StopOnFirstFailure)" @@ -180,6 +181,7 @@ $([MSBuild]::ValueOrDefault('$(TestInParallel)', '$(BuildInParallel)')) )) ))" + Properties="%(ProjectReference.SetConfiguration); %(ProjectReference.SetPlatform); %(ProjectReference.SetTargetFramework)" SkipNonexistentProjects="$(SkipNonexistentProjects)" SkipNonexistentTargets="$(SkipNonexistentTargets)" StopOnFirstFailure="$(StopOnFirstFailure)" @@ -197,6 +199,7 @@ $([MSBuild]::ValueOrDefault('$(TestInParallel)', '$(BuildInParallel)')) )) ))" + Properties="%(ProjectReference.SetConfiguration); %(ProjectReference.SetPlatform); %(ProjectReference.SetTargetFramework)" SkipNonexistentProjects="$(SkipNonexistentProjects)" SkipNonexistentTargets="$(SkipNonexistentTargets)" StopOnFirstFailure="$(StopOnFirstFailure)"