From 6694867dfe94b7a5067be23121b35ff669a6afde Mon Sep 17 00:00:00 2001 From: Mathias Soeken Date: Wed, 2 Mar 2022 18:14:22 +0100 Subject: [PATCH 1/4] API review meeting notes. --- Design/meetings/2022/api-design-2022-03.md | 58 ++++++++++++++++++++++ 1 file changed, 58 insertions(+) create mode 100644 Design/meetings/2022/api-design-2022-03.md diff --git a/Design/meetings/2022/api-design-2022-03.md b/Design/meetings/2022/api-design-2022-03.md new file mode 100644 index 00000000000..22cf08ae94d --- /dev/null +++ b/Design/meetings/2022/api-design-2022-03.md @@ -0,0 +1,58 @@ +# Q# API Design Discussions / March 2022 + +Reviewers (in order by username): . + +## Agenda + +- https://github.com/microsoft/QuantumLibraries/issues/471 +- https://github.com/microsoft/QuantumLibraries/issues/442 +- https://github.com/microsoft/QuantumLibraries/issues/423 +- https://github.com/microsoft/QuantumLibraries/issues/515 + +## Discussion + +### Multivariate stochastic optimization + +**Proposal**: https://github.com/microsoft/QuantumLibraries/issues/471 + +**Reviews**: + +> Please add a bullet point including your alias, your review result (*approve*, *reject*, *comment*), and a comment (optional when result is *approve*). Alternatively, add a line to the PR discussion incl. a reference to this issue. + +**Consensus**: *TBD* + +--- + +### New functions for singly controlled operations + +**Proposal**: https://github.com/microsoft/QuantumLibraries/issues/442 + +**Reviews**: + +> Please add a bullet point including your alias, your review result (*approve*, *reject*, *comment*), and a comment (optional when result is *approve*). Alternatively, add a line to the PR discussion incl. a reference to this issue. + +**Consensus**: *TBD* + +--- + +### Simple and consistent arithmetic API + +**Proposal**: https://github.com/microsoft/QuantumLibraries/issues/423 + +**Reviews**: + +> Please add a bullet point including your alias, your review result (*approve*, *reject*, *comment*), and a comment (optional when result is *approve*). Alternatively, add a line to the PR discussion incl. a reference to this issue. + +**Consensus**: *TBD* + +--- + +### New operation: AmplitudeTransduction + +**Proposal**: https://github.com/microsoft/QuantumLibraries/issues/515 + +**Reviews**: + +> Please add a bullet point including your alias, your review result (*approve*, *reject*, *comment*), and a comment (optional when result is *approve*). Alternatively, add a line to the PR discussion incl. a reference to this issue. + +**Consensus**: *TBD* From 08ca545a9f9c72183612845e08e939d77ea3147d Mon Sep 17 00:00:00 2001 From: Mathias Soeken Date: Tue, 22 Mar 2022 09:54:27 -0700 Subject: [PATCH 2/4] Update Design/meetings/2022/api-design-2022-03.md Co-authored-by: Mariia Mykhailova --- Design/meetings/2022/api-design-2022-03.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Design/meetings/2022/api-design-2022-03.md b/Design/meetings/2022/api-design-2022-03.md index 22cf08ae94d..750ee679b55 100644 --- a/Design/meetings/2022/api-design-2022-03.md +++ b/Design/meetings/2022/api-design-2022-03.md @@ -28,7 +28,7 @@ Reviewers (in order by username): . **Proposal**: https://github.com/microsoft/QuantumLibraries/issues/442 **Reviews**: - +* @tcNickolas, *approve*, left a couple of small comments in the issue > Please add a bullet point including your alias, your review result (*approve*, *reject*, *comment*), and a comment (optional when result is *approve*). Alternatively, add a line to the PR discussion incl. a reference to this issue. **Consensus**: *TBD* From 105ac3b11f391474cfcc2e3d42fad570a98b32b1 Mon Sep 17 00:00:00 2001 From: Mathias Soeken Date: Tue, 22 Mar 2022 09:58:37 -0700 Subject: [PATCH 3/4] Apply suggestions from code review --- Design/meetings/2022/api-design-2022-03.md | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/Design/meetings/2022/api-design-2022-03.md b/Design/meetings/2022/api-design-2022-03.md index 750ee679b55..6bac4629554 100644 --- a/Design/meetings/2022/api-design-2022-03.md +++ b/Design/meetings/2022/api-design-2022-03.md @@ -16,7 +16,7 @@ Reviewers (in order by username): . **Proposal**: https://github.com/microsoft/QuantumLibraries/issues/471 **Reviews**: - +* @msoeken, *approve* > Please add a bullet point including your alias, your review result (*approve*, *reject*, *comment*), and a comment (optional when result is *approve*). Alternatively, add a line to the PR discussion incl. a reference to this issue. **Consensus**: *TBD* @@ -29,6 +29,7 @@ Reviewers (in order by username): . **Reviews**: * @tcNickolas, *approve*, left a couple of small comments in the issue +* @msoeken, *approve* > Please add a bullet point including your alias, your review result (*approve*, *reject*, *comment*), and a comment (optional when result is *approve*). Alternatively, add a line to the PR discussion incl. a reference to this issue. **Consensus**: *TBD* @@ -52,7 +53,7 @@ Reviewers (in order by username): . **Proposal**: https://github.com/microsoft/QuantumLibraries/issues/515 **Reviews**: - +@msoeken, *approve* > Please add a bullet point including your alias, your review result (*approve*, *reject*, *comment*), and a comment (optional when result is *approve*). Alternatively, add a line to the PR discussion incl. a reference to this issue. **Consensus**: *TBD* From 9e10368a40a0dc405b9b53e7ffb3cc1602b9ffd3 Mon Sep 17 00:00:00 2001 From: Mathias Soeken Date: Mon, 4 Apr 2022 07:41:09 -0700 Subject: [PATCH 4/4] Update consensus. --- Design/meetings/2022/api-design-2022-03.md | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/Design/meetings/2022/api-design-2022-03.md b/Design/meetings/2022/api-design-2022-03.md index 6bac4629554..5d4d53edf02 100644 --- a/Design/meetings/2022/api-design-2022-03.md +++ b/Design/meetings/2022/api-design-2022-03.md @@ -19,7 +19,7 @@ Reviewers (in order by username): . * @msoeken, *approve* > Please add a bullet point including your alias, your review result (*approve*, *reject*, *comment*), and a comment (optional when result is *approve*). Alternatively, add a line to the PR discussion incl. a reference to this issue. -**Consensus**: *TBD* +**Consensus**: Approved (incl. implicit approval from proposal author) --- @@ -32,7 +32,7 @@ Reviewers (in order by username): . * @msoeken, *approve* > Please add a bullet point including your alias, your review result (*approve*, *reject*, *comment*), and a comment (optional when result is *approve*). Alternatively, add a line to the PR discussion incl. a reference to this issue. -**Consensus**: *TBD* +**Consensus**: Approved (incl. implicit approval from proposal author) --- @@ -44,7 +44,7 @@ Reviewers (in order by username): . > Please add a bullet point including your alias, your review result (*approve*, *reject*, *comment*), and a comment (optional when result is *approve*). Alternatively, add a line to the PR discussion incl. a reference to this issue. -**Consensus**: *TBD* +**Consensus**: Postponed (no additional review was provided) --- @@ -56,4 +56,4 @@ Reviewers (in order by username): . @msoeken, *approve* > Please add a bullet point including your alias, your review result (*approve*, *reject*, *comment*), and a comment (optional when result is *approve*). Alternatively, add a line to the PR discussion incl. a reference to this issue. -**Consensus**: *TBD* +**Consensus**: Approved (incl. implicit approval from proposal author)