From bb53590336a67fb70c99e8bd1c9a517577cceaa0 Mon Sep 17 00:00:00 2001 From: Mathias Soeken Date: Sun, 17 Jul 2022 14:52:04 +0200 Subject: [PATCH 1/6] API review July 2022 --- Design/meetings/2022/api-design-2022-07.md | 54 ++++++++++++++++++++++ 1 file changed, 54 insertions(+) create mode 100644 Design/meetings/2022/api-design-2022-07.md diff --git a/Design/meetings/2022/api-design-2022-07.md b/Design/meetings/2022/api-design-2022-07.md new file mode 100644 index 00000000000..a80f93ffe15 --- /dev/null +++ b/Design/meetings/2022/api-design-2022-07.md @@ -0,0 +1,54 @@ +# Q# API Design Discussions / July 2022 + +Reviewers (in order by username): + +## Agenda + +- https://github.com/microsoft/QuantumLibraries/issues/598 +- https://github.com/microsoft/QuantumLibraries/issues/601 +- https://github.com/microsoft/QuantumLibraries/issues/602 +- https://github.com/microsoft/QuantumLibraries/issues/607 + +## Discussion + +### Fixed point truncation + +**Proposal**: https://github.com/microsoft/QuantumLibraries/issues/598 + +**Reviews**: +> Please add a bullet point including your alias, your review result (*approve*, *reject*, *comment*), and a comment (optional when result is *approve*). Alternatively, add a line to the PR discussion incl. a reference to this issue. + +**Consensus**: + +--- + +### Table lookup + +**Proposal**: https://github.com/microsoft/QuantumLibraries/issues/601 + +**Reviews**: +> Please add a bullet point including your alias, your review result (*approve*, *reject*, *comment*), and a comment (optional when result is *approve*). Alternatively, add a line to the PR discussion incl. a reference to this issue. + +**Consensus**: + +--- + +### Windowed unitary application + +**Proposal**: https://github.com/microsoft/QuantumLibraries/issues/602 + +**Reviews**: +> Please add a bullet point including your alias, your review result (*approve*, *reject*, *comment*), and a comment (optional when result is *approve*). Alternatively, add a line to the PR discussion incl. a reference to this issue. + +**Consensus**: + +--- + +### New operation - LookupTable + +**Proposal**: https://github.com/microsoft/QuantumLibraries/issues/607 + +**Reviews**: +> Please add a bullet point including your alias, your review result (*approve*, *reject*, *comment*), and a comment (optional when result is *approve*). Alternatively, add a line to the PR discussion incl. a reference to this issue. + +**Consensus**: From eb03f69da5c24c2e811ee863636d16c69477ab68 Mon Sep 17 00:00:00 2001 From: Mathias Soeken Date: Tue, 19 Jul 2022 05:26:29 -0700 Subject: [PATCH 2/6] Apply suggestions from code review Co-authored-by: Mariia Mykhailova --- Design/meetings/2022/api-design-2022-07.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Design/meetings/2022/api-design-2022-07.md b/Design/meetings/2022/api-design-2022-07.md index a80f93ffe15..60b95afdb22 100644 --- a/Design/meetings/2022/api-design-2022-07.md +++ b/Design/meetings/2022/api-design-2022-07.md @@ -16,6 +16,7 @@ Reviewers (in order by username): **Proposal**: https://github.com/microsoft/QuantumLibraries/issues/598 **Reviews**: +* @tcNickolas, *approve*, left a comment > Please add a bullet point including your alias, your review result (*approve*, *reject*, *comment*), and a comment (optional when result is *approve*). Alternatively, add a line to the PR discussion incl. a reference to this issue. **Consensus**: @@ -27,6 +28,7 @@ Reviewers (in order by username): **Proposal**: https://github.com/microsoft/QuantumLibraries/issues/601 **Reviews**: +* @tcNickolas, *approve*, left comments > Please add a bullet point including your alias, your review result (*approve*, *reject*, *comment*), and a comment (optional when result is *approve*). Alternatively, add a line to the PR discussion incl. a reference to this issue. **Consensus**: @@ -38,6 +40,7 @@ Reviewers (in order by username): **Proposal**: https://github.com/microsoft/QuantumLibraries/issues/602 **Reviews**: +* @tcNickolas, *approve* > Please add a bullet point including your alias, your review result (*approve*, *reject*, *comment*), and a comment (optional when result is *approve*). Alternatively, add a line to the PR discussion incl. a reference to this issue. **Consensus**: From dad67afcba0af31f75f683b4dbf6ca79d6f70c3e Mon Sep 17 00:00:00 2001 From: Mathias Soeken Date: Tue, 19 Jul 2022 05:31:09 -0700 Subject: [PATCH 3/6] Apply suggestions from code review --- Design/meetings/2022/api-design-2022-07.md | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/Design/meetings/2022/api-design-2022-07.md b/Design/meetings/2022/api-design-2022-07.md index 60b95afdb22..ac4134bb000 100644 --- a/Design/meetings/2022/api-design-2022-07.md +++ b/Design/meetings/2022/api-design-2022-07.md @@ -1,6 +1,6 @@ # Q# API Design Discussions / July 2022 -Reviewers (in order by username): +Reviewers (in order by username): @tcNickolas, @msoeken ## Agenda @@ -29,6 +29,7 @@ Reviewers (in order by username): **Reviews**: * @tcNickolas, *approve*, left comments +* @msoeken, *approve*, left comments > Please add a bullet point including your alias, your review result (*approve*, *reject*, *comment*), and a comment (optional when result is *approve*). Alternatively, add a line to the PR discussion incl. a reference to this issue. **Consensus**: @@ -41,6 +42,7 @@ Reviewers (in order by username): **Reviews**: * @tcNickolas, *approve* +* @msoeken, *approve*, left comments > Please add a bullet point including your alias, your review result (*approve*, *reject*, *comment*), and a comment (optional when result is *approve*). Alternatively, add a line to the PR discussion incl. a reference to this issue. **Consensus**: From 81e2b2469f2222451728c3c5bb35aec037a422f1 Mon Sep 17 00:00:00 2001 From: Mathias Soeken Date: Tue, 19 Jul 2022 11:57:22 -0700 Subject: [PATCH 4/6] Apply suggestions from code review --- Design/meetings/2022/api-design-2022-07.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Design/meetings/2022/api-design-2022-07.md b/Design/meetings/2022/api-design-2022-07.md index ac4134bb000..99f7f60e8a1 100644 --- a/Design/meetings/2022/api-design-2022-07.md +++ b/Design/meetings/2022/api-design-2022-07.md @@ -45,7 +45,7 @@ Reviewers (in order by username): @tcNickolas, @msoeken * @msoeken, *approve*, left comments > Please add a bullet point including your alias, your review result (*approve*, *reject*, *comment*), and a comment (optional when result is *approve*). Alternatively, add a line to the PR discussion incl. a reference to this issue. -**Consensus**: +**Consensus**: Approved as `ApplyToEachWindow` without `argumentTransform`, without `target` argument, with type parameter for input array, and with all 4 functor variants. --- From e3302a924b63d0af4e4eb27eaaf7ce69cf4840d6 Mon Sep 17 00:00:00 2001 From: Mathias Soeken Date: Fri, 19 Aug 2022 00:05:36 -0700 Subject: [PATCH 5/6] Update api-design-2022-07.md --- Design/meetings/2022/api-design-2022-07.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Design/meetings/2022/api-design-2022-07.md b/Design/meetings/2022/api-design-2022-07.md index 99f7f60e8a1..d89782caab2 100644 --- a/Design/meetings/2022/api-design-2022-07.md +++ b/Design/meetings/2022/api-design-2022-07.md @@ -1,6 +1,6 @@ # Q# API Design Discussions / July 2022 -Reviewers (in order by username): @tcNickolas, @msoeken +Reviewers (in order by username): @tcNickolas, @msoeken, @cgranade ## Agenda @@ -19,7 +19,7 @@ Reviewers (in order by username): @tcNickolas, @msoeken * @tcNickolas, *approve*, left a comment > Please add a bullet point including your alias, your review result (*approve*, *reject*, *comment*), and a comment (optional when result is *approve*). Alternatively, add a line to the PR discussion incl. a reference to this issue. -**Consensus**: +**Consensus**: Approved --- @@ -32,7 +32,7 @@ Reviewers (in order by username): @tcNickolas, @msoeken * @msoeken, *approve*, left comments > Please add a bullet point including your alias, your review result (*approve*, *reject*, *comment*), and a comment (optional when result is *approve*). Alternatively, add a line to the PR discussion incl. a reference to this issue. -**Consensus**: +**Consensus**: Postponed, requires more discussion --- From 338646daec347decaaedf9988b834278ed5cf30c Mon Sep 17 00:00:00 2001 From: Mathias Soeken Date: Fri, 19 Aug 2022 00:07:32 -0700 Subject: [PATCH 6/6] Update api-design-2022-07.md --- Design/meetings/2022/api-design-2022-07.md | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/Design/meetings/2022/api-design-2022-07.md b/Design/meetings/2022/api-design-2022-07.md index d89782caab2..1f4c665c1df 100644 --- a/Design/meetings/2022/api-design-2022-07.md +++ b/Design/meetings/2022/api-design-2022-07.md @@ -49,11 +49,12 @@ Reviewers (in order by username): @tcNickolas, @msoeken, @cgranade --- -### New operation - LookupTable +### New operation: Apply arithmetic function via table lookup **Proposal**: https://github.com/microsoft/QuantumLibraries/issues/607 **Reviews**: > Please add a bullet point including your alias, your review result (*approve*, *reject*, *comment*), and a comment (optional when result is *approve*). Alternatively, add a line to the PR discussion incl. a reference to this issue. +* @msoeken, *approve*, left comments -**Consensus**: +**Consensus**: Approved after comments