From 9ba730b4783b37562a795f2cd6c34bd808fc8037 Mon Sep 17 00:00:00 2001 From: Tristan Labelle Date: Fri, 8 Jan 2021 15:52:21 -0800 Subject: [PATCH 1/2] Untemplatize rules xaml file --- GoogleTestNuGet/Build.ps1 | 8 ++--- ...sui.xml.tt => googletest.propertiesui.xml} | 7 ++--- .../googletest.propertiesui.xml.tt.proj | 13 -------- GoogleTestNuGet/googletest.targets.tt | 30 +++++++++---------- 4 files changed, 19 insertions(+), 39 deletions(-) rename GoogleTestNuGet/{googletest.propertiesui.xml.tt => googletest.propertiesui.xml} (55%) delete mode 100644 GoogleTestNuGet/googletest.propertiesui.xml.tt.proj diff --git a/GoogleTestNuGet/Build.ps1 b/GoogleTestNuGet/Build.ps1 index 66bc3bd6d..638a030d7 100644 --- a/GoogleTestNuGet/Build.ps1 +++ b/GoogleTestNuGet/Build.ps1 @@ -192,7 +192,7 @@ function Build-Binaries { Push-Location $Dir try { $CMakeArgs = @() - $CMakeArgs += "-G", "Visual Studio 15 2017" + $CMakeArgs += "-G", "`"Visual Studio 15 2017`"" $CMakeArgs += "-T", $BuildToolset $CMakeArgs += "-A", $Platform $CMakeArgs += "-D", "BUILD_SHARED_LIBS=$(Convert-BooleanToOnOff $DynamicLibraryLinkage)" @@ -247,11 +247,7 @@ function Build-NuGet { $TargetsTTArgs += "googletest.targets.tt.proj" Invoke-Executable msbuild $TargetsTTArgs - $PropertiesUITTArgs = @() - $PropertiesUITTArgs += "/p:PackageNameDashes=`"$PackageNameDashes`"" - $PropertiesUITTArgs += "/p:OutputFileName=`"$Dir\build\native\$PackageName.propertiesui.xml`"" - $PropertiesUITTArgs += "googletest.propertiesui.xml.tt.proj" - Invoke-Executable msbuild $PropertiesUITTArgs + Copy-Item -Path "googletest.propertiesui.xml" -Destination "$Dir\build\native\googletest.propertiesui.xml" Copy-Item -Recurse -Path "..\ThirdParty\googletest\googletest\include" -Destination "$Dir\build\native\include" diff --git a/GoogleTestNuGet/googletest.propertiesui.xml.tt b/GoogleTestNuGet/googletest.propertiesui.xml similarity index 55% rename from GoogleTestNuGet/googletest.propertiesui.xml.tt rename to GoogleTestNuGet/googletest.propertiesui.xml index 37c4500b6..395f43c0a 100644 --- a/GoogleTestNuGet/googletest.propertiesui.xml.tt +++ b/GoogleTestNuGet/googletest.propertiesui.xml @@ -1,16 +1,13 @@ -<#@ template language="c#" hostspecific="true" #> -<#@ output extension=".targets" #> -<#@ parameter type="System.String" name="PackageNameDashes" #> - + - + diff --git a/GoogleTestNuGet/googletest.propertiesui.xml.tt.proj b/GoogleTestNuGet/googletest.propertiesui.xml.tt.proj deleted file mode 100644 index 6084ae4aa..000000000 --- a/GoogleTestNuGet/googletest.propertiesui.xml.tt.proj +++ /dev/null @@ -1,13 +0,0 @@ - - - - - - TextTemplatingFileGenerator - $(OutputFileName) - - - $(PackageNameDashes) - - - \ No newline at end of file diff --git a/GoogleTestNuGet/googletest.targets.tt b/GoogleTestNuGet/googletest.targets.tt index 050fad661..aa1d4a6a1 100644 --- a/GoogleTestNuGet/googletest.targets.tt +++ b/GoogleTestNuGet/googletest.targets.tt @@ -12,18 +12,18 @@ >true> - + $(MSBuildThisFileDirectory)..\..\\<#= PathToBinaries #>\x64\Debug\gtestd.lib;%(AdditionalDependencies) - $(MSBuildThisFileDirectory)..\..\\<#= PathToBinaries #>\x64\Debug\gtest_maind.lib;%(AdditionalDependencies) + $(MSBuildThisFileDirectory)..\..\\<#= PathToBinaries #>\x64\Debug\gtest_maind.lib;%(AdditionalDependencies) $(MSBuildThisFileDirectory)..\..\\<#= PathToBinaries #>\x64\Release\gtest.lib;%(AdditionalDependencies) - $(MSBuildThisFileDirectory)..\..\\<#= PathToBinaries #>\x64\Release\gtest_main.lib;%(AdditionalDependencies) + $(MSBuildThisFileDirectory)..\..\\<#= PathToBinaries #>\x64\Release\gtest_main.lib;%(AdditionalDependencies) $(MSBuildThisFileDirectory)..\..\\<#= PathToBinaries #>\x86\Debug\gtestd.lib;%(AdditionalDependencies) - $(MSBuildThisFileDirectory)..\..\\<#= PathToBinaries #>\x86\Debug\gtest_maind.lib;%(AdditionalDependencies) + $(MSBuildThisFileDirectory)..\..\\<#= PathToBinaries #>\x86\Debug\gtest_maind.lib;%(AdditionalDependencies) $(MSBuildThisFileDirectory)..\..\\<#= PathToBinaries #>\x86\Release\gtest.lib;%(AdditionalDependencies) - $(MSBuildThisFileDirectory)..\..\\<#= PathToBinaries #>\x86\Release\gtest_main.lib;%(AdditionalDependencies) + $(MSBuildThisFileDirectory)..\..\\<#= PathToBinaries #>\x86\Release\gtest_main.lib;%(AdditionalDependencies) $(MSBuildThisFileDirectory)include;%(AdditionalIncludeDirectories) @@ -32,40 +32,40 @@ <# if (ConfigurationType == "dyn") { #> - + - + <# } else { #> - + <# } #> <# if (ConfigurationType == "dyn") { #> - + <# } #> - + <# if (ConfigurationType == "dyn") { #> - + - + <# } else { #> - + <# } #> <# if (ConfigurationType == "dyn") { #> - + <# } else { #> - + <# } #> From 4d26aef5017fbbd83b6d5ed39d51869a01204b77 Mon Sep 17 00:00:00 2001 From: Tristan Labelle Date: Fri, 8 Jan 2021 17:24:02 -0800 Subject: [PATCH 2/2] PR feedback --- GoogleTestNuGet/Build.ps1 | 2 +- GoogleTestNuGet/googletest.propertiesui.xml | 4 +-- GoogleTestNuGet/googletest.targets.tt | 28 ++++++++++----------- 3 files changed, 17 insertions(+), 17 deletions(-) diff --git a/GoogleTestNuGet/Build.ps1 b/GoogleTestNuGet/Build.ps1 index 638a030d7..6fba22b85 100644 --- a/GoogleTestNuGet/Build.ps1 +++ b/GoogleTestNuGet/Build.ps1 @@ -192,7 +192,7 @@ function Build-Binaries { Push-Location $Dir try { $CMakeArgs = @() - $CMakeArgs += "-G", "`"Visual Studio 15 2017`"" + $CMakeArgs += "-G", "Visual Studio 15 2017" $CMakeArgs += "-T", $BuildToolset $CMakeArgs += "-A", $Platform $CMakeArgs += "-D", "BUILD_SHARED_LIBS=$(Convert-BooleanToOnOff $DynamicLibraryLinkage)" diff --git a/GoogleTestNuGet/googletest.propertiesui.xml b/GoogleTestNuGet/googletest.propertiesui.xml index 395f43c0a..830aa8316 100644 --- a/GoogleTestNuGet/googletest.propertiesui.xml +++ b/GoogleTestNuGet/googletest.propertiesui.xml @@ -1,13 +1,13 @@ - + - + diff --git a/GoogleTestNuGet/googletest.targets.tt b/GoogleTestNuGet/googletest.targets.tt index aa1d4a6a1..2fc019814 100644 --- a/GoogleTestNuGet/googletest.targets.tt +++ b/GoogleTestNuGet/googletest.targets.tt @@ -17,13 +17,13 @@ $(MSBuildThisFileDirectory)..\..\\<#= PathToBinaries #>\x64\Debug\gtestd.lib;%(AdditionalDependencies) - $(MSBuildThisFileDirectory)..\..\\<#= PathToBinaries #>\x64\Debug\gtest_maind.lib;%(AdditionalDependencies) + $(MSBuildThisFileDirectory)..\..\\<#= PathToBinaries #>\x64\Debug\gtest_maind.lib;%(AdditionalDependencies) $(MSBuildThisFileDirectory)..\..\\<#= PathToBinaries #>\x64\Release\gtest.lib;%(AdditionalDependencies) - $(MSBuildThisFileDirectory)..\..\\<#= PathToBinaries #>\x64\Release\gtest_main.lib;%(AdditionalDependencies) + $(MSBuildThisFileDirectory)..\..\\<#= PathToBinaries #>\x64\Release\gtest_main.lib;%(AdditionalDependencies) $(MSBuildThisFileDirectory)..\..\\<#= PathToBinaries #>\x86\Debug\gtestd.lib;%(AdditionalDependencies) - $(MSBuildThisFileDirectory)..\..\\<#= PathToBinaries #>\x86\Debug\gtest_maind.lib;%(AdditionalDependencies) + $(MSBuildThisFileDirectory)..\..\\<#= PathToBinaries #>\x86\Debug\gtest_maind.lib;%(AdditionalDependencies) $(MSBuildThisFileDirectory)..\..\\<#= PathToBinaries #>\x86\Release\gtest.lib;%(AdditionalDependencies) - $(MSBuildThisFileDirectory)..\..\\<#= PathToBinaries #>\x86\Release\gtest_main.lib;%(AdditionalDependencies) + $(MSBuildThisFileDirectory)..\..\\<#= PathToBinaries #>\x86\Release\gtest_main.lib;%(AdditionalDependencies) $(MSBuildThisFileDirectory)include;%(AdditionalIncludeDirectories) @@ -32,40 +32,40 @@ <# if (ConfigurationType == "dyn") { #> - + - + <# } else { #> - + <# } #> <# if (ConfigurationType == "dyn") { #> - + <# } #> - + <# if (ConfigurationType == "dyn") { #> - + - + <# } else { #> - + <# } #> <# if (ConfigurationType == "dyn") { #> - + <# } else { #> - + <# } #>