Move code out of closure in getDocumentHighlights, then again out of getSemanticDocumentHighlights and getSyntacticDocumentHighlights.

Also return a `Node[]` instead of a `HighlightSpan[]` where possible and do mapping from Node to HighlightSpan in one place.

Author: Andy Hanson