Merge branch 'master' into fix-33732

Author: jack-williams

.dockerignore

@@ -22,14 +22,14 @@ scripts/buildProtocol.js
 scripts/ior.js
 scripts/authors.js
 scripts/configurePrerelease.js
-scripts/configureTSCBuild.js
 scripts/open-user-pr.js
 scripts/open-cherry-pick-pr.js
 scripts/processDiagnosticMessages.d.ts
 scripts/processDiagnosticMessages.js
 scripts/produceLKG.js
 scripts/importDefinitelyTypedTests/importDefinitelyTypedTests.js
 scripts/generateLocalizedDiagnosticMessages.js
+scripts/configureLanguageServiceBuild.js
 scripts/*.js.map
 scripts/typings/
 coverage/

.eslintrc.json

@@ -54,6 +54,7 @@
         "simple-indent": "error",
         "debug-assert": "error",
         "no-keywords": "error",
+        "one-namespace-per-file": "error",
 
         // eslint-plugin-import
         "import/no-extraneous-dependencies": ["error", { "optionalDependencies": false }],

.github/ISSUE_TEMPLATE/Bug_report.md

@@ -1,37 +1,44 @@
----
-name: Bug report
-about: Create a report to help us improve
-
----
-
-<!-- 🚨 STOP 🚨 𝗦𝗧𝗢𝗣 🚨 𝑺𝑻𝑶𝑷 🚨
-
-Half of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker. Even if you think you've found a *bug*, please read the FAQ first, especially the Common "Bugs" That Aren't Bugs section!
-
-Please help us by doing the following steps before logging an issue:
-  * Search: https://github.com/Microsoft/TypeScript/search?type=Issues
-  * Read the FAQ: https://github.com/Microsoft/TypeScript/wiki/FAQ
-
-Please fill in the *entire* template below.
--->
-
-<!-- Please try to reproduce the issue with `typescript@next`. It may have already been fixed. -->
-**TypeScript Version:**  3.4.0-dev.201xxxxx
-
-<!-- Search terms you tried before logging this (so others can find this issue more easily) -->
-**Search Terms:**
-
-**Code**
-
-```ts
-// A *self-contained* demonstration of the problem follows...
-// Test this by running `tsc` on the command-line, rather than through another build tool such as Gulp, Webpack, etc.
-```
-
-**Expected behavior:**
-
-**Actual behavior:**
-
-**Playground Link:** <!-- A link to a TypeScript Playground "Share" link which demonstrates this behavior -->
-
-**Related Issues:** <!-- Did you find other bugs that looked similar? -->
+---
+name: Bug
+about: Create a report to help us improve TypeScript
+title: ''
+labels: ''
+assignees: ''
+
+---
+
+<!-- 🚨 STOP 🚨 𝗦𝗧𝗢𝗣 🚨 𝑺𝑻𝑶𝑷 🚨
+
+Half of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker. Even if you think you've found a *bug*, please read the FAQ first, especially the Common "Bugs" That Aren't Bugs section!
+
+Please help us by doing the following steps before logging an issue:
+  * Search: https://github.com/Microsoft/TypeScript/search?type=Issues
+  * Read the FAQ: https://github.com/Microsoft/TypeScript/wiki/FAQ
+
+Please fill in the *entire* template below.
+-->
+
+<!--
+Please try to reproduce the issue with the latest published version. It may have already been fixed.
+For npm: `typescript@next`
+This is also the 'Nightly' version in the playground: http://www.typescriptlang.org/play/?ts=Nightly
+-->
+**TypeScript Version:**  3.7.x-dev.201xxxxx
+
+<!-- Search terms you tried before logging this (so others can find this issue more easily) -->
+**Search Terms:**
+
+**Code**
+
+```ts
+// A *self-contained* demonstration of the problem follows...
+// Test this by running `tsc` on the command-line, rather than through another build tool such as Gulp, Webpack, etc.
+```
+
+**Expected behavior:**
+
+**Actual behavior:**
+
+**Playground Link:** <!-- A link to a TypeScript Playground "Share" link which demonstrates this behavior -->
+
+**Related Issues:** <!-- Did you find other bugs that looked similar? -->

.github/ISSUE_TEMPLATE/Feature_request.md

@@ -1,45 +1,47 @@
----
-name: Feature request
-about: Suggest an idea for this project
-
----
-
-<!-- 🚨 STOP 🚨 𝗦𝗧𝗢𝗣 🚨 𝑺𝑻𝑶𝑷 🚨
-
-Half of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker.
-
-Please help us by doing the following steps before logging an issue:
-  * Search: https://github.com/Microsoft/TypeScript/search?type=Issues
-  * Read the FAQ, especially the "Common Feature Requests" section: https://github.com/Microsoft/TypeScript/wiki/FAQ
-
--->
-
-## Search Terms
-
-<!-- List of keywords you searched for before creating this issue. Write them down here so that others can find this suggestion more easily -->
-
-## Suggestion
-
-<!-- A summary of what you'd like to see added or changed -->
-
-## Use Cases
-
-<!--
-What do you want to use this for?
-What shortcomings exist with current approaches?
--->
-
-## Examples
-
-<!-- Show how this would be used and what the behavior would be -->
-
-## Checklist
-
-My suggestion meets these guidelines:
-
-* [ ] This wouldn't be a breaking change in existing TypeScript/JavaScript code
-* [ ] This wouldn't change the runtime behavior of existing JavaScript code
-* [ ] This could be implemented without emitting different JS based on the types of the expressions
-* [ ] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
-* [ ] This feature would agree with the rest of [TypeScript's Design Goals](https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals).
-
+---
+name: Feature Request
+about: Suggest an idea
+title: ''
+labels: ''
+assignees: ''
+
+---
+
+<!-- 🚨 STOP 🚨 𝗦𝗧𝗢𝗣 🚨 𝑺𝑻𝑶𝑷 🚨
+
+Half of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker.
+
+Please help us by doing the following steps before logging an issue:
+  * Search: https://github.com/Microsoft/TypeScript/search?type=Issues
+  * Read the FAQ, especially the "Common Feature Requests" section: https://github.com/Microsoft/TypeScript/wiki/FAQ
+
+-->
+
+## Search Terms
+
+<!-- List of keywords you searched for before creating this issue. Write them down here so that others can find this suggestion more easily -->
+
+## Suggestion
+
+<!-- A summary of what you'd like to see added or changed -->
+
+## Use Cases
+
+<!--
+What do you want to use this for?
+What shortcomings exist with current approaches?
+-->
+
+## Examples
+
+<!-- Show how this would be used and what the behavior would be -->
+
+## Checklist
+
+My suggestion meets these guidelines:
+
+* [ ] This wouldn't be a breaking change in existing TypeScript/JavaScript code
+* [ ] This wouldn't change the runtime behavior of existing JavaScript code
+* [ ] This could be implemented without emitting different JS based on the types of the expressions
+* [ ] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
+* [ ] This feature would agree with the rest of [TypeScript's Design Goals](https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals).

.github/ISSUE_TEMPLATE/Question.md

@@ -0,0 +1,11 @@
+blank_issues_enabled: false
+contact_links:
+  - name: Question
+    url: https://stackoverflow.com/questions/tagged/typescript
+    about: Please ask and answer questions here.
+  - name: TypeScript FAQ
+    url: https://github.com/microsoft/TypeScript/wiki/FAQ
+    about: Please check the FAQ before filing new issues
+- name: Website
+    url: https://github.com/microsoft/TypeScript-Website/issues/new
+    about: Please raise issues about the site on it's own repo.

.github/ISSUE_TEMPLATE/config.yml

@@ -0,0 +1,37 @@
+name: CI
+
+on:
+  push:
+    branches:
+      - master
+      - release-*
+  pull_request:
+    branches:
+      - master
+      - release-*
+
+jobs:
+  build:
+    runs-on: ubuntu-latest
+
+    strategy:
+      matrix:
+        node-version: [8.x, 10.x, 12.x]
+
+    steps:
+    - uses: actions/checkout@v1
+      with:
+        fetch-depth: 5
+    - name: Use node version ${{ matrix.node-version }}
+      uses: actions/setup-node@v1
+      with:
+        node-version: ${{ matrix.node-version }}
+    - name: Remove existing TypeScript
+      run: |
+        npm uninstall typescript --no-save
+        npm uninstall tslint --no-save
+    - name: npm install and test
+      run: |
+        npm install
+        npm update
+        npm test

.github/workflows/ci.yml

@@ -46,7 +46,6 @@ scripts/ior.js
 scripts/authors.js
 scripts/configurePrerelease.js
 scripts/configureLanguageServiceBuild.js
-scripts/createLanguageServiceBuild.js
 scripts/open-user-pr.js
 scripts/open-cherry-pick-pr.js
 scripts/processDiagnosticMessages.d.ts
@@ -91,6 +90,7 @@ tests/cases/user/TypeScript-React-Native-Starter/TypeScript-React-Native-Starter
 tests/cases/user/TypeScript-Vue-Starter/TypeScript-Vue-Starter
 tests/cases/user/TypeScript-WeChat-Starter/TypeScript-WeChat-Starter
 tests/cases/user/create-react-app/create-react-app
+tests/cases/user/fp-ts/fp-ts
 tests/cases/user/webpack/webpack
 tests/cases/user/puppeteer/puppeteer
 tests/cases/user/axios-src/axios-src

.gitignore

@@ -1,5 +1,17 @@
-// Rename this file 'launch.json' or merge its
-// contents into your existing configurations.
+/* 
+
+  Copy this file into '.vscode/launch.json' or merge its
+  contents into your existing configurations.
+
+  If you want to remove the errors in comments for all JSON
+  files, add this to your settings in ~/.vscode/User/settings.json
+
+  "files.associations": {
+      "*.json": "jsonc"
+  },
+
+*/
+
 {
   // Use IntelliSense to learn about possible attributes.
   // Hover to view descriptions of existing attributes.
@@ -10,7 +22,7 @@
       "type": "node",
       "protocol": "inspector",
       "request": "launch",
-      "name": "Mocha Tests (currently opened test)",
+      "name": "Mocha Tests (currently opened test)",
       "runtimeArgs": ["--nolazy"],
       "program": "${workspaceRoot}/node_modules/mocha/bin/_mocha",
       "args": [
@@ -20,6 +32,8 @@
         "--colors",
         "built/local/run.js",
         "-f",
+        // You can change this to be the name of a specific test file (without the file extension)
+        // to consistently launch the same test
         "${fileBasenameNoExtension}",
         "--skip-percent",
         "0"
@@ -34,6 +48,13 @@
       "outFiles": [
         "${workspaceRoot}/built/local/run.js"
       ]
+    },
+    {
+      // See: https://github.com/microsoft/TypeScript/wiki/Debugging-Language-Service-in-VS-Code
+      "type": "node",
+      "request": "attach",
+      "name": "Attach to VS Code TS Server via Port",
+      "processId": "${command:PickProcess}"
     }
   ]
-}
+}

.vscode/launch.template.json

@@ -59,31 +59,31 @@ Run `gulp` to build a version of the compiler/language service that reflects cha
 
 ## Contributing bug fixes
 
-TypeScript is currently accepting contributions in the form of bug fixes. A bug must have an issue tracking it in the issue tracker that has been approved (labelled ["help wanted"](https://github.com/Microsoft/TypeScript/issues?q=is%3Aopen+is%3Aissue+label%3A%22help+wanted%22)) by the TypeScript team. Your pull request should include a link to the bug that you are fixing. If you've submitted a PR for a bug, please post a comment in the bug to avoid duplication of effort.
+TypeScript is currently accepting contributions in the form of bug fixes. A bug must have an issue tracking it in the issue tracker that has been approved (labelled ["help wanted"](https://github.com/Microsoft/TypeScript/issues?q=is%3Aopen+is%3Aissue+label%3A%22help+wanted%22) or in the "Backlog milestone") by the TypeScript team. Your pull request should include a link to the bug that you are fixing. If you've submitted a PR for a bug, please post a comment in the bug to avoid duplication of effort.
 
 ## Contributing features
 
-Features (things that add new or improved functionality to TypeScript) may be accepted, but will need to first be approved ([labelled "help wanted"](https://github.com/Microsoft/TypeScript/issues?q=is%3Aopen+is%3Aissue+label%3A%22help+wanted%22) by a TypeScript project maintainer) in the suggestion issue. Features with language design impact, or that are adequately satisfied with external tools, will not be accepted.
+Features (things that add new or improved functionality to TypeScript) may be accepted, but will need to first be approved (labelled ["help wanted"](https://github.com/Microsoft/TypeScript/issues?q=is%3Aopen+is%3Aissue+label%3A%22help+wanted%22) or in the "Backlog" milestone) by a TypeScript project maintainer) in the suggestion issue. Features with language design impact, or that are adequately satisfied with external tools, will not be accepted.
 
 Design changes will not be accepted at this time. If you have a design change proposal, please log a suggestion issue.
 
 ## Legal
 
 You will need to complete a Contributor License Agreement (CLA). Briefly, this agreement testifies that you are granting us permission to use the submitted change according to the terms of the project's license, and that the work being submitted is under appropriate copyright.
 
-Please submit a Contributor License Agreement (CLA) before submitting a pull request. You may visit https://cla.microsoft.com to sign digitally. Alternatively, download the agreement ([Microsoft Contribution License Agreement.pdf](https://opensource.microsoft.com/pdf/microsoft-contribution-license-agreement.pdf)), sign, scan, and email it back to <cla@microsoft.com>. Be sure to include your GitHub user name along with the agreement. Once we have received the signed CLA, we'll review the request. 
+Please submit a Contributor License Agreement (CLA) before submitting a pull request. You may visit https://cla.microsoft.com to sign digitally. Alternatively, download the agreement ([Microsoft Contribution License Agreement.pdf](https://opensource.microsoft.com/pdf/microsoft-contribution-license-agreement.pdf)), sign, scan, and email it back to <cla@microsoft.com>. Be sure to include your GitHub user name along with the agreement. Once we have received the signed CLA, we'll review the request.
 
 ## Housekeeping
 
-Your pull request should: 
+Your pull request should:
 
 * Include a description of what your change intends to do
-* Be a child commit of a reasonably recent commit in the **master** branch 
+* Be a child commit of a reasonably recent commit in the **master** branch
     * Requests need not be a single commit, but should be a linear sequence of commits (i.e. no merge commits in your PR)
 * It is desirable, but not necessary, for the tests to pass at each commit
-* Have clear commit messages 
+* Have clear commit messages
     * e.g. "Minor refactor in goToTypeDefinition", "Fix iterated type in for-await-of", "Add test for preserveWatchOutput on command line"
-* Include adequate tests 
+* Include adequate tests
     * At least one test should fail in the absence of your non-test code changes. If your PR does not match this criteria, please specify why
     * Tests should include reasonable permutations of the target fix/change
     * Include baseline changes with your change
@@ -133,7 +133,7 @@ e.g. to run all compiler baseline tests:
 gulp runtests --tests=compiler
 ```
 
-or to run a specific test: `tests\cases\compiler\2dArrays.ts` 
+or to run a specific test: `tests\cases\compiler\2dArrays.ts`
 
 ```Shell
 gulp runtests --tests=2dArrays