Display write type for property accesses in write locations (#54777)

Author: Andarist

src/compiler/checker.ts

@@ -11541,7 +11541,7 @@ export function createTypeChecker(host: TypeCheckerHost): TypeChecker {
                     getWriteTypeOfSymbolWithDeferredType(symbol) || getTypeOfSymbolWithDeferredType(symbol) :
                     // NOTE: cast to TransientSymbol should be safe because only TransientSymbols can have CheckFlags.SyntheticProperty
                     (symbol as TransientSymbol).links.writeType || (symbol as TransientSymbol).links.type! :
-                getTypeOfSymbol(symbol);
+                removeMissingType(getTypeOfSymbol(symbol), !!(symbol.flags & SymbolFlags.Optional));
         }
         if (symbol.flags & SymbolFlags.Accessor) {
             return checkFlags & CheckFlags.Instantiated ?
@@ -27703,7 +27703,11 @@ export function createTypeChecker(host: TypeCheckerHost): TypeChecker {
                 location = location.parent;
             }
             if (isExpressionNode(location) && (!isAssignmentTarget(location) || isWriteAccess(location))) {
-                const type = removeOptionalTypeMarker(getTypeOfExpression(location as Expression));
+                const type = removeOptionalTypeMarker(
+                    isWriteAccess(location) && location.kind === SyntaxKind.PropertyAccessExpression ?
+                        checkPropertyAccessExpression(location as PropertyAccessExpression, /*checkMode*/ undefined, /*writeOnly*/ true) :
+                        getTypeOfExpression(location as Expression)
+                );
                 if (getExportSymbolOfValueSymbolIfExported(getNodeLinks(location).resolvedSymbol) === symbol) {
                     return type;
                 }

tests/cases/fourslash/quickInfoOnPropertyAccessInWriteLocation1.ts

@@ -0,0 +1,8 @@
+/// <reference path='fourslash.ts'/>
+
+// @strict: true
+// @exactOptionalPropertyTypes: true
+//// declare const xx: { prop?: number };
+//// xx.prop/*1*/ = 1;
+
+verify.quickInfoAt('1', '(property) prop?: number');

tests/cases/fourslash/quickInfoOnPropertyAccessInWriteLocation2.ts

@@ -0,0 +1,8 @@
+/// <reference path='fourslash.ts'/>
+
+// @strict: true
+// @exactOptionalPropertyTypes: true
+//// declare const xx: { prop?: number };
+//// xx.prop/*1*/ += 1;
+
+verify.quickInfoAt('1', '(property) prop?: number');

tests/cases/fourslash/quickInfoOnPropertyAccessInWriteLocation3.ts

@@ -0,0 +1,8 @@
+/// <reference path='fourslash.ts'/>
+
+// @strict: true
+// @exactOptionalPropertyTypes: true
+//// declare const xx: { prop?: number };
+//// xx.prop/*1*/ ??= 1;
+
+verify.quickInfoAt('1', '(property) prop?: number');

tests/cases/fourslash/quickInfoOnPropertyAccessInWriteLocation4.ts

@@ -0,0 +1,11 @@
+/// <reference path='fourslash.ts'/>
+
+// @strict: true
+//// interface Serializer {
+////   set value(v: string | number | boolean);
+////   get value(): string;
+//// }
+//// declare let box: Serializer;
+//// box.value/*1*/ = true;
+
+verify.quickInfoAt('1', '(property) Serializer.value: string | number | boolean');

tests/cases/fourslash/quickInfoOnPropertyAccessInWriteLocation5.ts

@@ -0,0 +1,11 @@
+/// <reference path='fourslash.ts'/>
+
+// @strict: true
+//// interface Serializer {
+////   set value(v: string | number);
+////   get value(): string;
+//// }
+//// declare let box: Serializer;
+//// box.value/*1*/ += 10;
+
+verify.quickInfoAt('1', '(property) Serializer.value: string | number');