fix(46570): Unhelpful Promise type argument hint in JS file

Author: nicdard

src/compiler/checker.ts

@@ -30266,9 +30266,11 @@ namespace ts {
             const parameterRange = hasRestParameter ? min
                 : min < max ? min + "-" + max
                 : min;
+            const file = getSourceFileOfNode(node);
             const error = hasRestParameter ? Diagnostics.Expected_at_least_0_arguments_but_got_1
-                : parameterRange === 1 && args.length === 0 && isPromiseResolveArityError(node) ? Diagnostics.Expected_0_arguments_but_got_1_TypeScript_may_need_a_JSDoc_hint_that_the_call_to_new_Promise_produces_a_Promise_void
-                : Diagnostics.Expected_0_arguments_but_got_1;
+                : (file.scriptKind === ScriptKind.JS || file.scriptKind === ScriptKind.JSX) && parameterRange === 1 && args.length === 0 && isPromiseResolveArityError(node) 
+                    ? Diagnostics.Expected_0_arguments_but_got_1_TypeScript_may_need_a_JSDoc_hint_that_the_call_to_new_Promise_produces_a_Promise_void
+                    : Diagnostics.Expected_0_arguments_but_got_1;
             if (min < args.length && args.length < max) {
                 // between min and max, but with no matching overload
                 return getDiagnosticForCallNode(node, Diagnostics.No_overload_expects_0_arguments_but_overloads_do_exist_that_expect_either_1_or_2_arguments, args.length, maxBelow, minAbove);

src/services/codefixes/fixAddVoidToPromise.ts

@@ -3,7 +3,7 @@ namespace ts.codefix {
     const fixName = "addVoidToPromise";
     const fixId = "addVoidToPromise";
     const errorCodes = [
-        Diagnostics.Expected_0_arguments_but_got_1_TypeScript_may_need_a_JSDoc_hint_that_the_call_to_new_Promise_produces_a_Promise_void.code
+        Diagnostics.Expected_0_arguments_but_got_1.code
     ];
     registerCodeFix({
         errorCodes,