From 83f25ded6f26e9888aeeb14b8b3d07edadcc60a9 Mon Sep 17 00:00:00 2001 From: Vladimir Matveev Date: Tue, 22 Nov 2016 14:08:36 -0800 Subject: [PATCH 1/2] add typings installer user agent for npm requests --- src/server/typingsInstaller/nodeTypingsInstaller.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/server/typingsInstaller/nodeTypingsInstaller.ts b/src/server/typingsInstaller/nodeTypingsInstaller.ts index bdfdda3033cb8..9fa8405ea38e5 100644 --- a/src/server/typingsInstaller/nodeTypingsInstaller.ts +++ b/src/server/typingsInstaller/nodeTypingsInstaller.ts @@ -127,7 +127,7 @@ namespace ts.server.typingsInstaller { if (this.log.isEnabled()) { this.log.writeLine(`#${requestId} with arguments'${JSON.stringify(args)}'.`); } - const command = `${this.npmPath} install ${args.join(" ")} --save-dev`; + const command = `${this.npmPath} install ${args.join(" ")} --save-dev --user-agent="TypingsInstaller/${version}"`; const start = Date.now(); let stdout: Buffer; let stderr: Buffer; From 10e029bcd37d1e241556be519edc91ab2db28bfa Mon Sep 17 00:00:00 2001 From: Vladimir Matveev Date: Tue, 22 Nov 2016 14:40:20 -0800 Subject: [PATCH 2/2] address PR feedback: change name of user agent --- src/server/typingsInstaller/nodeTypingsInstaller.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/server/typingsInstaller/nodeTypingsInstaller.ts b/src/server/typingsInstaller/nodeTypingsInstaller.ts index 9fa8405ea38e5..235c2f16dad73 100644 --- a/src/server/typingsInstaller/nodeTypingsInstaller.ts +++ b/src/server/typingsInstaller/nodeTypingsInstaller.ts @@ -127,7 +127,7 @@ namespace ts.server.typingsInstaller { if (this.log.isEnabled()) { this.log.writeLine(`#${requestId} with arguments'${JSON.stringify(args)}'.`); } - const command = `${this.npmPath} install ${args.join(" ")} --save-dev --user-agent="TypingsInstaller/${version}"`; + const command = `${this.npmPath} install ${args.join(" ")} --save-dev --user-agent="typesInstaller/${version}"`; const start = Date.now(); let stdout: Buffer; let stderr: Buffer;