From 7fe56f1754bcd99cfcae8de171171b19edc93e41 Mon Sep 17 00:00:00 2001 From: Jake Bailey <5341706+jakebailey@users.noreply.github.com> Date: Mon, 8 Dec 2025 10:47:21 -0800 Subject: [PATCH 1/2] Fix ContextFlags compile error --- src/services/stringCompletions.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/services/stringCompletions.ts b/src/services/stringCompletions.ts index d8267ca16e57c..42c72bd4ca998 100644 --- a/src/services/stringCompletions.ts +++ b/src/services/stringCompletions.ts @@ -434,7 +434,7 @@ function getStringLiteralCompletionEntries(sourceFile: SourceFile, node: StringL const uniques = new Set(); const stringLiteralTypes = concatenate( getStringLiteralTypes(typeChecker.getContextualType(node, ContextFlags.None), uniques), - getStringLiteralTypes(typeChecker.getContextualType(node, ContextFlags.Completions), uniques), + getStringLiteralTypes(typeChecker.getContextualType(node, ContextFlags.IgnoreNodeInferences), uniques), ); return toStringLiteralCompletionsFromTypes(stringLiteralTypes); } From 05896c5878de694d360a791577ca21eb82396036 Mon Sep 17 00:00:00 2001 From: Jake Bailey <5341706+jakebailey@users.noreply.github.com> Date: Mon, 8 Dec 2025 11:08:51 -0800 Subject: [PATCH 2/2] I can't force merge so I guess let's fix this --- .github/workflows/ci.yml | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 644562b083226..02104da2fd400 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -316,17 +316,23 @@ jobs: working-directory: ./pr - run: npm ci + id: base-npm-ci + continue-on-error: true working-directory: ./base - run: npx hereby lkg working-directory: ./pr - run: npx hereby lkg + id: base-lkg + continue-on-error: true + if: ${{ steps.base-npm-ci.outcome == 'success' }} working-directory: ./base - run: | echo "See $GITHUB_SERVER_URL/$GITHUB_REPOSITORY/actions/runs/$GITHUB_RUN_ID for more info." node ./pr/scripts/checkPackageSize.mjs ./base ./pr >> $GITHUB_STEP_SUMMARY + if: ${{ steps.base-lkg.outcome == 'success' }} misc: runs-on: ubuntu-latest