Added a gaggle of missing joins in unit tests (#1099)

tracyboehrer · web-flow · commit 918b55cf4b18 · 2021-03-26T13:06:42.000-05:00
* Added a gaggle of missing joins in unit tests

* Corrected some CompletableFuture exceptional returns in unit tests

* More missing joins in unit tests.
diff --git a/README.md b/README.md
@@ -18,7 +18,7 @@ For more information jump to a section below.
 
  | Branch | Description | Build Status | Coverage Status |
  |--------|-------------|--------------|-----------------|
- |Main | Preview 8 Builds | [![Build Status](https://travis-ci.org/Microsoft/botbuilder-java.svg?branch=main)](https://travis-ci.org/Microsoft/botbuilder-java) | [![Coverage Status](https://coveralls.io/repos/github/microsoft/botbuilder-java/badge.svg?branch=823847c676b7dbb0fa348a308297ae375f5141ef)](https://coveralls.io/github/microsoft/botbuilder-java?branch=823847c676b7dbb0fa348a308297ae375f5141ef) |
+ |Main | Preview 8 Builds | [![Build Status](https://fuselabs.visualstudio.com/SDK_v4/_apis/build/status/Java/BotBuilder-Java-4.0-daily?branchName=main)](https://fuselabs.visualstudio.com/SDK_v4/_build/latest?definitionId=1202&branchName=main) | [![Coverage Status](https://coveralls.io/repos/github/microsoft/botbuilder-java/badge.svg?branch=823847c676b7dbb0fa348a308297ae375f5141ef)](https://coveralls.io/github/microsoft/botbuilder-java?branch=823847c676b7dbb0fa348a308297ae375f5141ef) |
 
 ## Getting Started
 To get started building bots using the SDK, see the [Azure Bot Service Documentation](https://docs.microsoft.com/en-us/azure/bot-service/?view=azure-bot-service-4.0).
diff --git a/libraries/bot-azure/src/test/java/com/microsoft/bot/azure/AzureQueueTests.java b/libraries/bot-azure/src/test/java/com/microsoft/bot/azure/AzureQueueTests.java
@@ -14,6 +14,7 @@
 import com.microsoft.bot.builder.UserState;
 import com.microsoft.bot.builder.adapters.TestAdapter;
 import com.microsoft.bot.builder.adapters.TestFlow;
+import com.microsoft.bot.connector.Async;
 import com.microsoft.bot.dialogs.Dialog;
 import com.microsoft.bot.dialogs.DialogContext;
 import com.microsoft.bot.dialogs.DialogManager;
@@ -167,13 +168,13 @@ public CompletableFuture<DialogTurnResult> beginDialog(DialogContext dc, Object
             try {
                 date = LocalDateTime.parse(dateString);
             } catch (DateTimeParseException ex) {
-                throw new IllegalArgumentException("Date is invalid");
+                return Async.completeExceptionally(new IllegalArgumentException("Date is invalid"));
             }
 
             ZonedDateTime zonedDate = date.atZone(ZoneOffset.UTC);
             ZonedDateTime now = LocalDateTime.now().atZone(ZoneOffset.UTC);
             if (zonedDate.isBefore(now)) {
-                throw new IllegalArgumentException("Date must be in the future");
+                return Async.completeExceptionally(new IllegalArgumentException("Date must be in the future"));
             }
 
             // create ContinuationActivity from the conversation reference.
@@ -185,7 +186,7 @@ public CompletableFuture<DialogTurnResult> beginDialog(DialogContext dc, Object
 
             QueueStorage queueStorage = dc.getContext().getTurnState().get("QueueStorage");
             if (queueStorage == null) {
-                throw new NullPointerException("Unable to locate QueueStorage in HostContext");
+                return Async.completeExceptionally(new NullPointerException("Unable to locate QueueStorage in HostContext"));
             }
             return queueStorage.queueActivity(activity, visibility, ttl).thenCompose(receipt -> {
                 // return the receipt as the result
diff --git a/libraries/bot-azure/src/test/java/com/microsoft/bot/azure/TranscriptStoreTests.java b/libraries/bot-azure/src/test/java/com/microsoft/bot/azure/TranscriptStoreTests.java
@@ -14,6 +14,7 @@
 import com.microsoft.bot.builder.TranscriptStore;
 import com.microsoft.bot.builder.adapters.TestAdapter;
 import com.microsoft.bot.builder.adapters.TestFlow;
+import com.microsoft.bot.connector.Async;
 import com.microsoft.bot.schema.Activity;
 import com.microsoft.bot.schema.ActivityTypes;
 import com.microsoft.bot.schema.ChannelAccount;
@@ -536,7 +537,7 @@ private CompletableFuture<PagedResult<Activity>> getPagedResult(ConversationRefe
         }
 
         if(pagedResult == null) {
-            throw new TimeoutException("Unable to retrieve pagedResult in time");
+            return Async.completeExceptionally(new TimeoutException("Unable to retrieve pagedResult in time"));
         }
 
         return CompletableFuture.completedFuture(pagedResult);
diff --git a/libraries/bot-builder/src/test/java/com/microsoft/bot/builder/ActivityHandlerTests.java b/libraries/bot-builder/src/test/java/com/microsoft/bot/builder/ActivityHandlerTests.java
@@ -3,6 +3,7 @@
 
 package com.microsoft.bot.builder;
 
+import com.microsoft.bot.connector.Async;
 import com.microsoft.bot.schema.*;
 import org.junit.Assert;
 import org.junit.Test;
@@ -467,23 +468,23 @@ public CompletableFuture<ResourceResponse[]> sendActivities(
             TurnContext context,
             List<Activity> activities
         ) {
-            throw new RuntimeException();
+            return Async.completeExceptionally(new RuntimeException());
         }
 
         @Override
         public CompletableFuture<ResourceResponse> updateActivity(
             TurnContext context,
             Activity activity
         ) {
-            throw new RuntimeException();
+            return Async.completeExceptionally(new RuntimeException());
         }
 
         @Override
         public CompletableFuture<Void> deleteActivity(
             TurnContext context,
             ConversationReference reference
         ) {
-            throw new RuntimeException();
+            return Async.completeExceptionally(new RuntimeException());
         }
     }
 
diff --git a/libraries/bot-builder/src/test/java/com/microsoft/bot/builder/BotStateTests.java b/libraries/bot-builder/src/test/java/com/microsoft/bot/builder/BotStateTests.java
@@ -73,7 +73,7 @@ public CompletableFuture<Void> delete(String[] keys) {
         Assert.assertEquals(1, readCount[0]);
         Assert.assertEquals(0, storeCount[0]);
 
-        propertyA.set(context, "there");
+        propertyA.set(context, "there").join();
         Assert.assertEquals(0, storeCount[0]); // Set on property should not bump
 
         userState.saveChanges(context).join();
diff --git a/libraries/bot-builder/src/test/java/com/microsoft/bot/builder/MessageFactoryTests.java b/libraries/bot-builder/src/test/java/com/microsoft/bot/builder/MessageFactoryTests.java
@@ -545,7 +545,7 @@ public void ValidateIMBackWithNoTest() {
                     null
                 );
 
-                turnContext.sendActivity(activity);
+                turnContext.sendActivity(activity).join();
             }
             return CompletableFuture.completedFuture(null);
         };
diff --git a/libraries/bot-builder/src/test/java/com/microsoft/bot/builder/OnTurnErrorTests.java b/libraries/bot-builder/src/test/java/com/microsoft/bot/builder/OnTurnErrorTests.java
@@ -29,7 +29,7 @@ public void OnTurnError_Test() {
 
         new TestFlow(adapter, (turnContext -> {
             if (StringUtils.equals(turnContext.getActivity().getText(), "foo")) {
-                turnContext.sendActivity(turnContext.getActivity().getText());
+                turnContext.sendActivity(turnContext.getActivity().getText()).join();
             }
 
             if (
diff --git a/libraries/bot-builder/src/test/java/com/microsoft/bot/builder/SkillConversationIdFactoryTests.java b/libraries/bot-builder/src/test/java/com/microsoft/bot/builder/SkillConversationIdFactoryTests.java
@@ -51,7 +51,7 @@ public void SkillConversationIdFactoryHappyPath() {
              skillConversationIdFactory.getSkillConversationReference(skillConversationId).join();
 
         // Delete
-         skillConversationIdFactory.deleteConversationReference(skillConversationId);
+         skillConversationIdFactory.deleteConversationReference(skillConversationId).join();
 
         // Retrieve again
         SkillConversationReference deletedConversationReference =
diff --git a/libraries/bot-builder/src/test/java/com/microsoft/bot/builder/TestAdapterTests.java b/libraries/bot-builder/src/test/java/com/microsoft/bot/builder/TestAdapterTests.java
@@ -5,6 +5,7 @@
 
 import com.microsoft.bot.builder.adapters.TestAdapter;
 import com.microsoft.bot.builder.adapters.TestFlow;
+import com.microsoft.bot.connector.Async;
 import com.microsoft.bot.schema.ActionTypes;
 import com.microsoft.bot.schema.Activity;
 import com.microsoft.bot.schema.ActivityTypes;
@@ -71,7 +72,7 @@ public void TestAdapter_ExceptionInBotOnReceive() {
         try {
 
             new TestFlow(adapter, turnContext -> {
-                throw new RuntimeException(uniqueExceptionId);
+                return Async.completeExceptionally(new RuntimeException(uniqueExceptionId));
             }).test("foo", activity -> {
                 Assert.assertNull(activity);
             }).startTest().join();
diff --git a/libraries/bot-builder/src/test/java/com/microsoft/bot/builder/TurnContextTests.java b/libraries/bot-builder/src/test/java/com/microsoft/bot/builder/TurnContextTests.java
@@ -5,6 +5,7 @@
 
 import com.microsoft.bot.builder.adapters.TestAdapter;
 import com.microsoft.bot.builder.adapters.TestFlow;
+import com.microsoft.bot.connector.Async;
 import com.microsoft.bot.connector.Attachments;
 import com.microsoft.bot.connector.ConnectorClient;
 import com.microsoft.bot.connector.Conversations;
@@ -63,7 +64,7 @@ public void CacheValueUsingSetAndGet() {
 
                 case "TestResponded":
                     if (turnContext.getResponded()) {
-                        throw new RuntimeException("Responded is true");
+                        return Async.completeExceptionally(new RuntimeException("Responded is true"));
                     }
 
                     return turnContext.sendActivity(
@@ -419,7 +420,7 @@ public void DeleteOneActivityToAdapter() {
 
         TurnContext c = new TurnContextImpl(a, TestMessage.Message());
 
-        c.deleteActivity("12345");
+        c.deleteActivity("12345").join();
         Assert.assertTrue(activityDeleted[0]);
     }
 
@@ -440,7 +441,7 @@ public void DeleteConversationReferenceToAdapter() {
             }
         };
 
-        c.deleteActivity(reference);
+        c.deleteActivity(reference).join();
         Assert.assertTrue(activityDeleted[0]);
     }
 
diff --git a/libraries/bot-builder/src/test/java/com/microsoft/bot/builder/teams/TeamsActivityHandlerHidingTests.java b/libraries/bot-builder/src/test/java/com/microsoft/bot/builder/teams/TeamsActivityHandlerHidingTests.java
@@ -8,6 +8,7 @@
 import com.microsoft.bot.builder.MessageFactory;
 import com.microsoft.bot.builder.TurnContext;
 import com.microsoft.bot.builder.TurnContextImpl;
+import com.microsoft.bot.connector.Async;
 import com.microsoft.bot.schema.Activity;
 import com.microsoft.bot.schema.ActivityTypes;
 import com.microsoft.bot.schema.ChannelAccount;
@@ -346,23 +347,23 @@ public CompletableFuture<ResourceResponse[]> sendActivities(
             TurnContext context,
             List<Activity> activities
         ) {
-            throw new RuntimeException();
+            return Async.completeExceptionally(new RuntimeException());
         }
 
         @Override
         public CompletableFuture<ResourceResponse> updateActivity(
             TurnContext context,
             Activity activity
         ) {
-            throw new RuntimeException();
+            return Async.completeExceptionally(new RuntimeException());
         }
 
         @Override
         public CompletableFuture<Void> deleteActivity(
             TurnContext context,
             ConversationReference reference
         ) {
-            throw new RuntimeException();
+            return Async.completeExceptionally(new RuntimeException());
         }
     }
 
diff --git a/libraries/bot-dialogs/src/test/java/com/microsoft/bot/dialogs/PromptValidatorContextTests.java b/libraries/bot-dialogs/src/test/java/com/microsoft/bot/dialogs/PromptValidatorContextTests.java
@@ -107,7 +107,7 @@ public void PromptValidatorContextRetryEnd() {
                     return CompletableFuture.completedFuture(true);
                 } else {
                      promptContext.getContext().sendActivity(
-                         MessageFactory.text("Please send a name that is longer than 3 characters."));
+                         MessageFactory.text("Please send a name that is longer than 3 characters.")).join();
                 }
 
                 return CompletableFuture.completedFuture(false);
diff --git a/libraries/bot-dialogs/src/test/java/com/microsoft/bot/dialogs/SkillDialogTests.java b/libraries/bot-dialogs/src/test/java/com/microsoft/bot/dialogs/SkillDialogTests.java
@@ -352,7 +352,7 @@ public void ShouldThrowHttpExceptionOnPostFailure() {
                                         conversationState);
 
         // Send something to the dialog
-        Assert.assertThrows(Exception.class, () -> client.sendActivity("irrelevant"));
+        Assert.assertThrows(Exception.class, () -> client.sendActivity("irrelevant").join());
     }
 
     @Test
@@ -548,7 +548,7 @@ public void EndOfConversationFromExpectRepliesCallsDeleteConversationReference()
             conversationState);
 
         // Send something to the dialog to start it
-        client.sendActivity("hello");
+        client.sendActivity("hello").join();
 
         SimpleConversationIdFactory factory = null;
         if (dialogOptions.getConversationIdFactory() != null
diff --git a/libraries/bot-dialogs/src/test/java/com/microsoft/bot/dialogs/WaterfallTests.java b/libraries/bot-dialogs/src/test/java/com/microsoft/bot/dialogs/WaterfallTests.java
@@ -70,13 +70,13 @@ public void Waterfall() {
         DialogSet dialogs = new DialogSet(dialogState);
         WaterfallStep[] steps = new WaterfallStep[]
             {(step) -> {
-                step.getContext().sendActivity("step1");
+                step.getContext().sendActivity("step1").join();
                 return CompletableFuture.completedFuture(Dialog.END_OF_TURN);
             }, (step) -> {
-                step.getContext().sendActivity("step2");
+                step.getContext().sendActivity("step2").join();
                 return CompletableFuture.completedFuture(Dialog.END_OF_TURN);
             }, (step) -> {
-                step.getContext().sendActivity("step3");
+                step.getContext().sendActivity("step3").join();
                 return CompletableFuture.completedFuture(Dialog.END_OF_TURN);
             },
         };
@@ -140,13 +140,13 @@ public void WaterfallWithCallback() {
         StatePropertyAccessor<DialogState> dialogState = convoState.createProperty("dialogState");
         DialogSet dialogs = new DialogSet(dialogState);
         WaterfallStep[] steps = new WaterfallStep[] {(step) -> {
-            step.getContext().sendActivity("step1");
+            step.getContext().sendActivity("step1").join();
             return CompletableFuture.completedFuture(Dialog.END_OF_TURN);
         }, (step) -> {
-            step.getContext().sendActivity("step2");
+            step.getContext().sendActivity("step2").join();
             return CompletableFuture.completedFuture(Dialog.END_OF_TURN);
         }, (step) -> {
-            step.getContext().sendActivity("step3");
+            step.getContext().sendActivity("step3").join();
             return CompletableFuture.completedFuture(Dialog.END_OF_TURN);
         }, };
         WaterfallDialog waterfallDialog = new WaterfallDialog("test", Arrays.asList(steps));
@@ -375,7 +375,7 @@ private WaterfallDialog Create_Waterfall2() {
     private class Waterfall2_Step1 implements WaterfallStep {
         @Override
         public CompletableFuture<DialogTurnResult> waterfallStep(WaterfallStepContext stepContext) {
-            stepContext.getContext().sendActivity("step1");
+            stepContext.getContext().sendActivity("step1").join();
             PromptOptions options = new PromptOptions();
             options.setPrompt(MessageFactory.text("Enter a number."));
             options.setRetryPrompt(MessageFactory.text("It must be a number"));
@@ -388,10 +388,10 @@ private class Waterfall2_Step2 implements WaterfallStep {
         public CompletableFuture<DialogTurnResult> waterfallStep(WaterfallStepContext stepContext) {
             if (stepContext.getValues() != null) {
                 int numberResult = (int) stepContext.getResult();
-                stepContext.getContext().sendActivity(String.format("Thanks for '%d'", numberResult));
+                stepContext.getContext().sendActivity(String.format("Thanks for '%d'", numberResult)).join();
             }
 
-            stepContext.getContext().sendActivity("step2");
+            stepContext.getContext().sendActivity("step2").join();
             PromptOptions options = new PromptOptions();
             options.setPrompt(MessageFactory.text("Enter a number."));
             options.setRetryPrompt(MessageFactory.text("It must be a number"));
@@ -404,10 +404,10 @@ private class Waterfall2_Step3 implements WaterfallStep {
         public CompletableFuture<DialogTurnResult> waterfallStep(WaterfallStepContext stepContext) {
             if (stepContext.getValues() != null) {
                 int numberResult = (int) stepContext.getResult();
-                stepContext.getContext().sendActivity(String.format("Thanks for '%d'", numberResult));
+                stepContext.getContext().sendActivity(String.format("Thanks for '%d'", numberResult)).join();
             }
 
-            stepContext.getContext().sendActivity("step3");
+            stepContext.getContext().sendActivity("step3").join();
             Map<String, Object> resultMap = new HashMap<String, Object>();
             resultMap.put("Value", "All Done!");
             return  stepContext.endDialog(resultMap);
@@ -416,47 +416,47 @@ public CompletableFuture<DialogTurnResult> waterfallStep(WaterfallStepContext st
     private class Waterfall3_Step1 implements WaterfallStep {
         @Override
         public CompletableFuture<DialogTurnResult> waterfallStep(WaterfallStepContext stepContext) {
-            stepContext.getContext().sendActivity(MessageFactory.text("step1"));
+            stepContext.getContext().sendActivity(MessageFactory.text("step1")).join();
             return stepContext.beginDialog("test-waterfall-b", null);
         }
     }
 
     private class Waterfall3_Step2 implements WaterfallStep {
         @Override
         public CompletableFuture<DialogTurnResult> waterfallStep(WaterfallStepContext stepContext) {
-            stepContext.getContext().sendActivity(MessageFactory.text("step2"));
+            stepContext.getContext().sendActivity(MessageFactory.text("step2")).join();
             return stepContext.beginDialog("test-waterfall-c", null);
         }
     }
 
     private class Waterfall4_Step1 implements WaterfallStep {
         @Override
         public CompletableFuture<DialogTurnResult> waterfallStep(WaterfallStepContext stepContext) {
-            stepContext.getContext().sendActivity(MessageFactory.text("step1.1"));
+            stepContext.getContext().sendActivity(MessageFactory.text("step1.1")).join();
             return CompletableFuture.completedFuture(Dialog.END_OF_TURN);
         }
     }
 
     private class Waterfall4_Step2 implements WaterfallStep {
         @Override
         public CompletableFuture<DialogTurnResult> waterfallStep(WaterfallStepContext stepContext) {
-            stepContext.getContext().sendActivity(MessageFactory.text("step1.2"));
+            stepContext.getContext().sendActivity(MessageFactory.text("step1.2")).join();
             return CompletableFuture.completedFuture(Dialog.END_OF_TURN);
         }
     }
 
     private class Waterfall5_Step1 implements WaterfallStep {
         @Override
         public CompletableFuture<DialogTurnResult> waterfallStep(WaterfallStepContext stepContext) {
-            stepContext.getContext().sendActivity(MessageFactory.text("step2.1"));
+            stepContext.getContext().sendActivity(MessageFactory.text("step2.1")).join();
             return CompletableFuture.completedFuture(Dialog.END_OF_TURN);
         }
     }
 
     private class Waterfall5_Step2 implements WaterfallStep {
         @Override
         public CompletableFuture<DialogTurnResult> waterfallStep(WaterfallStepContext stepContext) {
-            stepContext.getContext().sendActivity(MessageFactory.text("step2.2"));
+            stepContext.getContext().sendActivity(MessageFactory.text("step2.2")).join();
             return  stepContext.endDialog();
             }
     }
diff --git a/libraries/bot-dialogs/src/test/java/com/microsoft/bot/dialogs/prompts/ChoicePromptTests.java b/libraries/bot-dialogs/src/test/java/com/microsoft/bot/dialogs/prompts/ChoicePromptTests.java
@@ -536,7 +536,7 @@ public void ShouldCallCustomValidator() {
         DialogSet dialogs = new DialogSet(dialogState);
 
         PromptValidator<FoundChoice> validator =  (promptContext) -> {
-            promptContext.getContext().sendActivity(MessageFactory.text("validator called"));
+            promptContext.getContext().sendActivity(MessageFactory.text("validator called")).join();
            return CompletableFuture.completedFuture(true);
        };
 
diff --git a/libraries/bot-dialogs/src/test/java/com/microsoft/bot/dialogs/prompts/NumberPromptTests.java b/libraries/bot-dialogs/src/test/java/com/microsoft/bot/dialogs/prompts/NumberPromptTests.java
diff --git a/libraries/bot-dialogs/src/test/java/com/microsoft/bot/dialogs/prompts/OAuthPromptTests.java b/libraries/bot-dialogs/src/test/java/com/microsoft/bot/dialogs/prompts/OAuthPromptTests.java
diff --git a/libraries/bot-dialogs/src/test/java/com/microsoft/bot/dialogs/prompts/TextPromptTests.java b/libraries/bot-dialogs/src/test/java/com/microsoft/bot/dialogs/prompts/TextPromptTests.java

Original file line number	Diff line number	Diff line change
`@@ -14,6 +14,7 @@`
`14`	`14`	`import com.microsoft.bot.builder.TranscriptStore;`
`15`	`15`	`import com.microsoft.bot.builder.adapters.TestAdapter;`
`16`	`16`	`import com.microsoft.bot.builder.adapters.TestFlow;`
	`17`	`+import com.microsoft.bot.connector.Async;`
`17`	`18`	`import com.microsoft.bot.schema.Activity;`
`18`	`19`	`import com.microsoft.bot.schema.ActivityTypes;`
`19`	`20`	`import com.microsoft.bot.schema.ChannelAccount;`
`@@ -536,7 +537,7 @@ private CompletableFuture<PagedResult<Activity>> getPagedResult(ConversationRefe`
`536`	`537`	`}`
`537`	`538`
`538`	`539`	`if(pagedResult == null) {`
`539`		`- throw new TimeoutException("Unable to retrieve pagedResult in time");`
	`540`	`+ return Async.completeExceptionally(new TimeoutException("Unable to retrieve pagedResult in time"));`
`540`	`541`	`}`
`541`	`542`
`542`	`543`	`return CompletableFuture.completedFuture(pagedResult);`
Original file line number	Diff line number	Diff line change
`@@ -545,7 +545,7 @@ public void ValidateIMBackWithNoTest() {`
`545`	`545`	`null`
`546`	`546`	`);`
`547`	`547`
`548`		`- turnContext.sendActivity(activity);`
	`548`	`+ turnContext.sendActivity(activity).join();`
`549`	`549`	`}`
`550`	`550`	`return CompletableFuture.completedFuture(null);`
`551`	`551`	`};`
Original file line number	Diff line number	Diff line change
`@@ -29,7 +29,7 @@ public void OnTurnError_Test() {`
`29`	`29`
`30`	`30`	`new TestFlow(adapter, (turnContext -> {`
`31`	`31`	`if (StringUtils.equals(turnContext.getActivity().getText(), "foo")) {`
`32`		`- turnContext.sendActivity(turnContext.getActivity().getText());`
	`32`	`+ turnContext.sendActivity(turnContext.getActivity().getText()).join();`
`33`	`33`	`}`
`34`	`34`
`35`	`35`	`if (`
Original file line number	Diff line number	Diff line change
`@@ -5,6 +5,7 @@`
`5`	`5`
`6`	`6`	`import com.microsoft.bot.builder.adapters.TestAdapter;`
`7`	`7`	`import com.microsoft.bot.builder.adapters.TestFlow;`
	`8`	`+import com.microsoft.bot.connector.Async;`
`8`	`9`	`import com.microsoft.bot.connector.Attachments;`
`9`	`10`	`import com.microsoft.bot.connector.ConnectorClient;`
`10`	`11`	`import com.microsoft.bot.connector.Conversations;`
`@@ -63,7 +64,7 @@ public void CacheValueUsingSetAndGet() {`
`63`	`64`
`64`	`65`	`case "TestResponded":`
`65`	`66`	`if (turnContext.getResponded()) {`
`66`		`- throw new RuntimeException("Responded is true");`
	`67`	`+ return Async.completeExceptionally(new RuntimeException("Responded is true"));`
`67`	`68`	`}`
`68`	`69`
`69`	`70`	`return turnContext.sendActivity(`
`@@ -419,7 +420,7 @@ public void DeleteOneActivityToAdapter() {`
`419`	`420`
`420`	`421`	`TurnContext c = new TurnContextImpl(a, TestMessage.Message());`
`421`	`422`
`422`		`- c.deleteActivity("12345");`
	`423`	`+ c.deleteActivity("12345").join();`
`423`	`424`	`Assert.assertTrue(activityDeleted[0]);`
`424`	`425`	`}`
`425`	`426`
`@@ -440,7 +441,7 @@ public void DeleteConversationReferenceToAdapter() {`
`440`	`441`	`}`
`441`	`442`	`};`
`442`	`443`
`443`		`- c.deleteActivity(reference);`
	`444`	`+ c.deleteActivity(reference).join();`
`444`	`445`	`Assert.assertTrue(activityDeleted[0]);`
`445`	`446`	`}`
`446`	`447`