From 2f50944c0ed4236bd6c6cb9f3e306d5085ad8414 Mon Sep 17 00:00:00 2001 From: Ryan Lengel Isgrig Date: Thu, 3 Jun 2021 21:01:30 -0700 Subject: [PATCH 1/8] Rename and update bug report --- .github/ISSUE_TEMPLATE/-net-sdk-bug.md | 27 -------------- .../ISSUE_TEMPLATE/components-bug-report.md | 36 +++++++++++++++++++ 2 files changed, 36 insertions(+), 27 deletions(-) delete mode 100644 .github/ISSUE_TEMPLATE/-net-sdk-bug.md create mode 100644 .github/ISSUE_TEMPLATE/components-bug-report.md diff --git a/.github/ISSUE_TEMPLATE/-net-sdk-bug.md b/.github/ISSUE_TEMPLATE/-net-sdk-bug.md deleted file mode 100644 index eaefeb99f1..0000000000 --- a/.github/ISSUE_TEMPLATE/-net-sdk-bug.md +++ /dev/null @@ -1,27 +0,0 @@ ---- -name: "Bug" -about: Create a bug report for a bug you found in the Bot Framework Skills projects -title: "" -labels: "needs-triage, bug" -assignees: "" ---- - -### [Github issues](https://github.com/Microsoft/botframework-skills/issues) should be used for bugs and feature requests. Use [Stack Overflow](https://stackoverflow.com/questions/tagged/botframework) for general "how-to" questions. - -## Version -What package version of the SDK are you using. - -## Describe the bug -Give a clear and concise description of what the bug is. - -## To Reproduce -Steps to reproduce the behavior: - -## Expected behavior -Give a clear and concise description of what you expected to happen. - -## Screenshots -If applicable, add screenshots to help explain your problem. - -## Additional context -Add any other context about the problem here. diff --git a/.github/ISSUE_TEMPLATE/components-bug-report.md b/.github/ISSUE_TEMPLATE/components-bug-report.md new file mode 100644 index 0000000000..391df25f7c --- /dev/null +++ b/.github/ISSUE_TEMPLATE/components-bug-report.md @@ -0,0 +1,36 @@ +--- +name: "Bug" +about: Create a report for a bug you found in the Bot Framework Components projects (including documentation) +title: "" +labels: "needs-triage, bug" +assignees: "" +--- + + + +## Describe the bug + + + +## Version + + + + + +## To Reproduce + + + +## Expected behavior + + + +## Screenshots + + + +## Additional context + + From 9cf304b611c61adb2e9471bb933391068ab4935f Mon Sep 17 00:00:00 2001 From: Ryan Lengel Isgrig Date: Thu, 3 Jun 2021 21:02:06 -0700 Subject: [PATCH 2/8] Remove docs bug report (covered in bug report) --- .github/ISSUE_TEMPLATE/docs-bug-report.md | 9 --------- 1 file changed, 9 deletions(-) delete mode 100644 .github/ISSUE_TEMPLATE/docs-bug-report.md diff --git a/.github/ISSUE_TEMPLATE/docs-bug-report.md b/.github/ISSUE_TEMPLATE/docs-bug-report.md deleted file mode 100644 index a7fca37239..0000000000 --- a/.github/ISSUE_TEMPLATE/docs-bug-report.md +++ /dev/null @@ -1,9 +0,0 @@ ---- -name: "Documentation Issue" -about: Create a report to help us improve our documentation -labels: "needs-triage, Area: Docs" ---- - -**Please describe your request** - -**Is this an issue with current documentation? If yes, please provide the link.** From a8f0601912793494a6e0f1bb25d044243c05bb66 Mon Sep 17 00:00:00 2001 From: Ryan Lengel Isgrig Date: Thu, 3 Jun 2021 21:03:15 -0700 Subject: [PATCH 3/8] remove calendar v2 bug --- .../ISSUE_TEMPLATE/calendar-skill-v2-bug.md | 22 ------------------- 1 file changed, 22 deletions(-) delete mode 100644 .github/ISSUE_TEMPLATE/calendar-skill-v2-bug.md diff --git a/.github/ISSUE_TEMPLATE/calendar-skill-v2-bug.md b/.github/ISSUE_TEMPLATE/calendar-skill-v2-bug.md deleted file mode 100644 index 8f3f7566d1..0000000000 --- a/.github/ISSUE_TEMPLATE/calendar-skill-v2-bug.md +++ /dev/null @@ -1,22 +0,0 @@ ---- -name: "Calendar Skill V2 Bug" -about: Create a bug report for a bug you found during Calendar Skill V2 testing -title: "[Calendar Skill V2] " -labels: "needs-triage, bug, Area: Calendar Skill" -assignees: "" ---- - -## Describe the bug -Give a clear and concise description of what the bug is. - -## To Reproduce -Steps to reproduce the behavior. What utterances or buttons didn't work? - -## Expected behavior -Give a clear and concise description of what you expected to happen. - -## Screenshots -If applicable, add screenshots to help explain your problem. - -## Additional context -Add any other context about the problem here. From 9cb623bba0a3de5ba44361e4936d111020a9bb35 Mon Sep 17 00:00:00 2001 From: Ryan Lengel Isgrig Date: Thu, 3 Jun 2021 21:19:01 -0700 Subject: [PATCH 4/8] Update pbx feature spec --- ...md => conversational-experiences-feature-spec.md} | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) rename .github/ISSUE_TEMPLATE/{feature-spec.md => conversational-experiences-feature-spec.md} (77%) diff --git a/.github/ISSUE_TEMPLATE/feature-spec.md b/.github/ISSUE_TEMPLATE/conversational-experiences-feature-spec.md similarity index 77% rename from .github/ISSUE_TEMPLATE/feature-spec.md rename to .github/ISSUE_TEMPLATE/conversational-experiences-feature-spec.md index 3116722960..a2d45872fd 100644 --- a/.github/ISSUE_TEMPLATE/feature-spec.md +++ b/.github/ISSUE_TEMPLATE/conversational-experiences-feature-spec.md @@ -1,8 +1,8 @@ --- name: "Feature spec" -about: Detailed feature definition. +about: Detailed feature definition for conversational experiences. title: "" -labels: "" +labels: "Owner: PBX" assignees: "" --- @@ -14,22 +14,22 @@ assignees: "" ## Description ## Conversation Design -Links to conversation design diagrams and documents + ## Language Understanding | Intent | Sample Utterances | Prebuilt Entities | Custom Entities | Patterns | | ------ | ----------------------| ----------------- | ----------------- | --------- | ## Dialogs -Describe the different dialogs to be created as part of the feature and what each will do + ## Custom Actions -Describe any custom actions that will need to be created to support the feature + | Name | Input | Output | Notes | | ------ | ------ | -------- | ------- | ## Channels -Describe any channel specific functionality or limitations that will need to be taken into consideration + ## Acceptance Criteria - [ ] Flow should work in both Direct mode (connecting to the skill bot directly From f4e8da4f037c436578e169d3214f5e3548cfc994 Mon Sep 17 00:00:00 2001 From: Ryan Lengel Isgrig Date: Thu, 3 Jun 2021 21:30:23 -0700 Subject: [PATCH 5/8] Remove question issue and add to config yml --- .github/ISSUE_TEMPLATE/-net-sdk-question.md | 11 ----------- .github/ISSUE_TEMPLATE/config.yml | 5 +++++ 2 files changed, 5 insertions(+), 11 deletions(-) delete mode 100644 .github/ISSUE_TEMPLATE/-net-sdk-question.md create mode 100644 .github/ISSUE_TEMPLATE/config.yml diff --git a/.github/ISSUE_TEMPLATE/-net-sdk-question.md b/.github/ISSUE_TEMPLATE/-net-sdk-question.md deleted file mode 100644 index 58c7985686..0000000000 --- a/.github/ISSUE_TEMPLATE/-net-sdk-question.md +++ /dev/null @@ -1,11 +0,0 @@ ---- -name: "Question" -about: The issue tracker is not for questions. Please ask questions on https://stackoverflow.com/questions/tagged/botframework - ---- - -🚨 The issue tracker is not for questions 🚨 - -If you have a question, please ask it on https://stackoverflow.com/questions/tagged/botframework - -[question] diff --git a/.github/ISSUE_TEMPLATE/config.yml b/.github/ISSUE_TEMPLATE/config.yml new file mode 100644 index 0000000000..346566fb3f --- /dev/null +++ b/.github/ISSUE_TEMPLATE/config.yml @@ -0,0 +1,5 @@ +blank_issues_enabled: false +contact_links: + - name: Stack Overflow + url: https://stackoverflow.com/questions/tagged/botframework + about: Please ask general "how-to" questions here. \ No newline at end of file From f4f88a86424a8ee4c78995e56f796e17eb1df525 Mon Sep 17 00:00:00 2001 From: Ryan Lengel Isgrig Date: Thu, 3 Jun 2021 21:46:40 -0700 Subject: [PATCH 6/8] Update feature request and add other template for empty issues --- .../-net-sdk-feature-request.md | 21 ---------------- .../components-feature-request.md | 25 +++++++++++++++++++ .github/ISSUE_TEMPLATE/components-other.md | 7 ++++++ 3 files changed, 32 insertions(+), 21 deletions(-) delete mode 100644 .github/ISSUE_TEMPLATE/-net-sdk-feature-request.md create mode 100644 .github/ISSUE_TEMPLATE/components-feature-request.md create mode 100644 .github/ISSUE_TEMPLATE/components-other.md diff --git a/.github/ISSUE_TEMPLATE/-net-sdk-feature-request.md b/.github/ISSUE_TEMPLATE/-net-sdk-feature-request.md deleted file mode 100644 index 136ba70fbb..0000000000 --- a/.github/ISSUE_TEMPLATE/-net-sdk-feature-request.md +++ /dev/null @@ -1,21 +0,0 @@ ---- -name: "Feature request" -about: Suggest a feature for the Bot Framework Skills projects -title: "" -labels: "needs-triage, feature-request" -assignees: "" ---- - -### Use this [query](https://github.com/Microsoft/botbuilder-dotnet/issues?q=is%3Aissue+is%3Aopen++label%3Afeature-request+) to search for the most popular feature requests. - -**Is your feature request related to a problem? Please describe.** -A clear and concise description of what the problem is. Ex. I'm always frustrated when [...] - -**Describe the solution you'd like** -A clear and concise description of what you want to happen. - -**Describe alternatives you've considered** -A clear and concise description of any alternative solutions or features you've considered. - -**Additional context** -Add any other context or screenshots about the feature request here. diff --git a/.github/ISSUE_TEMPLATE/components-feature-request.md b/.github/ISSUE_TEMPLATE/components-feature-request.md new file mode 100644 index 0000000000..1adf30369d --- /dev/null +++ b/.github/ISSUE_TEMPLATE/components-feature-request.md @@ -0,0 +1,25 @@ +--- +name: "Feature request" +about: Suggest a feature for the Bot Framework Components projects +title: "" +labels: "needs-triage, feature-request" +assignees: "" +--- + + + +## Is your feature request related to a problem? Please describe. + + + +## Describe the solution you'd like + + + +## Describe alternatives you've considered + + + +## Additional context + + diff --git a/.github/ISSUE_TEMPLATE/components-other.md b/.github/ISSUE_TEMPLATE/components-other.md new file mode 100644 index 0000000000..26ec17d7b0 --- /dev/null +++ b/.github/ISSUE_TEMPLATE/components-other.md @@ -0,0 +1,7 @@ +--- +name: Other +about: An empty issue template +title: "" +labels: "needs-triage" +assignees: "" +--- From 682f735f8d444ec6641eebc45cd65a2397eab9b9 Mon Sep 17 00:00:00 2001 From: Ryan Lengel Isgrig Date: Fri, 4 Jun 2021 10:07:06 -0700 Subject: [PATCH 7/8] Formatting changes after testing on private repo --- .github/ISSUE_TEMPLATE/components-bug-report.md | 3 +-- .github/ISSUE_TEMPLATE/components-feature-request.md | 4 ++-- .github/ISSUE_TEMPLATE/components-other.md | 2 +- .github/ISSUE_TEMPLATE/config.yml | 4 ++-- ...nces-feature-spec.md => prebuilt-experience-user-story.md} | 4 ++-- 5 files changed, 8 insertions(+), 9 deletions(-) rename .github/ISSUE_TEMPLATE/{conversational-experiences-feature-spec.md => prebuilt-experience-user-story.md} (95%) diff --git a/.github/ISSUE_TEMPLATE/components-bug-report.md b/.github/ISSUE_TEMPLATE/components-bug-report.md index 391df25f7c..ba82285f25 100644 --- a/.github/ISSUE_TEMPLATE/components-bug-report.md +++ b/.github/ISSUE_TEMPLATE/components-bug-report.md @@ -1,6 +1,6 @@ --- name: "Bug" -about: Create a report for a bug you found in the Bot Framework Components projects (including documentation) +about: Create a report for a bug you found in the Bot Framework Components projects (including documentation). title: "" labels: "needs-triage, bug" assignees: "" @@ -16,7 +16,6 @@ assignees: "" ## Version - ## To Reproduce diff --git a/.github/ISSUE_TEMPLATE/components-feature-request.md b/.github/ISSUE_TEMPLATE/components-feature-request.md index 1adf30369d..c25d90f782 100644 --- a/.github/ISSUE_TEMPLATE/components-feature-request.md +++ b/.github/ISSUE_TEMPLATE/components-feature-request.md @@ -1,6 +1,6 @@ --- -name: "Feature request" -about: Suggest a feature for the Bot Framework Components projects +name: "Feature Request" +about: Suggest an idea a Bot Framework Components project. title: "" labels: "needs-triage, feature-request" assignees: "" diff --git a/.github/ISSUE_TEMPLATE/components-other.md b/.github/ISSUE_TEMPLATE/components-other.md index 26ec17d7b0..981db40f73 100644 --- a/.github/ISSUE_TEMPLATE/components-other.md +++ b/.github/ISSUE_TEMPLATE/components-other.md @@ -1,6 +1,6 @@ --- name: Other -about: An empty issue template +about: An empty issue template. title: "" labels: "needs-triage" assignees: "" diff --git a/.github/ISSUE_TEMPLATE/config.yml b/.github/ISSUE_TEMPLATE/config.yml index 346566fb3f..1064705749 100644 --- a/.github/ISSUE_TEMPLATE/config.yml +++ b/.github/ISSUE_TEMPLATE/config.yml @@ -1,5 +1,5 @@ blank_issues_enabled: false contact_links: - - name: Stack Overflow + - name: Question url: https://stackoverflow.com/questions/tagged/botframework - about: Please ask general "how-to" questions here. \ No newline at end of file + about: The issue tracker is not for questions, please ask general "how-to" questions on Stack Overflow. \ No newline at end of file diff --git a/.github/ISSUE_TEMPLATE/conversational-experiences-feature-spec.md b/.github/ISSUE_TEMPLATE/prebuilt-experience-user-story.md similarity index 95% rename from .github/ISSUE_TEMPLATE/conversational-experiences-feature-spec.md rename to .github/ISSUE_TEMPLATE/prebuilt-experience-user-story.md index a2d45872fd..a06650bcf7 100644 --- a/.github/ISSUE_TEMPLATE/conversational-experiences-feature-spec.md +++ b/.github/ISSUE_TEMPLATE/prebuilt-experience-user-story.md @@ -1,6 +1,6 @@ --- -name: "Feature spec" -about: Detailed feature definition for conversational experiences. +name: "Prebuilt Experiences User Story" +about: Detailed user story spec for prebuilt experiences. title: "" labels: "Owner: PBX" assignees: "" From 179df5cacc773fca08d165642c9e947ac61c7eac Mon Sep 17 00:00:00 2001 From: Ryan Lengel Isgrig Date: Fri, 4 Jun 2021 10:43:30 -0700 Subject: [PATCH 8/8] Clean up pr template --- .github/PULL_REQUEST_TEMPLATE.md | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index f397c0b377..e25a784ea7 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -1,20 +1,20 @@ - + + + + ### Purpose -*What is the context of this pull request? Why is it being done?* + + ### Changes -*Are there any changes that need to be called out as significant or particularly difficult to grasp? (Include illustrative screenshots for context if applicable.)* + + ### Tests -*Is this covered by existing tests or new ones? If no, why not?* + + ### Feature Plan -*Are there any remaining steps or dependencies before this issue can be fully resolved? If so, describe and link to any relevant pull requests or issues.* -### Checklist + -#### General -- [ ] I have commented my code, particularly in hard-to-understand areas -- [ ] I have added or updated the appropriate tests -- [ ] I have updated related documentation