Skip to content

Commit be35aab

Browse files
committed
PR feedback
1 parent 89b6536 commit be35aab

File tree

1 file changed

+10
-10
lines changed

1 file changed

+10
-10
lines changed

strings/base_delegate.h

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -8,22 +8,22 @@ namespace winrt::impl
88

99
template<bool try_marshaling> struct implements_delegate_base
1010
{
11-
WINRT_IMPL_NOINLINE uint32_t inc_ref() noexcept
11+
WINRT_IMPL_NOINLINE uint32_t increment_reference() noexcept
1212
{
1313
return ++m_references;
1414
}
1515

16-
WINRT_IMPL_NOINLINE uint32_t dec_ref() noexcept
16+
WINRT_IMPL_NOINLINE uint32_t decrement_reference() noexcept
1717
{
1818
return --m_references;
1919
}
2020

21-
WINRT_IMPL_NOINLINE uint32_t QueryInterfaceImpl(guid const& id, void** result, unknown_abi* outerAbiPtr, guid const& outerId)
21+
WINRT_IMPL_NOINLINE uint32_t query_interface(guid const& id, void** result, unknown_abi* outerAbiPtr, guid const& outerId)
2222
{
2323
if ((id == outerId) || is_guid_of<Windows::Foundation::IUnknown>(id) || is_guid_of<IAgileObject>(id))
2424
{
2525
*result = outerAbiPtr;
26-
inc_ref();
26+
increment_reference();
2727
return 0;
2828
}
2929

@@ -52,17 +52,17 @@ namespace winrt::impl
5252

5353
int32_t __stdcall QueryInterface(guid const& id, void** result) noexcept final
5454
{
55-
return QueryInterfaceImpl(id, result, static_cast<abi_t<T>*>(this), guid_of<T>());
55+
return query_interface(id, result, static_cast<abi_t<T>*>(this), guid_of<T>());
5656
}
5757

5858
uint32_t __stdcall AddRef() noexcept final
5959
{
60-
return inc_ref();
60+
return increment_reference();
6161
}
6262

6363
uint32_t __stdcall Release() noexcept final
6464
{
65-
auto const remaining = dec_ref();
65+
auto const remaining = decrement_reference();
6666

6767
if (remaining == 0)
6868
{
@@ -138,17 +138,17 @@ namespace winrt::impl
138138

139139
int32_t __stdcall QueryInterface(guid const& id, void** result) noexcept final
140140
{
141-
return QueryInterfaceImpl(id, result, static_cast<unknown_abi*>(this), guid_of<Windows::Foundation::IUnknown>());
141+
return query_interface(id, result, static_cast<unknown_abi*>(this), guid_of<Windows::Foundation::IUnknown>());
142142
}
143143

144144
uint32_t __stdcall AddRef() noexcept final
145145
{
146-
return inc_ref();
146+
return increment_reference();
147147
}
148148

149149
uint32_t __stdcall Release() noexcept final
150150
{
151-
auto const remaining = dec_ref();
151+
auto const remaining = decrement_reference();
152152

153153
if (remaining == 0)
154154
{

0 commit comments

Comments
 (0)