From e81ed5698020aa42d8e696f9e67bf2d27d649029 Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Fri, 5 Apr 2024 13:28:51 -0400 Subject: [PATCH 01/20] spelling: access Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- test/old_tests/UnitTests/make_self.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/old_tests/UnitTests/make_self.cpp b/test/old_tests/UnitTests/make_self.cpp index f7c0b1e3e..6ac17a3c0 100644 --- a/test/old_tests/UnitTests/make_self.cpp +++ b/test/old_tests/UnitTests/make_self.cpp @@ -8,7 +8,7 @@ #endif // -// These tests ensure that the make_self function works as expected to provide direct acccess +// These tests ensure that the make_self function works as expected to provide direct access // to an implementation. // // The IMakeSelf IUnknown interface is also tested as this covers an edge case in the implements From 7e7b7a7ae703981fe80205704397d370dbc6213f Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Fri, 5 Apr 2024 13:41:49 -0400 Subject: [PATCH 02/20] spelling: brackets Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- test/catch.hpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/catch.hpp b/test/catch.hpp index e949ee88c..0e422b7e8 100644 --- a/test/catch.hpp +++ b/test/catch.hpp @@ -11310,7 +11310,7 @@ namespace Catch { std::string TagInfo::all() const { size_t size = 0; for (auto const& spelling : spellings) { - // Add 2 for the brackes + // Add 2 for the brackets size += spelling.size() + 2; } From 35c00671a37ee1bb0c02044ba3ff2959af5656b1 Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Fri, 5 Apr 2024 13:29:18 -0400 Subject: [PATCH 03/20] spelling: compilation Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- test/old_tests/UnitTests/delegate.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/old_tests/UnitTests/delegate.cpp b/test/old_tests/UnitTests/delegate.cpp index ab83a2a65..5951b7bf6 100644 --- a/test/old_tests/UnitTests/delegate.cpp +++ b/test/old_tests/UnitTests/delegate.cpp @@ -680,7 +680,7 @@ TEST_CASE("delegate,MapChangedEventHandler") TEST_CASE("delegate,collection") { // - // Mostly a compiliation test to ensure that we can create collections of delegates. This is a rare corner case that was + // Mostly a compilation test to ensure that we can create collections of delegates. This is a rare corner case that was // previously not working. // From 2871e51d8f57a82536f01aef15ae2c602dbc1a76 Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Fri, 5 Apr 2024 13:29:31 -0400 Subject: [PATCH 04/20] spelling: deterministic Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- test/test/thread_pool.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/test/thread_pool.cpp b/test/test/thread_pool.cpp index ac75dac18..c55cffe1d 100644 --- a/test/test/thread_pool.cpp +++ b/test/test/thread_pool.cpp @@ -53,7 +53,7 @@ TEST_CASE("thread_pool") uint32_t const stable_counter = test(test_iterations, 1, 1); uint32_t const unstable_counter = test(test_iterations, 10, 10); - // This is determinstic since the queue is single-threaded. + // This is deterministic since the queue is single-threaded. REQUIRE(stable_counter == test_iterations); // This is unlikely to fail since the pool is multi-threaded. From e1a4e2d92e896c36f38cbaf70b36e46f83aca681 Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Fri, 5 Apr 2024 13:29:48 -0400 Subject: [PATCH 05/20] spelling: distribution Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- test/catch.hpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/catch.hpp b/test/catch.hpp index 0e422b7e8..d008973a6 100644 --- a/test/catch.hpp +++ b/test/catch.hpp @@ -7779,7 +7779,7 @@ namespace Catch { result = -erfc_inv(2.0 * p); // result *= normal distribution standard deviation (1.0) * sqrt(2) result *= /*sd * */ ROOT_TWO; - // result += normal disttribution mean (0) + // result += normal distribution mean (0) return result; } From 5611f06f19a1f279d0316253273eef8e2dae8e34 Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Fri, 5 Apr 2024 13:44:03 -0400 Subject: [PATCH 06/20] spelling: exercising Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- test/old_tests/UnitTests/struct.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/old_tests/UnitTests/struct.cpp b/test/old_tests/UnitTests/struct.cpp index bce62e25d..347e1090e 100644 --- a/test/old_tests/UnitTests/struct.cpp +++ b/test/old_tests/UnitTests/struct.cpp @@ -10,7 +10,7 @@ using namespace Windows::Web::Http; // // This first test ensures that structures with HSTRING fields are projected correctly. // In this case, a suitable interface is provided by the Windows SDK to simplify testing. -// IControlTemplate provides the necessary methods for excercising input and output +// IControlTemplate provides the necessary methods for exercising input and output // patterns for code generation. // From 49fd8d9a00672a3054a71809631e213c94ea7aea Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Fri, 5 Apr 2024 13:44:24 -0400 Subject: [PATCH 07/20] spelling: from Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- cross-mingw-toolchain.cmake | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cross-mingw-toolchain.cmake b/cross-mingw-toolchain.cmake index d58bb278d..23156e11b 100644 --- a/cross-mingw-toolchain.cmake +++ b/cross-mingw-toolchain.cmake @@ -1,5 +1,5 @@ # This is a cmake-toolchain(5) file that can be used to cross-build -# cppwinrt.exe fron Linux or other operating systems using a mingw-w64 cross +# cppwinrt.exe from Linux or other operating systems using a mingw-w64 cross # toolchain. This should work with both GCC-based and llvm-mingw toolchains. # # Example usage with external toolchain: From 4585c09cdc063f86db470844987b15c101d41397 Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Fri, 5 Apr 2024 13:34:42 -0400 Subject: [PATCH 08/20] spelling: implementation Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- nuget/readme.md | 2 +- test/old_tests/UnitTests/abi_guard.cpp | 12 ++++++------ test/test/abi_guard.cpp | 12 ++++++------ 3 files changed, 13 insertions(+), 13 deletions(-) diff --git a/nuget/readme.md b/nuget/readme.md index 991fd2768..862d8c645 100644 --- a/nuget/readme.md +++ b/nuget/readme.md @@ -114,7 +114,7 @@ void MyComponent::InitializeComponent() ***[Windows|Microsoft]::UI::Xaml::Markup::ComponentConnectorT*** -A consequence of calling InitializeComponent outside construction is that Xaml runtime callbacks to IComponentConnector::Connect and IComponentConnector2::GetBindingConnector are now dispatched to the most derived implementations. Previously, these calls were dispatched directly to the class under construction, as the vtable had yet to be initialized. For objects with markup that derive from composable base classes with markup, this is a breaking change. Derived classes must now implement IComponentConnector::Connect and IComponentConnector2::GetBindingConnector by explicitly calling into the base class. The ComponentConnectorT template provides a correct implemenation for these interfaces: +A consequence of calling InitializeComponent outside construction is that Xaml runtime callbacks to IComponentConnector::Connect and IComponentConnector2::GetBindingConnector are now dispatched to the most derived implementations. Previously, these calls were dispatched directly to the class under construction, as the vtable had yet to be initialized. For objects with markup that derive from composable base classes with markup, this is a breaking change. Derived classes must now implement IComponentConnector::Connect and IComponentConnector2::GetBindingConnector by explicitly calling into the base class. The ComponentConnectorT template provides a correct implementation for these interfaces: ```cpp struct DerivedPage : winrt::Windows::UI::Xaml::Markup::ComponentConnectorT> diff --git a/test/old_tests/UnitTests/abi_guard.cpp b/test/old_tests/UnitTests/abi_guard.cpp index 3108baf62..f9ee1fdde 100644 --- a/test/old_tests/UnitTests/abi_guard.cpp +++ b/test/old_tests/UnitTests/abi_guard.cpp @@ -12,7 +12,7 @@ using namespace Windows::Foundation; namespace { // - // This implemenetation uses the simplest abi_enter and abi_exit methods. + // This implementation uses the simplest abi_enter and abi_exit methods. // struct A : implements { @@ -60,7 +60,7 @@ namespace } // - // This implemenetation uses the abi_enter but omits the abi_exit method. + // This implementation uses the abi_enter but omits the abi_exit method. // struct B : implements { @@ -102,7 +102,7 @@ namespace } // - // This implemenetation throws from the abi_enter method. + // This implementation throws from the abi_enter method. // struct C : implements { @@ -145,7 +145,7 @@ namespace } // - // This implemenetation provides a nested abi_guard + // This implementation provides a nested abi_guard // struct D : implements { @@ -223,7 +223,7 @@ namespace }; // - // This implemenetation use an abi_guard type alias + // This implementation use an abi_guard type alias // struct E : implements { @@ -275,7 +275,7 @@ namespace }; // - // This implemenetation use an abi_guard type alias that thows + // This implementation use an abi_guard type alias that thows // struct F : implements { diff --git a/test/test/abi_guard.cpp b/test/test/abi_guard.cpp index c0244a475..0eccbaefe 100644 --- a/test/test/abi_guard.cpp +++ b/test/test/abi_guard.cpp @@ -6,7 +6,7 @@ using namespace Windows::Foundation; namespace { // - // This implemenetation uses the simplest abi_enter and abi_exit methods + // This implementation uses the simplest abi_enter and abi_exit methods // struct Simple : implements { @@ -34,7 +34,7 @@ namespace }; // - // This implemenetation uses the abi_enter but omits the abi_exit method + // This implementation uses the abi_enter but omits the abi_exit method // struct OnlyEnter : implements { @@ -56,7 +56,7 @@ namespace }; // - // This implemenetation throws from the abi_enter method + // This implementation throws from the abi_enter method // struct Throwing : implements { @@ -83,7 +83,7 @@ namespace }; // - // This implemenetation provides a nested abi_guard + // This implementation provides a nested abi_guard // struct NestedGuard : implements { @@ -138,7 +138,7 @@ namespace }; // - // This implemenetation use an abi_guard type alias + // This implementation use an abi_guard type alias // struct GuardAlias : implements { @@ -167,7 +167,7 @@ namespace }; // - // This implemenetation use an abi_guard type alias that thows + // This implementation use an abi_guard type alias that thows // struct ThrowAlias : implements { From f6effc3c9315377e06f5d3d735efd96bd47eab15 Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Fri, 5 Apr 2024 13:35:05 -0400 Subject: [PATCH 09/20] spelling: input Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- test/old_tests/UnitTests/struct.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/old_tests/UnitTests/struct.cpp b/test/old_tests/UnitTests/struct.cpp index 347e1090e..7b3f2ea91 100644 --- a/test/old_tests/UnitTests/struct.cpp +++ b/test/old_tests/UnitTests/struct.cpp @@ -47,7 +47,7 @@ TEST_CASE("struct, TypeName") // // This second test ensures that structures with IReference fields are projected correctly. // In this case, a suitable interface is not available in the Windows SDK so we hand-roll the -// the necessary intput and output patterms for code generation. We also rely on a custom +// the necessary input and output patterms for code generation. We also rely on a custom // implementation of IReference so that we can additionally check that the object is // destroyed correctly. // From 7eec64bc77c86f46b561f84a0b4009c54aef2c51 Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Fri, 5 Apr 2024 13:34:54 -0400 Subject: [PATCH 10/20] spelling: interface Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- test/old_tests/Component/Component.idl | 4 ++-- test/old_tests/UnitTests/produce.cpp | 2 +- test/old_tests/UnitTests/produce_async.cpp | 2 +- test/old_tests/UnitTests/produce_map.cpp | 2 +- test/old_tests/UnitTests/produce_vector.cpp | 2 +- 5 files changed, 6 insertions(+), 6 deletions(-) diff --git a/test/old_tests/Component/Component.idl b/test/old_tests/Component/Component.idl index 157297ee9..3c306ad69 100644 --- a/test/old_tests/Component/Component.idl +++ b/test/old_tests/Component/Component.idl @@ -247,7 +247,7 @@ namespace Component runtimeclass FastInputVector { // Don't confuse this for a high-performance vector. This is for testing fast-input binding support. - // The default interface is intentionally not one of the collection intefaces to force them to be convertible for testing. + // The default interface is intentionally not one of the collection interfaces to force them to be convertible for testing. [default] interface Windows.Foundation.IClosable; interface Windows.Foundation.Collections.IVector; interface Windows.Foundation.Collections.IVectorView; @@ -265,7 +265,7 @@ namespace Component runtimeclass FastInputMap { // Don't confuse this for a high-performance map. This is for testing fast-input binding support. - // The default interface is intentionally not one of the collection intefaces to force them to be convertible for testing. + // The default interface is intentionally not one of the collection interfaces to force them to be convertible for testing. [default] interface Windows.Foundation.IClosable; interface Windows.Foundation.Collections.IMap; interface Windows.Foundation.Collections.IMapView; diff --git a/test/old_tests/UnitTests/produce.cpp b/test/old_tests/UnitTests/produce.cpp index 403f0df2b..149466002 100644 --- a/test/old_tests/UnitTests/produce.cpp +++ b/test/old_tests/UnitTests/produce.cpp @@ -4,7 +4,7 @@ // // These tests cover the production of the three core interfaces namely IUnknown, IInspectable, and IActivationFactory. // Tests ensure that the ABI surface lines up on the consumer and producer sides and this is mainly done simply by calling -// the various inteface methods. +// the various interface methods. // using namespace winrt; diff --git a/test/old_tests/UnitTests/produce_async.cpp b/test/old_tests/UnitTests/produce_async.cpp index e37842e12..ed8ee50db 100644 --- a/test/old_tests/UnitTests/produce_async.cpp +++ b/test/old_tests/UnitTests/produce_async.cpp @@ -4,7 +4,7 @@ // // These tests cover the production of the various async interfaces. // Tests ensure that the ABI surface lines up on the consumer and producer sides and this is mainly done simply by calling -// the various inteface methods. +// the various interface methods. // using namespace winrt; diff --git a/test/old_tests/UnitTests/produce_map.cpp b/test/old_tests/UnitTests/produce_map.cpp index b456082a4..0c66a1820 100644 --- a/test/old_tests/UnitTests/produce_map.cpp +++ b/test/old_tests/UnitTests/produce_map.cpp @@ -5,7 +5,7 @@ // // These tests cover the production of the various map-related interfaces. // Tests ensure that the ABI surface lines up on the consumer and producer sides and this is mainly done simply by calling -// the various inteface methods. +// the various interface methods. // using namespace winrt; diff --git a/test/old_tests/UnitTests/produce_vector.cpp b/test/old_tests/UnitTests/produce_vector.cpp index fbf3d3b84..16111f96d 100644 --- a/test/old_tests/UnitTests/produce_vector.cpp +++ b/test/old_tests/UnitTests/produce_vector.cpp @@ -5,7 +5,7 @@ // // These tests cover the production of the various vector-related interfaces. // Tests ensure that the ABI surface lines up on the consumer and producer sides and this is mainly done simply by calling -// the various inteface methods. +// the various interface methods. // using namespace winrt; From bf3c28bbe312a0f8c26d1c0dfe325b6bb3cc5b23 Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Fri, 5 Apr 2024 13:35:26 -0400 Subject: [PATCH 11/20] spelling: metadata Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- natvis/object_visualizer.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/natvis/object_visualizer.h b/natvis/object_visualizer.h index 08cc40f72..ad83d79d7 100644 --- a/natvis/object_visualizer.h +++ b/natvis/object_visualizer.h @@ -26,7 +26,7 @@ enum class ObjectType Projection, }; -// Metatdata for resolving a runtime class property value +// Metadata for resolving a runtime class property value struct PropertyData { std::wstring iid; From 09150e21b07290e32ff0aa7dcd5af499953c2788 Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Fri, 5 Apr 2024 13:35:48 -0400 Subject: [PATCH 12/20] spelling: observable Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- test/old_tests/UnitTests/async.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/old_tests/UnitTests/async.cpp b/test/old_tests/UnitTests/async.cpp index 979c2aac7..037e16ab7 100644 --- a/test/old_tests/UnitTests/async.cpp +++ b/test/old_tests/UnitTests/async.cpp @@ -1098,7 +1098,7 @@ TEST_CASE("async, Cancel_IAsyncOperationWithProgress, 2") } // -// These tests confirm the implicit cancelation behavior. The obeservable behavior should be the same as above +// These tests confirm the implicit cancelation behavior. The observable behavior should be the same as above // but the implementation relies on an exception so we confirm that the state changes occur as before. // From 5d06c315330e4858100fe2c00303c07692fb54b3 Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Fri, 5 Apr 2024 13:36:30 -0400 Subject: [PATCH 13/20] spelling: override Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- nuget/Microsoft.Windows.CppWinRT.targets | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/nuget/Microsoft.Windows.CppWinRT.targets b/nuget/Microsoft.Windows.CppWinRT.targets index f5606caec..fdbac9960 100644 --- a/nuget/Microsoft.Windows.CppWinRT.targets +++ b/nuget/Microsoft.Windows.CppWinRT.targets @@ -28,7 +28,7 @@ Copyright (C) Microsoft Corporation. All rights reserved. $(CppWinRTParameters) -fastabi "$(CppWinRTPackageDir)bin\" "$(CppWinRTPackageDir)" - + true C++ From 7a12726925d88c1c7e83cd30d839cd089fe7d684 Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Fri, 5 Apr 2024 13:36:40 -0400 Subject: [PATCH 14/20] spelling: patterns Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- test/old_tests/UnitTests/struct.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/old_tests/UnitTests/struct.cpp b/test/old_tests/UnitTests/struct.cpp index 7b3f2ea91..995f495a4 100644 --- a/test/old_tests/UnitTests/struct.cpp +++ b/test/old_tests/UnitTests/struct.cpp @@ -47,7 +47,7 @@ TEST_CASE("struct, TypeName") // // This second test ensures that structures with IReference fields are projected correctly. // In this case, a suitable interface is not available in the Windows SDK so we hand-roll the -// the necessary input and output patterms for code generation. We also rely on a custom +// the necessary input and output patterns for code generation. We also rely on a custom // implementation of IReference so that we can additionally check that the object is // destroyed correctly. // From de3bd1b49a42d6414bffa98d00473db67883777c Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Fri, 5 Apr 2024 13:28:33 -0400 Subject: [PATCH 15/20] spelling: really Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- test/test/cmd_reader.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/test/cmd_reader.cpp b/test/test/cmd_reader.cpp index 731922fd8..a7b9a7ad1 100644 --- a/test/test/cmd_reader.cpp +++ b/test/test/cmd_reader.cpp @@ -122,7 +122,7 @@ TEST_CASE("cmd_reader") REQUIRE_FALSE(args.exists("verbose")); } - // response file #4: really really long path + // response file #4: really, really, long path { const char* argv[] = { "progname", "@respfile.txt" }; const size_t argc = _countof(argv); From 83ac6ee39684bc6e85ae7d0a4b3e037f1d37630a Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Fri, 5 Apr 2024 13:36:54 -0400 Subject: [PATCH 16/20] spelling: responses Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- test/old_tests/UnitTests/marshal.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/old_tests/UnitTests/marshal.cpp b/test/old_tests/UnitTests/marshal.cpp index e183aa674..b260e7528 100644 --- a/test/old_tests/UnitTests/marshal.cpp +++ b/test/old_tests/UnitTests/marshal.cpp @@ -2,7 +2,7 @@ #include "catch.hpp" // These tests do not attempt to test the FTM itself, but merely to confirm that the presence and -// absence of the non_agile marker does indeed produce the correct reponses from QueryInterface. +// absence of the non_agile marker does indeed produce the correct responses from QueryInterface. // CoMarshalInterfaceXxxx is also used to exercise the code paths. Also, these tests confirm that // the weak reference object inherits the same agility as the source. Although much of this is // tested elsewhere, it was helpful to have these tests as a set. From 9384f1c865556951e8c29a06ff81a213fc4a173b Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Fri, 5 Apr 2024 13:37:19 -0400 Subject: [PATCH 17/20] spelling: temporary Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- nuget/readme.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/nuget/readme.md b/nuget/readme.md index 862d8c645..cd6c2312d 100644 --- a/nuget/readme.md +++ b/nuget/readme.md @@ -41,7 +41,7 @@ It sets the following project properties and item metadata: | Link.AdditionalDependencies | WindowsApp.lib | Umbrella library for Windows Runtime imports | | Midl.AdditionalOptions | /reference ... | Enables faster compilation with winmd references (versus idl imports) | | Midl.EnableWindowsRuntime | true | Enables Windows Runtime semantics | -| Midl.MetadataFileName | Unmerged\%(Filename).winmd | Generates unmerged metadata in a tempoary location | +| Midl.MetadataFileName | Unmerged\%(Filename).winmd | Generates unmerged metadata in a temporary location | | Midl.GenerateClientFiles, GenerateServerFiles, GenerateStublessProxies, GenerateTypeLibrary, HeaderFileName, DllDataFileName, InterfaceIdentifierFileName, ProxyFileName, TypeLibraryName | *nul, *None, *false | Disable unnecessary output | \*If not already set From 7e6ac186090839c28ea8a394d9c0abee6d995848 Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Fri, 5 Apr 2024 13:41:09 -0400 Subject: [PATCH 18/20] spelling: throws Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- test/old_tests/UnitTests/abi_guard.cpp | 2 +- test/test/abi_guard.cpp | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/test/old_tests/UnitTests/abi_guard.cpp b/test/old_tests/UnitTests/abi_guard.cpp index f9ee1fdde..70800323c 100644 --- a/test/old_tests/UnitTests/abi_guard.cpp +++ b/test/old_tests/UnitTests/abi_guard.cpp @@ -275,7 +275,7 @@ namespace }; // - // This implementation use an abi_guard type alias that thows + // This implementation use an abi_guard type alias that throws // struct F : implements { diff --git a/test/test/abi_guard.cpp b/test/test/abi_guard.cpp index 0eccbaefe..b2931b278 100644 --- a/test/test/abi_guard.cpp +++ b/test/test/abi_guard.cpp @@ -167,7 +167,7 @@ namespace }; // - // This implementation use an abi_guard type alias that thows + // This implementation use an abi_guard type alias that throws // struct ThrowAlias : implements { From 0ff28f686adcd357c357bdf262b7fe2004db7f49 Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Fri, 5 Apr 2024 13:37:27 -0400 Subject: [PATCH 19/20] spelling: unnecessarily Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- test/test_component_base/pch.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/test_component_base/pch.h b/test/test_component_base/pch.h index e5c39a869..a6f43eada 100644 --- a/test/test_component_base/pch.h +++ b/test/test_component_base/pch.h @@ -4,6 +4,6 @@ #include "winrt/base.h" // get_module_lock will always return true if WINRT_NO_MODULE_LOCK is defined. -// This ensures that if the DLL unecessarily exports DllCanUnloadNow that it +// This ensures that if the DLL unnecessarily exports DllCanUnloadNow that it // will in turn return S_FALSE. static_assert(winrt::get_module_lock()); From 8c8b9193c44219e240765080b8c52cc7bef46186 Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Fri, 5 Apr 2024 13:37:37 -0400 Subject: [PATCH 20/20] spelling: verbosity Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- nuget/readme.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/nuget/readme.md b/nuget/readme.md index cd6c2312d..9379aa716 100644 --- a/nuget/readme.md +++ b/nuget/readme.md @@ -147,7 +147,7 @@ For example, if the verbosity is set to minimal, then only messages with high im The default importance of C++/WinRT build messages is 'normal', but this can be overridden with the CppWinRTVerbosity property to enable throttling of C++/WinRT messages independent of the overall verbosity level. Example: -> msbuild project.vcxproj /vebosity:minimal /property:CppWinRTVerbosity=high ... +> msbuild project.vcxproj /verbosity:minimal /property:CppWinRTVerbosity=high ... For more complex analysis of build errors, the [MSBuild Binary and Structured Log Viewer](http://msbuildlog.com/) is highly recommended.