diff --git a/cppwinrt.props b/cppwinrt.props index 997b7187f..b313ffd04 100644 --- a/cppwinrt.props +++ b/cppwinrt.props @@ -53,7 +53,7 @@ stdcpp17 Use pch.h - CPPWINRT_VERSION_STRING="$(CppWinRTBuildVersion)";NOMINMAX;%(PreprocessorDefinitions) + CPPWINRT_VERSION_STRING="$(CppWinRTBuildVersion)";%(PreprocessorDefinitions) true /await /bigobj -Wno-unused-command-line-argument -fno-delayed-template-parsing -Xclang -fcoroutines-ts -mcx16 diff --git a/cppwinrt/cmd_reader.h b/cppwinrt/cmd_reader.h index 039948a68..0f9f57f9c 100644 --- a/cppwinrt/cmd_reader.h +++ b/cppwinrt/cmd_reader.h @@ -287,7 +287,7 @@ namespace cppwinrt struct option { static constexpr uint32_t no_min = 0; - static constexpr uint32_t no_max = std::numeric_limits::max(); + static constexpr uint32_t no_max = UINT_MAX; std::string_view name; uint32_t min{ no_min }; diff --git a/cppwinrt/helpers.h b/cppwinrt/helpers.h index 580fc276e..a8aeab9e8 100644 --- a/cppwinrt/helpers.h +++ b/cppwinrt/helpers.h @@ -541,7 +541,7 @@ namespace cppwinrt for (auto&& type : classes) { - result = std::max(result, get_fastabi_size(w, type)); + result = (std::max)(result, get_fastabi_size(w, type)); } return result; diff --git a/scratch/scratch.vcxproj b/scratch/scratch.vcxproj index ae9bca8fb..df71cbdac 100644 --- a/scratch/scratch.vcxproj +++ b/scratch/scratch.vcxproj @@ -150,7 +150,7 @@ Disabled $(OutputPath);Generated Files;..\..\..\library - NOMINMAX;_MBCS;%(PreprocessorDefinitions) + _MBCS;%(PreprocessorDefinitions) /await %(AdditionalOptions) MultiThreadedDebug @@ -170,7 +170,7 @@ Disabled $(OutputPath);Generated Files;..\..\..\library - NOMINMAX;_MBCS;%(PreprocessorDefinitions) + _MBCS;%(PreprocessorDefinitions) /await %(AdditionalOptions) MultiThreadedDebug @@ -190,7 +190,7 @@ Disabled $(OutputPath);Generated Files;..\..\..\library - NOMINMAX;_MBCS;%(PreprocessorDefinitions) + _MBCS;%(PreprocessorDefinitions) /await %(AdditionalOptions) MultiThreadedDebug @@ -210,7 +210,7 @@ Disabled $(OutputPath);Generated Files;..\..\..\library - NOMINMAX;_MBCS;%(PreprocessorDefinitions) + _MBCS;%(PreprocessorDefinitions) /await %(AdditionalOptions) MultiThreadedDebug diff --git a/strings/base_string.h b/strings/base_string.h index 11b5c13d6..7fd198693 100644 --- a/strings/base_string.h +++ b/strings/base_string.h @@ -77,7 +77,7 @@ namespace winrt::impl WINRT_ASSERT(length != 0); uint64_t bytes_required = sizeof(shared_hstring_header) + sizeof(wchar_t) * length; - if (bytes_required > std::numeric_limits::max()) + if (bytes_required > UINT_MAX) { throw std::invalid_argument("length"); } diff --git a/strings/base_string_input.h b/strings/base_string_input.h index 7c6cb5a1a..786b31519 100644 --- a/strings/base_string_input.h +++ b/strings/base_string_input.h @@ -37,7 +37,7 @@ WINRT_EXPORT namespace winrt::param private: void create_string_reference(wchar_t const* const data, size_t size) noexcept { - WINRT_ASSERT(size < std::numeric_limits::max()); + WINRT_ASSERT(size < UINT_MAX); auto size32 = static_cast(size); if (size32 == 0) diff --git a/test/test/test.vcxproj b/test/test/test.vcxproj index 9511f5de1..604aff066 100644 --- a/test/test/test.vcxproj +++ b/test/test/test.vcxproj @@ -128,7 +128,7 @@ true true $(OutputPath);Generated Files;..;..\..\cppwinrt - NOMINMAX;_MBCS;%(PreprocessorDefinitions) + _MBCS;%(PreprocessorDefinitions) MultiThreaded @@ -148,7 +148,7 @@ Disabled $(OutputPath);Generated Files;..;..\..\cppwinrt - NOMINMAX;_MBCS;%(PreprocessorDefinitions) + _MBCS;%(PreprocessorDefinitions) MultiThreadedDebug @@ -166,7 +166,7 @@ Disabled $(OutputPath);Generated Files;..;..\..\cppwinrt - NOMINMAX;_MBCS;%(PreprocessorDefinitions) + _MBCS;%(PreprocessorDefinitions) MultiThreadedDebug @@ -184,7 +184,7 @@ Disabled $(OutputPath);Generated Files;..;..\..\cppwinrt - NOMINMAX;_MBCS;%(PreprocessorDefinitions) + _MBCS;%(PreprocessorDefinitions) MultiThreadedDebug @@ -202,7 +202,7 @@ Disabled $(OutputPath);Generated Files;..;..\..\cppwinrt - NOMINMAX;_MBCS;%(PreprocessorDefinitions) + _MBCS;%(PreprocessorDefinitions) MultiThreadedDebug @@ -222,7 +222,7 @@ true true $(OutputPath);Generated Files;..;..\..\cppwinrt - NOMINMAX;_MBCS;%(PreprocessorDefinitions) + _MBCS;%(PreprocessorDefinitions) MultiThreaded @@ -244,7 +244,7 @@ true true $(OutputPath);Generated Files;..;..\..\cppwinrt - NOMINMAX;_MBCS;%(PreprocessorDefinitions) + _MBCS;%(PreprocessorDefinitions) MultiThreaded @@ -266,7 +266,7 @@ true true $(OutputPath);Generated Files;..;..\..\cppwinrt - NOMINMAX;_MBCS;%(PreprocessorDefinitions) + _MBCS;%(PreprocessorDefinitions) MultiThreaded