From 11deec226a3d3b94bf30702e1ba358a76f473a61 Mon Sep 17 00:00:00 2001 From: Jake Fullerton Date: Mon, 4 Dec 2023 12:17:08 -0500 Subject: [PATCH 1/5] require new packages --- ts/src/connections/package.json | 4 ++-- ts/src/management/package.json | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/ts/src/connections/package.json b/ts/src/connections/package.json index ba1afc03..8c6dd454 100644 --- a/ts/src/connections/package.json +++ b/ts/src/connections/package.json @@ -18,8 +18,8 @@ "buffer": "^5.2.1", "debug": "^4.1.1", "vscode-jsonrpc": "^4.0.0", - "@microsoft/dev-tunnels-contracts": "^1.0.0", - "@microsoft/dev-tunnels-management": "^1.0.0", + "@microsoft/dev-tunnels-contracts": ">1.0.7463", + "@microsoft/dev-tunnels-management": ">1.0.7463", "@microsoft/dev-tunnels-ssh": "^3.11.33", "@microsoft/dev-tunnels-ssh-tcp": "^3.11.33", "uuid": "^3.3.3", diff --git a/ts/src/management/package.json b/ts/src/management/package.json index d3647bf8..1d885e0e 100644 --- a/ts/src/management/package.json +++ b/ts/src/management/package.json @@ -18,7 +18,7 @@ "buffer": "^5.2.1", "debug": "^4.1.1", "vscode-jsonrpc": "^4.0.0", - "@microsoft/dev-tunnels-contracts": "^1.0.0", + "@microsoft/dev-tunnels-contracts": ">1.0.7463", "axios": "^1.6.2" } } From 61987f4a27c7ff228009fac3b2727152da45fb40 Mon Sep 17 00:00:00 2001 From: Jake Fullerton Date: Mon, 4 Dec 2023 12:26:43 -0500 Subject: [PATCH 2/5] Add docs --- .github/pull_request_template.md | 1 + ts/README-dev.md | 3 +++ 2 files changed, 4 insertions(+) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 3a388146..d1b6b301 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -7,3 +7,4 @@ Fixes # ### Other Tasks: - [ ] If you updated the Go SDK did you update the PackageVersion in tunnels.go +- [ ] If you updated the TS SDK did you update the dependencies in package.json for connections and management to require a dependency that is > the current published version. This will fix issues where yarn will pull the old version of packages and will cause mismatched dependencies. See [example PR](https://github.com/microsoft/dev-tunnels/pull/358) diff --git a/ts/README-dev.md b/ts/README-dev.md index 1f43c42f..1b8f0aca 100644 --- a/ts/README-dev.md +++ b/ts/README-dev.md @@ -23,3 +23,6 @@ npm run test ``` To run/debug an individual test case or subset of test cases matching a substring, use a command similar to the following: + +## Making Changes +If you update this SDK, please up the package.json file in conenctions and management to require a dependeny that is > the current published version. This will fix issues where yarn will pull the old version of packages and will cause mismatched dependencies. \ No newline at end of file From 56287eff89ea78410bdd9c76c9e22bc07a8b05dc Mon Sep 17 00:00:00 2001 From: Jake Fullerton Date: Mon, 4 Dec 2023 12:27:14 -0500 Subject: [PATCH 3/5] more docs --- ts/README-dev.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ts/README-dev.md b/ts/README-dev.md index 1b8f0aca..71b8eeb8 100644 --- a/ts/README-dev.md +++ b/ts/README-dev.md @@ -25,4 +25,4 @@ To run/debug an individual test case or subset of test cases matching a substring, use a command similar to the following: ## Making Changes -If you update this SDK, please up the package.json file in conenctions and management to require a dependeny that is > the current published version. This will fix issues where yarn will pull the old version of packages and will cause mismatched dependencies. \ No newline at end of file +If you update this SDK, please up the package.json file in conenctions and management to require a dependeny that is > the current published version. This will fix issues where yarn will pull the old version of packages and will cause mismatched dependencies. See [example PR](https://github.com/microsoft/dev-tunnels/pull/358) \ No newline at end of file From 5095854199bab8cb64b43bcbccd52b3b2bdf34c8 Mon Sep 17 00:00:00 2001 From: Jake Fullerton Date: Mon, 4 Dec 2023 13:09:17 -0500 Subject: [PATCH 4/5] PR suggestions --- .github/pull_request_template.md | 3 ++- ts/README-dev.md | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index d1b6b301..53d1ff45 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -6,5 +6,6 @@ Fixes # - ### Other Tasks: + - [ ] If you updated the Go SDK did you update the PackageVersion in tunnels.go -- [ ] If you updated the TS SDK did you update the dependencies in package.json for connections and management to require a dependency that is > the current published version. This will fix issues where yarn will pull the old version of packages and will cause mismatched dependencies. See [example PR](https://github.com/microsoft/dev-tunnels/pull/358) +- [ ] If you updated the TS SDK did you update the dependencies in package.json for connections and management to require a dependency that is > the current published version(Found using `npm view @microsoft/dev-tunnels-contracts`). This will fix issues where yarn will pull the old version of packages and will cause mismatched dependencies. See [example PR](https://github.com/microsoft/dev-tunnels/pull/358) diff --git a/ts/README-dev.md b/ts/README-dev.md index 71b8eeb8..e5efecd2 100644 --- a/ts/README-dev.md +++ b/ts/README-dev.md @@ -25,4 +25,4 @@ To run/debug an individual test case or subset of test cases matching a substring, use a command similar to the following: ## Making Changes -If you update this SDK, please up the package.json file in conenctions and management to require a dependeny that is > the current published version. This will fix issues where yarn will pull the old version of packages and will cause mismatched dependencies. See [example PR](https://github.com/microsoft/dev-tunnels/pull/358) \ No newline at end of file +If you update this SDK, please update the package.json file in conenctions and management to require a dependeny that is > the current published version(You can find this with the `npm view @microsoft/dev-tunnels-contracts` command). This will fix issues where yarn will pull the old version of packages and will cause mismatched dependencies. See [example PR](https://github.com/microsoft/dev-tunnels/pull/358) \ No newline at end of file From bb6ef3ac5d4a65b1745ebbf19e97b02b7bc30ba0 Mon Sep 17 00:00:00 2001 From: Jake Fullerton Date: Mon, 18 Dec 2023 22:20:23 -0500 Subject: [PATCH 5/5] update package versions --- ts/src/connections/package.json | 4 ++-- ts/src/management/package.json | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/ts/src/connections/package.json b/ts/src/connections/package.json index 8c6dd454..fa1669bb 100644 --- a/ts/src/connections/package.json +++ b/ts/src/connections/package.json @@ -18,8 +18,8 @@ "buffer": "^5.2.1", "debug": "^4.1.1", "vscode-jsonrpc": "^4.0.0", - "@microsoft/dev-tunnels-contracts": ">1.0.7463", - "@microsoft/dev-tunnels-management": ">1.0.7463", + "@microsoft/dev-tunnels-contracts": ">1.1.1", + "@microsoft/dev-tunnels-management": ">1.1.1", "@microsoft/dev-tunnels-ssh": "^3.11.33", "@microsoft/dev-tunnels-ssh-tcp": "^3.11.33", "uuid": "^3.3.3", diff --git a/ts/src/management/package.json b/ts/src/management/package.json index 1d885e0e..a66e1546 100644 --- a/ts/src/management/package.json +++ b/ts/src/management/package.json @@ -18,7 +18,7 @@ "buffer": "^5.2.1", "debug": "^4.1.1", "vscode-jsonrpc": "^4.0.0", - "@microsoft/dev-tunnels-contracts": ">1.0.7463", + "@microsoft/dev-tunnels-contracts": ">1.1.1", "axios": "^1.6.2" } }