From 7289451f52c08330c4dc320b382130a875852fff Mon Sep 17 00:00:00 2001 From: hex0punk Date: Thu, 8 Apr 2021 01:05:27 -0700 Subject: [PATCH] prevents a goroutine from being leaked if binary cmd fails to finish --- internal/cmd/io_binary.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/internal/cmd/io_binary.go b/internal/cmd/io_binary.go index a06dedfbfa..ecfd1fa5ef 100644 --- a/internal/cmd/io_binary.go +++ b/internal/cmd/io_binary.go @@ -182,7 +182,7 @@ func (b *binaryIO) Close(ctx context.Context) { } }) b.binaryCloser.Do(func() { - done := make(chan error) + done := make(chan error, 1) go func() { done <- b.cmd.Wait() }()