Add structure hook for Union[str, List[InlayHintLabelPart]]#219
Merged
Conversation
8 tasks
karthiknadig
previously approved these changes
Jun 19, 2023
Member
|
@alcarney It looks like how pygls used to run tests has changed. Would it be possible for you to update the github workflow so that we can run pygls tests as smoke tests? |
Contributor
Author
|
It is not immediately obvious to me why the test suite would hang before running any tests - especially when they seem to run fine over on the pygls repo.... But I will have a look and see if I can reproduce it locally |
Member
|
@alcarney I was running |
Contributor
Author
|
@karthiknadig I reproduced it locally - test suite hangs on the second test. |
05bf213 to
60f0831
Compare
With the addition of tests for pygls' new base JSON-RPC client, it's necessary for `pygls` itself to be importable in order to spin up the test servers.
60f0831 to
0c709db
Compare
karthiknadig
approved these changes
Jun 21, 2023
eleanorjboyd
approved these changes
Jun 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #218