Skip to content

Remove types preserved from backwards compat #296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
karthiknadig merged 1 commit into from
Nov 20, 2023
+2 −6
Merged

Remove types preserved from backwards compat #296

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion generator/plugins/python/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
PACKAGE_NAME = "lsprotocol"

# These are special type aliases to preserve backward compatibility.
custom_request_params_aliases = ["WorkspaceConfigurationParams"]
custom_request_params_aliases = []


def generate_from_spec(spec: model.LSPModel, output_dir: str, test_dir: str) -> None:
Expand Down
6 changes: 1 addition & 5 deletions packages/python/lsprotocol/types.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9208,9 +9208,6 @@ class WorkspaceWorkspaceFoldersResponse:
jsonrpc: str = attrs.field(default="2.0")


WorkspaceConfigurationParams = ConfigurationParams


WorkspaceConfigurationResult = Sequence[LSPAny]


Expand All @@ -9226,7 +9223,7 @@ class WorkspaceConfigurationRequest:

id: Union[int, str] = attrs.field()
"""The request id."""
params: WorkspaceConfigurationParams = attrs.field()
params: ConfigurationParams = attrs.field()
method: str = "workspace/configuration"
"""The method to be invoked."""
jsonrpc: str = attrs.field(default="2.0")
Expand Down Expand Up @@ -13125,7 +13122,6 @@ def is_special_property(cls: type, property_name: str) -> bool:
"WorkspaceClientCapabilities": WorkspaceClientCapabilities,
"WorkspaceCodeLensRefreshRequest": WorkspaceCodeLensRefreshRequest,
"WorkspaceCodeLensRefreshResponse": WorkspaceCodeLensRefreshResponse,
"WorkspaceConfigurationParams": WorkspaceConfigurationParams,
"WorkspaceConfigurationRequest": WorkspaceConfigurationRequest,
"WorkspaceConfigurationResponse": WorkspaceConfigurationResponse,
"WorkspaceConfigurationResult": WorkspaceConfigurationResult,
Expand Down