Skip to content

Commit 07e7d4f

Browse files
committed
less external urls
1 parent f1c082f commit 07e7d4f

4 files changed

Lines changed: 11 additions & 9 deletions

File tree

tests/assets/client.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ def main(playwright: Playwright) -> None:
2121
for browser_type in [playwright.chromium, playwright.firefox, playwright.webkit]:
2222
browser = browser_type.launch()
2323
page = browser.new_page()
24-
page.goto("https://example.com")
24+
page.goto("data:text/html,Foobar")
2525
here = Path(__file__).parent.resolve()
2626
page.screenshot(path=here / f"{browser_type.name}.png")
2727
page.close()

tests/common/test_events.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,10 @@
33
import pytest
44

55
from playwright.sync_api import sync_playwright
6+
from tests.server import Server
67

78

8-
def test_events(browser_name: str, launch_arguments: Dict) -> None:
9+
def test_events(browser_name: str, launch_arguments: Dict, server: Server) -> None:
910
with pytest.raises(Exception, match="fail"):
1011

1112
def fail() -> None:
@@ -15,4 +16,4 @@ def fail() -> None:
1516
with p[browser_name].launch(**launch_arguments) as browser:
1617
with browser.new_page() as page:
1718
page.on("response", lambda _: fail())
18-
page.goto("https://example.com")
19+
page.goto(server.PREFIX + "/grid.html")

tests/sync/test_sync.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -41,13 +41,13 @@ def test_sync_query_selector(page: Page) -> None:
4141
assert e1.inner_text() == e2.inner_text()
4242

4343

44-
def test_page_repr(page: Page) -> None:
45-
page.goto("https://example.com")
44+
def test_page_repr(page: Page, server: Server) -> None:
45+
page.goto(server.EMPTY_PAGE)
4646
assert repr(page) == f"<Page url={page.url!r}>"
4747

4848

49-
def test_frame_repr(page: Page) -> None:
50-
page.goto("https://example.com")
49+
def test_frame_repr(page: Page, server: Server) -> None:
50+
page.goto(server.EMPTY_PAGE)
5151
assert (
5252
repr(page.main_frame)
5353
== f"<Frame name={page.main_frame.name} url={page.main_frame.url!r}>"

tests/test_reference_count_async.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,14 +19,15 @@
1919
import pytest
2020

2121
from playwright.async_api import async_playwright
22+
from tests.server import Server
2223

2324

2425
@pytest.mark.asyncio
25-
async def test_memory_objects() -> None:
26+
async def test_memory_objects(server: Server) -> None:
2627
async with async_playwright() as p:
2728
browser = await p.chromium.launch()
2829
page = await browser.new_page()
29-
await page.goto("https://example.com")
30+
await page.goto(server.EMPTY_PAGE)
3031

3132
page.on("dialog", lambda dialog: dialog.dismiss())
3233
for _ in range(100):

0 commit comments

Comments
 (0)