From ea13277e832c47924f78cb9192c4f01f64f84c2c Mon Sep 17 00:00:00 2001 From: Yury Semikhatsky Date: Wed, 22 Sep 2021 10:37:24 -0700 Subject: [PATCH 1/2] docs: improve ignorehttpserrors description --- docs/src/api/params.md | 2 +- types/test.d.ts | 2 +- types/types.d.ts | 10 +++++----- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/docs/src/api/params.md b/docs/src/api/params.md index 0a7dfbf708650..831659fc021d2 100644 --- a/docs/src/api/params.md +++ b/docs/src/api/params.md @@ -248,7 +248,7 @@ Whether to automatically download all the attachments. Defaults to `false` where ## context-option-ignorehttpserrors - `ignoreHTTPSErrors` <[boolean]> -Whether to ignore HTTPS errors during navigation. Defaults to `false`. +Whether to ignore HTTPS errors when sending network requests. Defaults to `false`. ## context-option-bypasscsp - `bypassCSP` <[boolean]> diff --git a/types/test.d.ts b/types/test.d.ts index 5f3dcd2bee708..fb13817742587 100644 --- a/types/test.d.ts +++ b/types/test.d.ts @@ -2479,7 +2479,7 @@ export interface PlaywrightTestOptions { */ httpCredentials: HTTPCredentials | undefined; /** - * Whether to ignore HTTPS errors during navigation. Defaults to `false`. + * Whether to ignore HTTPS errors when sending network requests. Defaults to `false`. */ ignoreHTTPSErrors: boolean | undefined; /** diff --git a/types/types.d.ts b/types/types.d.ts index 2ec4db13c039f..a07e188dceba3 100644 --- a/types/types.d.ts +++ b/types/types.d.ts @@ -9813,7 +9813,7 @@ export interface BrowserType { ignoreDefaultArgs?: boolean|Array; /** - * Whether to ignore HTTPS errors during navigation. Defaults to `false`. + * Whether to ignore HTTPS errors when sending network requests. Defaults to `false`. */ ignoreHTTPSErrors?: boolean; @@ -10979,7 +10979,7 @@ export interface AndroidDevice { }; /** - * Whether to ignore HTTPS errors during navigation. Defaults to `false`. + * Whether to ignore HTTPS errors when sending network requests. Defaults to `false`. */ ignoreHTTPSErrors?: boolean; @@ -11755,7 +11755,7 @@ export interface Browser extends EventEmitter { }; /** - * Whether to ignore HTTPS errors during navigation. Defaults to `false`. + * Whether to ignore HTTPS errors when sending network requests. Defaults to `false`. */ ignoreHTTPSErrors?: boolean; @@ -12547,7 +12547,7 @@ export interface Electron { }; /** - * Whether to ignore HTTPS errors during navigation. Defaults to `false`. + * Whether to ignore HTTPS errors when sending network requests. Defaults to `false`. */ ignoreHTTPSErrors?: boolean; @@ -14242,7 +14242,7 @@ export interface BrowserContextOptions { httpCredentials?: HTTPCredentials; /** - * Whether to ignore HTTPS errors during navigation. Defaults to `false`. + * Whether to ignore HTTPS errors when sending network requests. Defaults to `false`. */ ignoreHTTPSErrors?: boolean; From dbdd3cec603d9078001e87bb891e3fe8a549e592 Mon Sep 17 00:00:00 2001 From: Yury Semikhatsky Date: Wed, 22 Sep 2021 10:43:56 -0700 Subject: [PATCH 2/2] Removed redundant text --- docs/src/api/params.md | 2 +- types/test.d.ts | 2 +- types/types.d.ts | 10 +++++----- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/docs/src/api/params.md b/docs/src/api/params.md index 831659fc021d2..4a649c538e19e 100644 --- a/docs/src/api/params.md +++ b/docs/src/api/params.md @@ -395,7 +395,7 @@ A list of permissions to grant to all pages in this context. See ## context-option-extrahttpheaders - `extraHTTPHeaders` <[Object]<[string], [string]>> -An object containing additional HTTP headers to be sent with every request. All header values must be strings. +An object containing additional HTTP headers to be sent with every request. ## context-option-offline - `offline` <[boolean]> diff --git a/types/test.d.ts b/types/test.d.ts index fb13817742587..8375c4f8e3077 100644 --- a/types/test.d.ts +++ b/types/test.d.ts @@ -2466,7 +2466,7 @@ export interface PlaywrightTestOptions { */ deviceScaleFactor: number | undefined; /** - * An object containing additional HTTP headers to be sent with every request. All header values must be strings. + * An object containing additional HTTP headers to be sent with every request. */ extraHTTPHeaders: ExtraHTTPHeaders | undefined; geolocation: Geolocation | undefined; diff --git a/types/types.d.ts b/types/types.d.ts index a07e188dceba3..dc2fe06a805d2 100644 --- a/types/types.d.ts +++ b/types/types.d.ts @@ -9739,7 +9739,7 @@ export interface BrowserType { executablePath?: string; /** - * An object containing additional HTTP headers to be sent with every request. All header values must be strings. + * An object containing additional HTTP headers to be sent with every request. */ extraHTTPHeaders?: { [key: string]: string; }; @@ -10934,7 +10934,7 @@ export interface AndroidDevice { deviceScaleFactor?: number; /** - * An object containing additional HTTP headers to be sent with every request. All header values must be strings. + * An object containing additional HTTP headers to be sent with every request. */ extraHTTPHeaders?: { [key: string]: string; }; @@ -11710,7 +11710,7 @@ export interface Browser extends EventEmitter { deviceScaleFactor?: number; /** - * An object containing additional HTTP headers to be sent with every request. All header values must be strings. + * An object containing additional HTTP headers to be sent with every request. */ extraHTTPHeaders?: { [key: string]: string; }; @@ -12516,7 +12516,7 @@ export interface Electron { executablePath?: string; /** - * An object containing additional HTTP headers to be sent with every request. All header values must be strings. + * An object containing additional HTTP headers to be sent with every request. */ extraHTTPHeaders?: { [key: string]: string; }; @@ -14216,7 +14216,7 @@ export interface BrowserContextOptions { deviceScaleFactor?: number; /** - * An object containing additional HTTP headers to be sent with every request. All header values must be strings. + * An object containing additional HTTP headers to be sent with every request. */ extraHTTPHeaders?: { [key: string]: string; };