From 71996af7acdbc9ec588b674fd2526f2ebb6a1a50 Mon Sep 17 00:00:00 2001 From: Yury Semikhatsky Date: Fri, 1 Oct 2021 12:29:26 -0700 Subject: [PATCH 1/2] fix(webkit): deduce response mime type from content-type --- src/server/webkit/wkInterceptableRequest.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/server/webkit/wkInterceptableRequest.ts b/src/server/webkit/wkInterceptableRequest.ts index 8aff250bb224a..2ea1c2a35940b 100644 --- a/src/server/webkit/wkInterceptableRequest.ts +++ b/src/server/webkit/wkInterceptableRequest.ts @@ -130,7 +130,7 @@ export class WKRouteImpl implements network.RouteDelegate { // In certain cases, protocol will return error if the request was already canceled // or the page was closed. We should tolerate these errors. let mimeType = response.isBase64 ? 'application/octet-stream' : 'text/plain'; - const headers = headersArrayToObject(response.headers, false /* lowerCase */); + const headers = headersArrayToObject(response.headers, true /* lowerCase */); const contentType = headers['content-type']; if (contentType) mimeType = contentType.split(';')[0].trim(); From ac47bccc92b2f2809e7b36a3a3ce0e97bce23586 Mon Sep 17 00:00:00 2001 From: Yury Semikhatsky Date: Fri, 1 Oct 2021 12:35:59 -0700 Subject: [PATCH 2/2] Update test --- tests/page/page-request-fulfill.spec.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/page/page-request-fulfill.spec.ts b/tests/page/page-request-fulfill.spec.ts index 7f884d720e889..90cc071c8e100 100644 --- a/tests/page/page-request-fulfill.spec.ts +++ b/tests/page/page-request-fulfill.spec.ts @@ -225,7 +225,7 @@ it('should fulfill with fetch result and overrides', async ({ page, server, isEl response, status: 201, headers: { - ...response.headers(), + 'Content-Type': 'application/json', // Case matters for the tested behavior 'foo': 'bar' } });