From dff28dbba04505d4c65f949c20e475aa1d791831 Mon Sep 17 00:00:00 2001
From: Navneet Kambo <72474613+nakambo@users.noreply.github.com>
Date: Tue, 26 Jan 2021 14:29:24 -0800
Subject: [PATCH] Minor tweaks to RCTDevSettings (#696)

* Export RCTDevSettings noop impl on shipping builds to JS

* Add a protocol method to get all set keys on dev settings

* tag changes
---
 React/CoreModules/RCTDevSettings.h  | 7 +++++++
 React/CoreModules/RCTDevSettings.mm | 9 +++++++++
 2 files changed, 16 insertions(+)

diff --git a/React/CoreModules/RCTDevSettings.h b/React/CoreModules/RCTDevSettings.h
index 9dcdd2cbb727e8..7473145888068e 100644
--- a/React/CoreModules/RCTDevSettings.h
+++ b/React/CoreModules/RCTDevSettings.h
@@ -28,6 +28,13 @@
  */
 - (id)settingForKey:(NSString *)key;
 
+// [TODO(macOS ISS#2323203)
+/**
+ * Returns all keys that are overridden
+ */
+- (NSArray<NSString *> *)overridenKeys;
+// ]TODO(macOS ISS#2323203)
+
 @end
 
 @interface RCTDevSettings : RCTEventEmitter
diff --git a/React/CoreModules/RCTDevSettings.mm b/React/CoreModules/RCTDevSettings.mm
index 1b37614bf3d828..9fcb2e469ecab3 100644
--- a/React/CoreModules/RCTDevSettings.mm
+++ b/React/CoreModules/RCTDevSettings.mm
@@ -101,6 +101,13 @@ - (id)settingForKey:(NSString *)key
   return _settings[key];
 }
 
+// [TODO(macOS ISS#2323203)
+- (NSArray<NSString *> *)overridenKeys
+{
+  return [_settings allKeys];
+}
+// ]TODO(macOS ISS#2323203)
+
 - (void)_reloadWithDefaults:(NSDictionary *)defaultValues
 {
   NSDictionary *existingSettings = [_userDefaults objectForKey:kRCTDevSettingsUserDefaultsKey];
@@ -475,6 +482,8 @@ - (void)jsLoaded:(NSNotification *)notification
 
 @implementation RCTDevSettings
 
+RCT_EXPORT_MODULE()	// TODO(macOS ISS#2323203)
+
 - (instancetype)initWithDataSource:(id<RCTDevSettingsDataSource>)dataSource
 {
   return [super init];