From 63b6ab4a6079cb5eefd8efbc334a2cb547ab0199 Mon Sep 17 00:00:00 2001 From: Adam Gorman Date: Mon, 28 Oct 2019 12:46:31 -0700 Subject: [PATCH 1/2] Change files --- ...indows-2019-10-28-12-46-31-user-adamgor-progress.json | 9 +++++++++ vnext/ReactUWP/Modules/Animated/FacadeType.h | 7 +++++-- vnext/ReactUWP/Modules/Animated/PropsAnimatedNode.cpp | 3 +++ 3 files changed, 17 insertions(+), 2 deletions(-) create mode 100644 change/react-native-windows-2019-10-28-12-46-31-user-adamgor-progress.json diff --git a/change/react-native-windows-2019-10-28-12-46-31-user-adamgor-progress.json b/change/react-native-windows-2019-10-28-12-46-31-user-adamgor-progress.json new file mode 100644 index 00000000000..6f5cf6e7c44 --- /dev/null +++ b/change/react-native-windows-2019-10-28-12-46-31-user-adamgor-progress.json @@ -0,0 +1,9 @@ +{ + "type": "prerelease", + "comment": "Add todo stub for FacadeType::Progress in AnimatedNode", + "packageName": "react-native-windows", + "email": "adamgor@microsoft.com", + "commit": "ce0f4a3a91e31207d2aa1691cfb55d159457e5d0", + "date": "2019-10-28T19:46:31.732Z", + "file": "F:\\GS\\repo\\RNW\\change\\react-native-windows-2019-10-28-12-46-31-user-adamgor-progress.json" +} \ No newline at end of file diff --git a/vnext/ReactUWP/Modules/Animated/FacadeType.h b/vnext/ReactUWP/Modules/Animated/FacadeType.h index 8ce8ed602bc..583fefdcb85 100644 --- a/vnext/ReactUWP/Modules/Animated/FacadeType.h +++ b/vnext/ReactUWP/Modules/Animated/FacadeType.h @@ -16,6 +16,7 @@ enum FacadeType { TranslateX, TranslateY, Perspective, + Progress }; static FacadeType StringToFacadeType(const std::string &string) { @@ -37,7 +38,9 @@ static FacadeType StringToFacadeType(const std::string &string) { return FacadeType::TranslateX; if (string == "translateY") return FacadeType::TranslateY; + if (string == "perspective") + return FacadeType::Perspective; - assert(string == "perspective"); - return FacadeType::Perspective; + assert(string == "progress"); + return FacadeType::Progress; } diff --git a/vnext/ReactUWP/Modules/Animated/PropsAnimatedNode.cpp b/vnext/ReactUWP/Modules/Animated/PropsAnimatedNode.cpp index 07386233a2a..701733e8f0c 100644 --- a/vnext/ReactUWP/Modules/Animated/PropsAnimatedNode.cpp +++ b/vnext/ReactUWP/Modules/Animated/PropsAnimatedNode.cpp @@ -228,6 +228,9 @@ void PropsAnimatedNode::MakeAnimation(int64_t valueNodeTag, FacadeType facadeTyp case FacadeType::Perspective: // TODO: implement perspective animations, tracked by issue #2680 return; + case FacadeType::Progress: + // TODO: implement progress animations + return; default: assert(false); } From 1adbc90f105a75356526e0356ba89a8331ef5b0f Mon Sep 17 00:00:00 2001 From: Adam Gorman Date: Mon, 28 Oct 2019 12:47:14 -0700 Subject: [PATCH 2/2] add issue number --- vnext/ReactUWP/Modules/Animated/PropsAnimatedNode.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/vnext/ReactUWP/Modules/Animated/PropsAnimatedNode.cpp b/vnext/ReactUWP/Modules/Animated/PropsAnimatedNode.cpp index 701733e8f0c..679460fd833 100644 --- a/vnext/ReactUWP/Modules/Animated/PropsAnimatedNode.cpp +++ b/vnext/ReactUWP/Modules/Animated/PropsAnimatedNode.cpp @@ -229,7 +229,7 @@ void PropsAnimatedNode::MakeAnimation(int64_t valueNodeTag, FacadeType facadeTyp // TODO: implement perspective animations, tracked by issue #2680 return; case FacadeType::Progress: - // TODO: implement progress animations + // TODO: implement progress animations, tracked by issue #3283 return; default: assert(false);