From 5ff50e103744a589228c020ef0fad45d699458cd Mon Sep 17 00:00:00 2001 From: Nick Gerleman Date: Fri, 20 Dec 2019 11:27:52 -0800 Subject: [PATCH 1/3] Export ability to query native module names This is needed for testability (intenral CR using it out now). It's not ideal to add more exports, but we will always have to have some between instance interfaces. --- vnext/Desktop.DLL/react-native-win32.x64.def | 1 + vnext/Desktop.DLL/react-native-win32.x86.def | 1 + 2 files changed, 2 insertions(+) diff --git a/vnext/Desktop.DLL/react-native-win32.x64.def b/vnext/Desktop.DLL/react-native-win32.x64.def index 2fcb7db42ad..1c4939d4444 100644 --- a/vnext/Desktop.DLL/react-native-win32.x64.def +++ b/vnext/Desktop.DLL/react-native-win32.x64.def @@ -40,6 +40,7 @@ EXPORTS ?get_ptrImpl@dynamic@folly@@AEGBAPEBU12@AEBU12@@Z ?hash@dynamic@folly@@QEBA_KXZ ?makeConversionError@folly@@YA?AVConversionError@1@W4ConversionCode@1@V?$Range@PEBD@1@@Z +?moduleNames@ModuleRegistry@react@facebook@@QEAA?AV?$vector@V?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@V?$allocator@V?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@@2@@std@@XZ ?parseJson@folly@@YA?AUdynamic@1@V?$Range@PEBD@1@@Z ?setGlobalVariable@Instance@react@facebook@@QEAAXV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@V?$unique_ptr@$$CBVJSBigString@react@facebook@@U?$default_delete@$$CBVJSBigString@react@facebook@@@std@@@5@@Z ?size@dynamic@folly@@QEBA_KXZ diff --git a/vnext/Desktop.DLL/react-native-win32.x86.def b/vnext/Desktop.DLL/react-native-win32.x86.def index eb56c60f170..1eacb60c51b 100644 --- a/vnext/Desktop.DLL/react-native-win32.x86.def +++ b/vnext/Desktop.DLL/react-native-win32.x86.def @@ -27,6 +27,7 @@ EXPORTS ?Make@IWebSocket@React@Microsoft@@SG?AV?$unique_ptr@UIWebSocket@React@Microsoft@@U?$default_delete@UIWebSocket@React@Microsoft@@@std@@@std@@ABV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@5@@Z ?Make@JSBigAbiString@react@facebook@@SG?AV?$unique_ptr@$$CBUJSBigAbiString@react@facebook@@U?$default_delete@$$CBUJSBigAbiString@react@facebook@@@std@@@std@@$$QAV?$unique_ptr@U?$IAbiArray@D@AbiSafe@@UAbiObjectDeleter@2@@5@@Z ?MakeMemoryMappedBuffer@JSI@Microsoft@@YG?AV?$shared_ptr@VBuffer@jsi@facebook@@@std@@QB_WI@Z +?moduleNames@ModuleRegistry@react@facebook@@QEAA?AV?$vector@V?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@V?$allocator@V?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@@2@@std@@XZ ?at@dynamic@folly@@QGBEABU12@V?$Range@PBD@2@@Z ?atImpl@dynamic@folly@@AGBEABU12@ABU12@@Z ?callJSFunction@Instance@react@facebook@@QAEX$$QAV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@0$$QAUdynamic@folly@@@Z From 30650f72fde21b2b3762416f525dad3af66b3f23 Mon Sep 17 00:00:00 2001 From: Nick Gerleman Date: Fri, 20 Dec 2019 12:33:14 -0800 Subject: [PATCH 2/3] Change files --- .../react-native-windows-2019-12-20-12-33-14-master.json | 8 ++++++++ 1 file changed, 8 insertions(+) create mode 100644 change/react-native-windows-2019-12-20-12-33-14-master.json diff --git a/change/react-native-windows-2019-12-20-12-33-14-master.json b/change/react-native-windows-2019-12-20-12-33-14-master.json new file mode 100644 index 00000000000..604c6eb3fe6 --- /dev/null +++ b/change/react-native-windows-2019-12-20-12-33-14-master.json @@ -0,0 +1,8 @@ +{ + "type": "prerelease", + "comment": "Export ability to query native module names", + "packageName": "react-native-windows", + "email": "ngerlem@microsoft.com", + "commit": "5ff50e103744a589228c020ef0fad45d699458cd", + "date": "2019-12-20T20:33:14.307Z" +} \ No newline at end of file From d926f2493341233eafd743c0c6c9e266a96cad4d Mon Sep 17 00:00:00 2001 From: Nick Gerleman Date: Fri, 20 Dec 2019 12:47:24 -0800 Subject: [PATCH 3/3] Fix x86 mangeled name --- vnext/Desktop.DLL/react-native-win32.x86.def | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/vnext/Desktop.DLL/react-native-win32.x86.def b/vnext/Desktop.DLL/react-native-win32.x86.def index 1eacb60c51b..3ae99c59aa4 100644 --- a/vnext/Desktop.DLL/react-native-win32.x86.def +++ b/vnext/Desktop.DLL/react-native-win32.x86.def @@ -27,7 +27,7 @@ EXPORTS ?Make@IWebSocket@React@Microsoft@@SG?AV?$unique_ptr@UIWebSocket@React@Microsoft@@U?$default_delete@UIWebSocket@React@Microsoft@@@std@@@std@@ABV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@5@@Z ?Make@JSBigAbiString@react@facebook@@SG?AV?$unique_ptr@$$CBUJSBigAbiString@react@facebook@@U?$default_delete@$$CBUJSBigAbiString@react@facebook@@@std@@@std@@$$QAV?$unique_ptr@U?$IAbiArray@D@AbiSafe@@UAbiObjectDeleter@2@@5@@Z ?MakeMemoryMappedBuffer@JSI@Microsoft@@YG?AV?$shared_ptr@VBuffer@jsi@facebook@@@std@@QB_WI@Z -?moduleNames@ModuleRegistry@react@facebook@@QEAA?AV?$vector@V?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@V?$allocator@V?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@@2@@std@@XZ +?moduleNames@ModuleRegistry@react@facebook@@QAE?AV?$vector@V?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@V?$allocator@V?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@@2@@std@@XZ ?at@dynamic@folly@@QGBEABU12@V?$Range@PBD@2@@Z ?atImpl@dynamic@folly@@AGBEABU12@ABU12@@Z ?callJSFunction@Instance@react@facebook@@QAEX$$QAV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@0$$QAUdynamic@folly@@@Z