From 7e31a226eb25bc31992027c8dc8990b0b05c10f5 Mon Sep 17 00:00:00 2001 From: Alexander Sklar Date: Fri, 24 Apr 2020 16:01:42 -0700 Subject: [PATCH 1/2] Fix typo causing activity indicators to be sad and colorless --- vnext/ReactUWP/Views/ActivityIndicatorViewManager.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/vnext/ReactUWP/Views/ActivityIndicatorViewManager.cpp b/vnext/ReactUWP/Views/ActivityIndicatorViewManager.cpp index 1e4dfcd711b..dee000c547d 100644 --- a/vnext/ReactUWP/Views/ActivityIndicatorViewManager.cpp +++ b/vnext/ReactUWP/Views/ActivityIndicatorViewManager.cpp @@ -45,7 +45,7 @@ bool ActivityIndicatorViewManager::UpdateProperty( else if (propertyValue.isNull()) progressRing.ClearValue(winrt::ProgressRing::IsActiveProperty()); } else { - return Super::UpdateProperty(nodeToUpdate, propertyName, propertyName); + return Super::UpdateProperty(nodeToUpdate, propertyName, propertyValue); } return true; } From 7e7222c689b698327fe9b2cb7907d75aa6bce1d5 Mon Sep 17 00:00:00 2001 From: Alexander Sklar Date: Fri, 24 Apr 2020 16:02:17 -0700 Subject: [PATCH 2/2] Change files --- change/react-native-windows-2020-04-24-16-02-17-4700.json | 8 ++++++++ 1 file changed, 8 insertions(+) create mode 100644 change/react-native-windows-2020-04-24-16-02-17-4700.json diff --git a/change/react-native-windows-2020-04-24-16-02-17-4700.json b/change/react-native-windows-2020-04-24-16-02-17-4700.json new file mode 100644 index 00000000000..4513ffcc4a3 --- /dev/null +++ b/change/react-native-windows-2020-04-24-16-02-17-4700.json @@ -0,0 +1,8 @@ +{ + "type": "prerelease", + "comment": "Fix typo causing activity indicators to be sad and colorless", + "packageName": "react-native-windows", + "email": "asklar@microsoft.com", + "dependentChangeType": "patch", + "date": "2020-04-24T23:02:17.176Z" +}