From 60ae2d2c0244a2399b3e7cb61e337d7579e9491e Mon Sep 17 00:00:00 2001 From: Jake Bailey <5341706+jakebailey@users.noreply.github.com> Date: Wed, 22 Oct 2025 09:57:46 -0700 Subject: [PATCH 1/2] Use a different set of commands to detect fourslash test updates --- .github/workflows/ci.yml | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index c9d2d707b9..1fd1011243 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -243,7 +243,16 @@ jobs: - run: node --experimental-strip-types ./internal/lsp/lsproto/_generate/generate.mts - name: Regenerate fourslash tests and update failing test list - run: npm run updatefailing + run: | + echo "" > ./internal/fourslash/_scripts/failingTests.txt + npm run convertfourslash + npx hereby test + npx hereby baseline-accept + npm run updatefailing + npx hereby baseline-accept + rm -rf testdata/baselines/reference/fourslash + npx hereby test + npx hereby baseline-accept - run: git add . - run: git diff --staged --exit-code --stat From 3774646014e473d77ac26ad517e3799c6aade2bb Mon Sep 17 00:00:00 2001 From: Jake Bailey <5341706+jakebailey@users.noreply.github.com> Date: Wed, 22 Oct 2025 10:14:38 -0700 Subject: [PATCH 2/2] or true --- .github/workflows/ci.yml | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 1fd1011243..02a9296f14 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -245,14 +245,14 @@ jobs: - name: Regenerate fourslash tests and update failing test list run: | echo "" > ./internal/fourslash/_scripts/failingTests.txt - npm run convertfourslash - npx hereby test - npx hereby baseline-accept - npm run updatefailing - npx hereby baseline-accept - rm -rf testdata/baselines/reference/fourslash - npx hereby test - npx hereby baseline-accept + npm run convertfourslash || true + npx hereby test || true + npx hereby baseline-accept || true + npm run updatefailing || true + npx hereby baseline-accept || true + rm -rf testdata/baselines/reference/fourslash || true + npx hereby test || true + npx hereby baseline-accept || true - run: git add . - run: git diff --staged --exit-code --stat