From 5f8344b309f75934900c886e2799637f2dd1e1cc Mon Sep 17 00:00:00 2001 From: Weidong Xu Date: Thu, 4 Dec 2025 10:54:51 +0800 Subject: [PATCH 1/3] http-client-java, fix format on module-info.java --- .../implementation/CodeFormatterUtil.java | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/packages/http-client-java/generator/http-client-generator-core/src/main/java/com/microsoft/typespec/http/client/generator/core/postprocessor/implementation/CodeFormatterUtil.java b/packages/http-client-java/generator/http-client-generator-core/src/main/java/com/microsoft/typespec/http/client/generator/core/postprocessor/implementation/CodeFormatterUtil.java index af61be66011..4e0422a2573 100644 --- a/packages/http-client-java/generator/http-client-generator-core/src/main/java/com/microsoft/typespec/http/client/generator/core/postprocessor/implementation/CodeFormatterUtil.java +++ b/packages/http-client-java/generator/http-client-generator-core/src/main/java/com/microsoft/typespec/http/client/generator/core/postprocessor/implementation/CodeFormatterUtil.java @@ -191,7 +191,15 @@ private static String importToString(ImportDeclaration importDeclaration) { private static String formatCode(String file, String fileName, CodeFormatter codeFormatter) throws Exception { IDocument doc = new Document(file); - boolean isModuleInfo = IModule.MODULE_INFO_JAVA.equals(fileName); + boolean isModuleInfo = fileName.endsWith(IModule.MODULE_INFO_JAVA); + if (isModuleInfo) { + // candidate module-info.java, confirm by check file content about module declaration + CompilationUnit compilationUnit = StaticJavaParser.parse(file); + if (compilationUnit.getModule().isEmpty()) { + // not module-info.java + isModuleInfo = false; + } + } int kind = isModuleInfo ? CodeFormatter.K_MODULE_INFO : CodeFormatter.K_COMPILATION_UNIT; kind |= CodeFormatter.F_INCLUDE_COMMENTS; TextEdit edit = codeFormatter.format(kind, file, 0, file.length(), 0, Constants.NEW_LINE); From df7b6488ee6a0879a2643143c40a7d2c08669d2d Mon Sep 17 00:00:00 2001 From: Weidong Xu Date: Thu, 4 Dec 2025 11:51:32 +0800 Subject: [PATCH 2/3] clean up spotless in resources/pom.xml --- .../src/main/resources/spotless-pom.xml | 41 ------------------- .../src/main/resources/readme/pom.xml | 38 ----------------- 2 files changed, 79 deletions(-) delete mode 100644 packages/http-client-java/generator/http-client-generator-mgmt/src/main/resources/spotless-pom.xml diff --git a/packages/http-client-java/generator/http-client-generator-mgmt/src/main/resources/spotless-pom.xml b/packages/http-client-java/generator/http-client-generator-mgmt/src/main/resources/spotless-pom.xml deleted file mode 100644 index e4179288d7f..00000000000 --- a/packages/http-client-java/generator/http-client-generator-mgmt/src/main/resources/spotless-pom.xml +++ /dev/null @@ -1,41 +0,0 @@ - - - - - azure-autorest-parent - com.azure.tools - 1.0.0-beta.5 - - - com.azure.tools - fluentgen-code-formatter - 1.0.0-beta.1 - 4.0.0 - - - - - com.diffplug.spotless - spotless-maven-plugin - 2.40.0 - - - - src/main/java/**/*.java - src/samples/java/**/*.java - src/test/java/**/*.java - - - - - 4.21 - eclipse-format-azure-sdk-for-java.xml - - - - - - - diff --git a/packages/http-client-java/generator/http-client-generator/src/main/resources/readme/pom.xml b/packages/http-client-java/generator/http-client-generator/src/main/resources/readme/pom.xml index 0209c9c2356..58fc6b54d73 100644 --- a/packages/http-client-java/generator/http-client-generator/src/main/resources/readme/pom.xml +++ b/packages/http-client-java/generator/http-client-generator/src/main/resources/readme/pom.xml @@ -21,42 +21,4 @@ 1.0.0-beta.1 - - - - spotless - - - spotless - - - - - - - - - com.diffplug.spotless - spotless-maven-plugin - 2.40.0 - - - - src/main/java/**/*.java - src/samples/java/**/*.java - src/test/java/**/*.java - - - - - 4.21 - ../eclipse-format-azure-sdk-for-java.xml - - - - - - - - From a30ee1f6b3af2bf658320134178bee6211b12d43 Mon Sep 17 00:00:00 2001 From: Weidong Xu Date: Thu, 4 Dec 2025 11:53:46 +0800 Subject: [PATCH 3/3] version bump to 0.6.0 --- .../http-client-generator-clientcore-test/package.json | 2 +- .../generator/http-client-generator-test/package.json | 2 +- packages/http-client-java/package-lock.json | 4 ++-- packages/http-client-java/package.json | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/packages/http-client-java/generator/http-client-generator-clientcore-test/package.json b/packages/http-client-java/generator/http-client-generator-clientcore-test/package.json index f92da45b1af..649091a54ae 100644 --- a/packages/http-client-java/generator/http-client-generator-clientcore-test/package.json +++ b/packages/http-client-java/generator/http-client-generator-clientcore-test/package.json @@ -16,7 +16,7 @@ "@typespec/spec-api": "0.1.0-alpha.10", "@typespec/http-specs": "0.1.0-alpha.28", "@typespec/json-schema": "1.6.0", - "@typespec/http-client-java": "file:../../typespec-http-client-java-0.5.1.tgz", + "@typespec/http-client-java": "file:../../typespec-http-client-java-0.6.0.tgz", "@typespec/http-client-java-tests": "file:" }, "overrides": { diff --git a/packages/http-client-java/generator/http-client-generator-test/package.json b/packages/http-client-java/generator/http-client-generator-test/package.json index d1ab99ad9cf..9b649a5d783 100644 --- a/packages/http-client-java/generator/http-client-generator-test/package.json +++ b/packages/http-client-java/generator/http-client-generator-test/package.json @@ -16,7 +16,7 @@ "@typespec/spec-api": "0.1.0-alpha.10", "@typespec/http-specs": "0.1.0-alpha.28", "@azure-tools/azure-http-specs": "0.1.0-alpha.32", - "@typespec/http-client-java": "file:../../typespec-http-client-java-0.5.1.tgz", + "@typespec/http-client-java": "file:../../typespec-http-client-java-0.6.0.tgz", "@typespec/http-client-java-tests": "file:" }, "overrides": { diff --git a/packages/http-client-java/package-lock.json b/packages/http-client-java/package-lock.json index d1bd9c4da7a..a4bbdc667de 100644 --- a/packages/http-client-java/package-lock.json +++ b/packages/http-client-java/package-lock.json @@ -1,12 +1,12 @@ { "name": "@typespec/http-client-java", - "version": "0.5.1", + "version": "0.6.0", "lockfileVersion": 3, "requires": true, "packages": { "": { "name": "@typespec/http-client-java", - "version": "0.5.1", + "version": "0.6.0", "license": "MIT", "dependencies": { "@autorest/codemodel": "~4.20.1", diff --git a/packages/http-client-java/package.json b/packages/http-client-java/package.json index 4fec5b1fdcd..63f510b4c5a 100644 --- a/packages/http-client-java/package.json +++ b/packages/http-client-java/package.json @@ -1,6 +1,6 @@ { "name": "@typespec/http-client-java", - "version": "0.5.1", + "version": "0.6.0", "description": "TypeSpec library for emitting Java client from the TypeSpec REST protocol binding", "keywords": [ "TypeSpec"